You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "ascheman (via GitHub)" <gi...@apache.org> on 2026/10/09 22:49:36 UTC

[PR] [HOLD until maven-sources#57 swap] Switch default-branch metadata to Maven 3 (`.asf.yaml` + `.github`) [maven-deploy-plugin]

ascheman opened a new pull request, #718:
URL: https://github.com/apache/maven-deploy-plugin/pull/718

   
   Part of apache/maven-sources#57 (switching plugin default branches back to Maven 3, cf. [Plan / runbook](https://cwiki.apache.org/confluence/x/85fwGg)).
   
   ⛔ **DO NOT MERGE before the swap.** This PR should be merged immediately around the branch rename on **2026-10-18** (coordinated with INFRA). Please review/approve by **2026-10-16** so it can be merged right at the switch.
   
   This prepares the `maven-deploy-plugin-3.x` branch to become the default `master` after the swap. Config GitHub reads from the **default branch** must already live on the incoming default branch, or it is silently dropped at the switch.
   
   ## What changes
   
   ### `.asf.yaml`
   Adopts the **current `master`'s `.asf.yaml` wholesale** (branch protection, project metadata, features — whatever master carries today), with the **single intended difference** being the protected-branch rename `maven-deploy-plugin-3.x` → `maven-deploy-plugin-4.x`:
   
   ```diff
   -    maven-deploy-plugin-3.x: { }
   +    maven-deploy-plugin-4.x: { }
   ```
   
   Why: ASF asfyaml only honours the **default branch's** `.asf.yaml`, so anything that lives only on today's `master` would be silently lost once this dormant `-3.x` branch becomes the new `master`. No `default_branch` is set — the default pointer is restored to `master` by **INFRA** as part of the renames.
   
   It also drops the `-3.x`-only, now-vestigial `jira_options` / `autolink_jira` (not present on master; the Maven JIRA has migrated to GitHub issues). Say so in review if you want it kept on the Maven 3 line.
   
   ### `.github/`
   `.github/` is read from the **default branch**, so the swap must carry the repo-wide, default-sourced parts or they silently drop:
   - **adds** the `ISSUE_TEMPLATE/` forms and the scheduled `stale.yml` that `master` has and this branch was missing;
   - **aligns** `pull_request_template.md` to master's current version.
   
   Line-specific config stays the Maven 3 line's — `dependabot.yml`, the `maven-verify` CI, and **release-drafter** (workflow + any config) are deliberately left untouched. Whether the Maven 3 line should auto-draft releases is a separate call for @slawekjaranowski, not something to flip silently here.
   
   ## Short inconsistency window after merge
   Until the rename completes and Jenkins re-discovers branches, `job/master` is still today's Maven 4 job and the `-4.x` job doesn't exist yet, so some badges/links briefly point at not-yet-existing branches. Expected; it resolves once the 2026-10-18 swap finishes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Switch default-branch metadata to Maven 3 (`.asf.yaml` + `.github`) [maven-deploy-plugin]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #718:
URL: https://github.com/apache/maven-deploy-plugin/pull/718#issuecomment-6261286898

   @ascheman Please assign appropriate label to PR according to the type of change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HOLD until maven-sources#57 swap] Switch default-branch metadata to Maven 3 (`.asf.yaml` + `.github`) [maven-deploy-plugin]

Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on code in PR #718:
URL: https://github.com/apache/maven-deploy-plugin/pull/718#discussion_r4235252330


##########
.github/ISSUE_TEMPLATE/FEATURE.yml:
##########
@@ -0,0 +1,35 @@
+#
+#  Licensed to the Apache Software Foundation (ASF) under one or more
+#  contributor license agreements.  See the NOTICE file distributed with
+#  this work for additional information regarding copyright ownership.
+#  The ASF licenses this file to You under the Apache License, Version 2.0
+#  (the "License"); you may not use this file except in compliance with
+#  the License.  You may obtain a copy of the License at
+#
+#       http://www.apache.org/licenses/LICENSE-2.0
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+#  limitations under the License.
+#
+
+# https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema
+
+name: Feature request
+description: File a proposal for new feature, improvement
+labels: ["enhancement"]
+
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Thanks for taking the time to fill out this new feature, improvement proposal.
+
+  - type: textarea
+    id: massage

Review Comment:
   💡 **Nit:** `id: massage` → `id: message` (same typo as in BUG.yml, pre-existing from master).



##########
.github/ISSUE_TEMPLATE/BUG.yml:
##########
@@ -0,0 +1,48 @@
+#
+#  Licensed to the Apache Software Foundation (ASF) under one or more
+#  contributor license agreements.  See the NOTICE file distributed with
+#  this work for additional information regarding copyright ownership.
+#  The ASF licenses this file to You under the Apache License, Version 2.0
+#  (the "License"); you may not use this file except in compliance with
+#  the License.  You may obtain a copy of the License at
+#
+#       http://www.apache.org/licenses/LICENSE-2.0
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+#  limitations under the License.
+#
+
+# https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema
+
+name: Bug Report
+description: File a bug report
+labels: ["bug"]
+
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Thanks for taking the time to fill out this bug report.     
+
+        Simple fixes in single PRs do not require issues. 
+  
+        **Do you use the latest project version?**
+
+  - type: input
+    id: version
+    attributes:
+      label: Affected version
+    validations:
+      required: true
+
+  - type: textarea
+    id: massage

Review Comment:
   💡 **Nit:** `id: massage` → `id: message` (typo). This appears to be pre-existing on master — worth fixing there too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Switch default-branch metadata to Maven 3 (`.asf.yaml` + `.github`) [maven-deploy-plugin]

Posted by "ascheman (via GitHub)" <gi...@apache.org>.
ascheman merged PR #718:
URL: https://github.com/apache/maven-deploy-plugin/pull/718


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org