You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/06/07 11:10:19 UTC
[GitHub] [brooklyn-ui] algairim opened a new pull request #214: WIP Drang & Drop confirmation menu in the Designer
algairim opened a new pull request #214:
URL: https://github.com/apache/brooklyn-ui/pull/214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] iuliana merged pull request #214: Drang & Drop confirmation menu in the Designer
Posted by GitBox <gi...@apache.org>.
iuliana merged pull request #214:
URL: https://github.com/apache/brooklyn-ui/pull/214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on pull request #214: Drang & Drop confirmation menu in the Designer
Posted by GitBox <gi...@apache.org>.
algairim commented on pull request #214:
URL: https://github.com/apache/brooklyn-ui/pull/214#issuecomment-856072139
Will try to add some tests later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on a change in pull request #214: Drang & Drop confirmation menu in the Designer
Posted by GitBox <gi...@apache.org>.
algairim commented on a change in pull request #214:
URL: https://github.com/apache/brooklyn-ui/pull/214#discussion_r647340548
##########
File path: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js
##########
@@ -39,6 +39,11 @@ const SUBSECTION = {
PARAMETERS: 'parameters'
}
+export const SUBSECTION_TEMPLATE_URL = {
Review comment:
I do not have an answer at this time. I'm open for suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on pull request #214: Drang & Drop confirmation menu in the Designer
Posted by GitBox <gi...@apache.org>.
algairim commented on pull request #214:
URL: https://github.com/apache/brooklyn-ui/pull/214#issuecomment-856537382
More tests added in 3e4ecf4d247b8f35f391f3022cc71b8f75b18843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on a change in pull request #214: Drang & Drop confirmation menu in the Designer
Posted by GitBox <gi...@apache.org>.
algairim commented on a change in pull request #214:
URL: https://github.com/apache/brooklyn-ui/pull/214#discussion_r647340548
##########
File path: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js
##########
@@ -39,6 +39,11 @@ const SUBSECTION = {
PARAMETERS: 'parameters'
}
+export const SUBSECTION_TEMPLATE_URL = {
Review comment:
I do not have an answer at this time. I'm open to suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on a change in pull request #214: Drang & Drop confirmation menu in the Designer
Posted by GitBox <gi...@apache.org>.
algairim commented on a change in pull request #214:
URL: https://github.com/apache/brooklyn-ui/pull/214#discussion_r646740955
##########
File path: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.spec.js
##########
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import SpecEditor, {SUBSECTION_TEMPLATE_URL} from './spec-editor.directive';
+import {iconGeneratorProvider} from 'brooklyn-ui-utils/icon-generator/icon-generator';
+import {locationApiProvider} from 'brooklyn-ui-utils/providers/location-api.provider';
+import {catalogApiProvider} from 'brooklyn-ui-utils/providers/catalog-api.provider';
+import {mdHelperFactory} from 'brooklyn-ui-utils/md-helper';
+import {Entity} from '../util/model/entity.model';
+import {paletteApiProvider} from '../providers/palette-api.provider';
+import {dslServiceProvider} from '../providers/dsl-service.provider';
+import {blueprintServiceProvider} from '../providers/blueprint-service.provider';
+
+/**
+ * Tests for the spec-editor directive.
+ */
Review comment:
This is an attempt to start adding tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] ahgittin commented on a change in pull request #214: Drang & Drop confirmation menu in the Designer
Posted by GitBox <gi...@apache.org>.
ahgittin commented on a change in pull request #214:
URL: https://github.com/apache/brooklyn-ui/pull/214#discussion_r647293705
##########
File path: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js
##########
@@ -39,6 +39,11 @@ const SUBSECTION = {
PARAMETERS: 'parameters'
}
+export const SUBSECTION_TEMPLATE_URL = {
Review comment:
is there any way we can allow a downstream project to update the template cache directly, without downstream-only constants being necessary here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on a change in pull request #214: Drang & Drop confirmation menu in the Designer
Posted by GitBox <gi...@apache.org>.
algairim commented on a change in pull request #214:
URL: https://github.com/apache/brooklyn-ui/pull/214#discussion_r647340548
##########
File path: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js
##########
@@ -39,6 +39,11 @@ const SUBSECTION = {
PARAMETERS: 'parameters'
}
+export const SUBSECTION_TEMPLATE_URL = {
Review comment:
I do not have an answer at this time. Open to suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] ahgittin commented on pull request #214: Drang & Drop confirmation menu in the Designer
Posted by GitBox <gi...@apache.org>.
ahgittin commented on pull request #214:
URL: https://github.com/apache/brooklyn-ui/pull/214#issuecomment-856629799
one thing to change if possible; if not, fine to merge as is
nice to have some tests! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org