You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "smallzhongfeng (via GitHub)" <gi...@apache.org> on 2023/03/08 04:18:44 UTC
[GitHub] [incubator-uniffle] smallzhongfeng opened a new pull request, #694: [#691] test :fix flaky test CoordinatorMetricsTest#testCoordinatorMetrics
smallzhongfeng opened a new pull request, #694:
URL: https://github.com/apache/incubator-uniffle/pull/694
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
Do not start quotaManager when performing ut test of indicators.
### Why are the changes needed?
Fix: #691
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Fix ut.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on pull request #694: [DON'T MERGE][#691] test :fix flaky test CoordinatorMetricsTest#testCoordinatorMetrics
Posted by "smallzhongfeng (via GitHub)" <gi...@apache.org>.
smallzhongfeng commented on PR #694:
URL: https://github.com/apache/incubator-uniffle/pull/694#issuecomment-1460322433
I tried to find out why `testCoordinatorMetrics` in `CoordinatorMetricsTest` collected `app_num` in `QuotaManagerTest # testCheckQuotaMetrics`, but there are not many clues. At present, the simplest way is to filter out `app_num` in the indicators, do you have any good suggestions ? @jerqi @advancedxy @xianjingfeng
The result as follow:
```
Test metrics => [
{"name":"running_app_num","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
{"name":"total_quota_denied_request","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
{"name":"total_load_denied_request","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
{"name":"total_server_num","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
{"name":"remote_storage_in_used_path1","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
{"name":"total_candidates_denied_request","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
{"name":"total_app_num","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
{"name":"app_num","labelNames":["user_name"],"labelValues":["user3"],"value":0.0,"timestampMs":null},
{"name":"app_num","labelNames":["user_name"],"labelValues":["user4"],"value":0.0,"timestampMs":null},
{"name":"unhealthy_server_num","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
{"name":"total_access_request","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
{"name":"exclude_server_num","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null}]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #694: [#691] test :fix flaky test CoordinatorMetricsTest#testCoordinatorMetrics
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on code in PR #694:
URL: https://github.com/apache/incubator-uniffle/pull/694#discussion_r1130391369
##########
coordinator/src/test/java/org/apache/uniffle/coordinator/metric/CoordinatorMetricsTest.java:
##########
@@ -89,7 +89,14 @@ public void testCoordinatorMetrics() throws Exception {
ObjectMapper mapper = new ObjectMapper();
JsonNode actualObj = mapper.readTree(content);
assertEquals(2, actualObj.size());
- assertEquals(10, actualObj.get("metrics").size());
+ int actualMetrics = 0;
+ for (JsonNode metrics : actualObj.get("metrics")) {
+ if (CoordinatorMetrics.APP_NUM_TO_USER.equals(metrics.get("name").textValue())) {
Review Comment:
I'm not sure about this change.
The better way is to call `org.apache.uniffle.coordinator.metric.CoordinatorMetrics#clear` in `@beforeAll` of this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #694: [DON'T MERGE][#691] test :fix flaky test CoordinatorMetricsTest#testCoordinatorMetrics
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #694:
URL: https://github.com/apache/incubator-uniffle/pull/694#issuecomment-1459610087
# [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/694?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#694](https://codecov.io/gh/apache/incubator-uniffle/pull/694?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (45426ca) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/ffa50b979ea6ae11b423646cc0c2381af29e4cf8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ffa50b9) will **increase** coverage by `2.23%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #694 +/- ##
============================================
+ Coverage 60.80% 63.03% +2.23%
Complexity 1840 1840
============================================
Files 221 207 -14
Lines 12648 10684 -1964
Branches 1062 1062
============================================
- Hits 7690 6735 -955
+ Misses 4552 3603 -949
+ Partials 406 346 -60
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-uniffle/pull/694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...bernetes/operator/pkg/controller/controller/rss.go](https://codecov.io/gh/apache/incubator-uniffle/pull/694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVwbG95L2t1YmVybmV0ZXMvb3BlcmF0b3IvcGtnL2NvbnRyb2xsZXIvY29udHJvbGxlci9yc3MuZ28=) | | |
| [deploy/kubernetes/operator/pkg/utils/config.go](https://codecov.io/gh/apache/incubator-uniffle/pull/694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVwbG95L2t1YmVybmV0ZXMvb3BlcmF0b3IvcGtnL3V0aWxzL2NvbmZpZy5nbw==) | | |
| [deploy/kubernetes/operator/pkg/utils/util.go](https://codecov.io/gh/apache/incubator-uniffle/pull/694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVwbG95L2t1YmVybmV0ZXMvb3BlcmF0b3IvcGtnL3V0aWxzL3V0aWwuZ28=) | | |
| [...y/kubernetes/operator/pkg/webhook/inspector/pod.go](https://codecov.io/gh/apache/incubator-uniffle/pull/694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVwbG95L2t1YmVybmV0ZXMvb3BlcmF0b3IvcGtnL3dlYmhvb2svaW5zcGVjdG9yL3BvZC5nbw==) | | |
| [...y/kubernetes/operator/pkg/webhook/inspector/rss.go](https://codecov.io/gh/apache/incubator-uniffle/pull/694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVwbG95L2t1YmVybmV0ZXMvb3BlcmF0b3IvcGtnL3dlYmhvb2svaW5zcGVjdG9yL3Jzcy5nbw==) | | |
| [...tor/pkg/controller/sync/coordinator/coordinator.go](https://codecov.io/gh/apache/incubator-uniffle/pull/694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVwbG95L2t1YmVybmV0ZXMvb3BlcmF0b3IvcGtnL2NvbnRyb2xsZXIvc3luYy9jb29yZGluYXRvci9jb29yZGluYXRvci5nbw==) | | |
| [...eploy/kubernetes/operator/pkg/utils/coordinator.go](https://codecov.io/gh/apache/incubator-uniffle/pull/694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVwbG95L2t1YmVybmV0ZXMvb3BlcmF0b3IvcGtnL3V0aWxzL2Nvb3JkaW5hdG9yLmdv) | | |
| [deploy/kubernetes/operator/pkg/utils/certs.go](https://codecov.io/gh/apache/incubator-uniffle/pull/694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVwbG95L2t1YmVybmV0ZXMvb3BlcmF0b3IvcGtnL3V0aWxzL2NlcnRzLmdv) | | |
| [...rnetes/operator/pkg/webhook/inspector/inspector.go](https://codecov.io/gh/apache/incubator-uniffle/pull/694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVwbG95L2t1YmVybmV0ZXMvb3BlcmF0b3IvcGtnL3dlYmhvb2svaW5zcGVjdG9yL2luc3BlY3Rvci5nbw==) | | |
| [...pkg/controller/sync/shuffleserver/shuffleserver.go](https://codecov.io/gh/apache/incubator-uniffle/pull/694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVwbG95L2t1YmVybmV0ZXMvb3BlcmF0b3IvcGtnL2NvbnRyb2xsZXIvc3luYy9zaHVmZmxlc2VydmVyL3NodWZmbGVzZXJ2ZXIuZ28=) | | |
| ... and [4 more](https://codecov.io/gh/apache/incubator-uniffle/pull/694?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on pull request #694: [#691] test :fix flaky test CoordinatorMetricsTest#testCoordinatorMetrics
Posted by "smallzhongfeng (via GitHub)" <gi...@apache.org>.
smallzhongfeng commented on PR #694:
URL: https://github.com/apache/incubator-uniffle/pull/694#issuecomment-1461231396
PTAL @jerqi @xianjingfeng
This [https://github.com/apache/incubator-uniffle/actions/runs/4370690355/jobs/7645845268](https://github.com/apache/incubator-uniffle/actions/runs/4370690355/jobs/7645845268) failure is not cause by this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #694: [#691] test :fix flaky test CoordinatorMetricsTest#testCoordinatorMetrics
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #694:
URL: https://github.com/apache/incubator-uniffle/pull/694#discussion_r1130395415
##########
coordinator/src/test/java/org/apache/uniffle/coordinator/metric/CoordinatorMetricsTest.java:
##########
@@ -89,7 +89,14 @@ public void testCoordinatorMetrics() throws Exception {
ObjectMapper mapper = new ObjectMapper();
JsonNode actualObj = mapper.readTree(content);
assertEquals(2, actualObj.size());
- assertEquals(10, actualObj.get("metrics").size());
+ int actualMetrics = 0;
+ for (JsonNode metrics : actualObj.get("metrics")) {
+ if (CoordinatorMetrics.APP_NUM_TO_USER.equals(metrics.get("name").textValue())) {
Review Comment:
@smallzhongfeng tried, but it doesn't matter. This test is so flaky that we should fix this issue asap. So we use the simplest to fix first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on pull request #694: [#691] test :fix flaky test CoordinatorMetricsTest#testCoordinatorMetrics
Posted by "smallzhongfeng (via GitHub)" <gi...@apache.org>.
smallzhongfeng commented on PR #694:
URL: https://github.com/apache/incubator-uniffle/pull/694#issuecomment-1459414848
Please don't merge first. I will trigger GA more times. Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi merged pull request #694: [#691] test :fix flaky test CoordinatorMetricsTest#testCoordinatorMetrics
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi merged PR #694:
URL: https://github.com/apache/incubator-uniffle/pull/694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on a diff in pull request #694: [#691] test :fix flaky test CoordinatorMetricsTest#testCoordinatorMetrics
Posted by "smallzhongfeng (via GitHub)" <gi...@apache.org>.
smallzhongfeng commented on code in PR #694:
URL: https://github.com/apache/incubator-uniffle/pull/694#discussion_r1130526570
##########
coordinator/src/test/java/org/apache/uniffle/coordinator/metric/CoordinatorMetricsTest.java:
##########
@@ -89,7 +89,14 @@ public void testCoordinatorMetrics() throws Exception {
ObjectMapper mapper = new ObjectMapper();
JsonNode actualObj = mapper.readTree(content);
assertEquals(2, actualObj.size());
- assertEquals(10, actualObj.get("metrics").size());
+ int actualMetrics = 0;
+ for (JsonNode metrics : actualObj.get("metrics")) {
+ if (CoordinatorMetrics.APP_NUM_TO_USER.equals(metrics.get("name").textValue())) {
Review Comment:
Thanks for your advice, I have tried this method, but it still doesn't work. I don't think it's the reason why the monitoring didn't clean up, but when I ran the GA, it seems like reading the latest indicators of other uts. I tried to modify the default `JETTY_ HTTP_ PORT` and `RPC_ SERVER_ PORT`, but still not effective.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] xianjingfeng commented on pull request #694: [DON'T MERGE][#691] test :fix flaky test CoordinatorMetricsTest#testCoordinatorMetrics
Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng commented on PR #694:
URL: https://github.com/apache/incubator-uniffle/pull/694#issuecomment-1461117815
> I tried to find out why `testCoordinatorMetrics` in `CoordinatorMetricsTest` collected `app_num` in `QuotaManagerTest # testCheckQuotaMetrics`, but there are not many clues. At present, the simplest way is to filter out `app_num` in the indicators, do you have any good suggestions ? @jerqi @advancedxy @xianjingfeng
>
> The result as follow:
> ```
> Test metrics => [
> {"name":"running_app_num","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
> {"name":"total_quota_denied_request","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
> {"name":"total_load_denied_request","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
> {"name":"total_server_num","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
> {"name":"remote_storage_in_used_path1","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
> {"name":"total_candidates_denied_request","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
> {"name":"total_app_num","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
> {"name":"app_num","labelNames":["user_name"],"labelValues":["user3"],"value":0.0,"timestampMs":null},
> {"name":"app_num","labelNames":["user_name"],"labelValues":["user4"],"value":0.0,"timestampMs":null},
> {"name":"unhealthy_server_num","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
> {"name":"total_access_request","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
> {"name":"exclude_server_num","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null}]
> ```
I think we can remove this test case. it doesn't make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #694: [DON'T MERGE][#691] test :fix flaky test CoordinatorMetricsTest#testCoordinatorMetrics
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #694:
URL: https://github.com/apache/incubator-uniffle/pull/694#issuecomment-1461153546
> I tried to find out why `testCoordinatorMetrics` in `CoordinatorMetricsTest` collected `app_num` in `QuotaManagerTest # testCheckQuotaMetrics`, but there are not many clues. At present, the simplest way is to filter out `app_num` in the indicators, do you have any good suggestions ? @jerqi @advancedxy @xianjingfeng
>
> The result as follow:
>
> ```
> Test metrics => [
> {"name":"running_app_num","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
> {"name":"total_quota_denied_request","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
> {"name":"total_load_denied_request","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
> {"name":"total_server_num","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
> {"name":"remote_storage_in_used_path1","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
> {"name":"total_candidates_denied_request","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
> {"name":"total_app_num","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
> {"name":"app_num","labelNames":["user_name"],"labelValues":["user3"],"value":0.0,"timestampMs":null},
> {"name":"app_num","labelNames":["user_name"],"labelValues":["user4"],"value":0.0,"timestampMs":null},
> {"name":"unhealthy_server_num","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
> {"name":"total_access_request","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
> {"name":"exclude_server_num","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null}]
> ```
We can filter them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org