You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/05/05 00:50:53 UTC
[GitHub] [incubator-shenyu] hutaishi opened a new pull request, #3379: [fix:compatibility #3374]grpc plugin compatible with low version and output standard format json
hutaishi opened a new pull request, #3379:
URL: https://github.com/apache/incubator-shenyu/pull/3379
Fixes #3374
Compatible with low version and output standard format json
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `mvn clean install -Dmaven.javadoc.skip=true`.
## output standard format json
### before
### after
## defaultInstance field compatible
### before, grpc low version have no `defaultInstance` field.
<img width="1408" alt="图片" src="https://user-images.githubusercontent.com/12478263/166848973-7432ea23-2fae-4ed5-8336-4f2697bb61ec.png">
### after
```java
if (requestMarshaller instanceof MethodDescriptor.PrototypeMarshaller) {
MethodDescriptor.PrototypeMarshaller<?> prototypeMarshaller = (PrototypeMarshaller<?>) requestMarshaller;
if (Objects.isNull(prototypeMarshaller.getMessagePrototype())) {
throw new ShenyuException(String.format("can not get defaultInstance Field of %s", requestMarshaller.getClass()));
}
grpcRequestParamClass = prototypeMarshaller.getMessagePrototype().getClass();
}
```
## serviceName field compatible
### before
Lower versions do not have this field `serviceName` to throw exceptions
### after
No exception is thrown if the field is empty, and the service name is set if the field is not empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 merged pull request #3379: [fix:compatibility #3374]grpc plugin compatible with low version and output standard format json
Posted by GitBox <gi...@apache.org>.
yu199195 merged PR #3379:
URL: https://github.com/apache/incubator-shenyu/pull/3379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #3379: [fix:compatibility #3374]grpc plugin compatible with low version and output standard format json
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3379:
URL: https://github.com/apache/incubator-shenyu/pull/3379#issuecomment-1118075981
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3379?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3379](https://codecov.io/gh/apache/incubator-shenyu/pull/3379?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7473662) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/b4857520d4dc2aadde761991048d3b80a1095ee8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b485752) will **decrease** coverage by `0.08%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 7473662 differs from pull request most recent head 99ea72c. Consider uploading reports for the commit 99ea72c to get more accurate results
```diff
@@ Coverage Diff @@
## master #3379 +/- ##
============================================
- Coverage 65.41% 65.33% -0.09%
+ Complexity 5266 5257 -9
============================================
Files 761 761
Lines 21251 21255 +4
Branches 1931 1933 +2
============================================
- Hits 13902 13886 -16
- Misses 6063 6078 +15
- Partials 1286 1291 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/3379?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/shenyu/plugin/grpc/proto/MessageWriter.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3379/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9wcm90by9NZXNzYWdlV3JpdGVyLmphdmE=) | `56.25% <0.00%> (-18.75%)` | :arrow_down: |
| [...e/shenyu/plugin/grpc/proto/ShenyuGrpcResponse.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3379/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9wcm90by9TaGVueXVHcnBjUmVzcG9uc2UuamF2YQ==) | `66.66% <ø> (ø)` | |
| [...yu/sync/data/http/refresh/AbstractDataRefresh.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3379/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvcmVmcmVzaC9BYnN0cmFjdERhdGFSZWZyZXNoLmphdmE=) | `70.00% <0.00%> (-13.34%)` | :arrow_down: |
| [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3379/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `77.23% <0.00%> (-6.51%)` | :arrow_down: |
| [...ng/rocketmq/rocketmq/RocketMQLogCollectClient.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3379/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLXJvY2tldG1xL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcvcm9ja2V0bXEvcm9ja2V0bXEvUm9ja2V0TVFMb2dDb2xsZWN0Q2xpZW50LmphdmE=) | `72.00% <0.00%> (-4.00%)` | :arrow_down: |
| [...henyu/admin/service/impl/UpstreamCheckService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3379/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1Vwc3RyZWFtQ2hlY2tTZXJ2aWNlLmphdmE=) | `70.14% <0.00%> (-1.50%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3379?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3379?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b485752...99ea72c](https://codecov.io/gh/apache/incubator-shenyu/pull/3379?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org