You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@toree.apache.org by GitBox <gi...@apache.org> on 2019/10/23 17:35:03 UTC

[GitHub] [incubator-toree] kevin-bates opened a new pull request #178: [TOREE-421] Allow thread groups

kevin-bates opened a new pull request #178: [TOREE-421] Allow thread groups
URL: https://github.com/apache/incubator-toree/pull/178
 
 
   Remove the portions of Security Manager that restricted the creation of thread groups.  This change also preserves the prevention of calls to `System.exit()` from sub-threads/groups (including those derived from the restricted group) - otherwise such calls from threads in a new thread group can terminate the kernel.
   
   I chose **not** to implement the ability to preserve the existing logic whereby the creation of new groups are prevented (i.e., via a new boolean option `--prevent-new-thread-groups`) since it felt like adding something that probably isn't necessary.  If others disagree or we (eventually) find a good use-case for restoring that kind of functionality, we can add such an option at that time.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services