You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/09/17 18:02:45 UTC

[GitHub] [pinot] richardstartin commented on pull request #7443: adding instance method initialization

richardstartin commented on pull request #7443:
URL: https://github.com/apache/pinot/pull/7443#issuecomment-921982184


   I don't know how you feel about this (I could see the case for keeping it separate), but to prove this is really useful it might be nice to include a couple of applications in this PR, e.g. regex and JsonPath. Generally I like to go from the specific to the abstract, and having a few specific examples handled nicely by the abstraction gives me more confidence in its fitness for purpose. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org