You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/15 19:44:51 UTC

[GitHub] [airflow] ecerulm opened a new pull request #13089: Add identity pre-commit hook

ecerulm opened a new pull request #13089:
URL: https://github.com/apache/airflow/pull/13089


   This adds the "standard" `identity` hook to `.pre-commit-config.yaml`. 
   
   The hook is described at [pre-commit cli docs](https://pre-commit.com/#meta-identity)
   and just prints all the arguments passed to it (like filenames), so it's useful to show 
   what files are "selected" by `pre-commit` when trying out different `--from-ref`, `--to-ref`
   combinations.
   
   @potiuk 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #13089: Add identity pre-commit hook

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13089:
URL: https://github.com/apache/airflow/pull/13089#issuecomment-745526712


   Nice. So you found it :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #13089: Add identity pre-commit hook

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13089:
URL: https://github.com/apache/airflow/pull/13089#issuecomment-745569196


   That is being smart not cheating :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #13089: Add identity pre-commit hook

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13089:
URL: https://github.com/apache/airflow/pull/13089#issuecomment-745526033


   The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ecerulm commented on pull request #13089: Add identity pre-commit hook

Posted by GitBox <gi...@apache.org>.
ecerulm commented on pull request #13089:
URL: https://github.com/apache/airflow/pull/13089#issuecomment-745568610


   well, I "cheated" and asked  in stackoverflow and the pre-commit author himself [told me how](https://stackoverflow.com/a/65310233/90580) 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on a change in pull request #13089: Add identity pre-commit hook

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13089:
URL: https://github.com/apache/airflow/pull/13089#discussion_r543640442



##########
File path: BREEZE.rst
##########
@@ -751,6 +751,14 @@ The above will run mypy check for all files.
       </a>
     </div>
 
+If you want ever need to get a list of the files that will be checked (for troubleshooting when playing with the
+`--from-ref` and `--to-ref`

Review comment:
       double backticks to fix :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #13089: Add identity pre-commit hook

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13089:
URL: https://github.com/apache/airflow/pull/13089


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org