You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:36:08 UTC

[GitHub] [flink] rmetzger opened a new pull request #13892: [FLINK-19805] Revert "[FLINK-17295] Refactor the ExecutionAttemptID to consist of E…

rmetzger opened a new pull request #13892:
URL: https://github.com/apache/flink/pull/13892


   
   ## What is the purpose of the change
   
   This reverts commit b2e1c02db83e4eee6f561bb49feb9de70a445142 from FLINK-17295 (#11873)
   
   While debugging FLINK-19805, we noticed that re-using the exact same `ExecutionAttemptID` across multiple leader sessions can lead to severe inconsistencies in the system. 
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] KarmaGYZ commented on pull request #13892: [FLINK-19805] Revert "[FLINK-17295] Refactor the ExecutionAttemptID to consist of E…

Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on pull request #13892:
URL: https://github.com/apache/flink/pull/13892#issuecomment-721475758


   @tillrohrmann As the `ExecutionAttemptID` will be serialized, `AbstractID` might be a bit expensive. I suggest one of the following:
   - a random `short` (or even `byte`) is probably good enough.
   - replace the `JobID` with a random `AbstractID`. It might do a little bit of damage to the debugging in the session mode though.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #13892: [FLINK-19805] Revert "[FLINK-17295] Refactor the ExecutionAttemptID to consist of E…

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13892:
URL: https://github.com/apache/flink/pull/13892#issuecomment-720525135






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] rmetzger commented on pull request #13892: [FLINK-19805] Revert "[FLINK-17295] Refactor the ExecutionAttemptID to consist of E…

Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13892:
URL: https://github.com/apache/flink/pull/13892#issuecomment-721687043


   Thanks for the review Till! That's a good proposal! I'll investigate if a "light revert" is really turning out to be light. If that's the case, I'll close this PR in favor of a new one.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] tillrohrmann commented on pull request #13892: [FLINK-19805] Revert "[FLINK-17295] Refactor the ExecutionAttemptID to consist of E…

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #13892:
URL: https://github.com/apache/flink/pull/13892#issuecomment-721600559


   @KarmaGYZ I was not talking about how to fix the problem but how to best revert the change. I think it should be fine to use `AbstractID` as it has been used before as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] rmetzger closed pull request #13892: [FLINK-19805] Revert "[FLINK-17295] Refactor the ExecutionAttemptID to consist of E…

Posted by GitBox <gi...@apache.org>.
rmetzger closed pull request #13892:
URL: https://github.com/apache/flink/pull/13892


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] rmetzger commented on pull request #13892: [FLINK-19805] Revert "[FLINK-17295] Refactor the ExecutionAttemptID to consist of E…

Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13892:
URL: https://github.com/apache/flink/pull/13892#issuecomment-721911810


   Closing this PR in favor of https://github.com/apache/flink/pull/13929.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13892: [FLINK-19805] Revert "[FLINK-17295] Refactor the ExecutionAttemptID to consist of E…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13892:
URL: https://github.com/apache/flink/pull/13892#issuecomment-720606599






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org