You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "me2seeks (via GitHub)" <gi...@apache.org> on 2026/08/26 13:58:16 UTC

[PR] fix(tui): preserve legacy editor undo [maka]

me2seeks opened a new pull request, #3929:
URL: https://github.com/apache/maka/pull/3929

   ## Summary
   
   Preserve the editor's legacy `Ctrl+-` undo path until a side conversation exists.
   
   The TUI now reserves the ambiguous `0x1f` byte for side switching only while a side pair is active. Enhanced keyboard-protocol shortcuts and active side switching keep their existing behavior.
   
   Fixes #3928
   
   ## Verification
   
   - Regression test fails on `origin/main` and passes with this fix
   - `npm run lint`
   - `npm run format:check`
   - `npm run build`
   - `npm run typecheck`
   - `npm --workspace maka-agent run test:dist` — 514 passed
   - `npm run check:asf-headers`
   - `npx knip --workspace apps/desktop`
   - `npx knip --workspace packages/ui`
   - `git diff --check`
   
   Additional check: `npx knip --workspace packages/cli` reports five unused exported types that are already present on `origin/main`; this PR adds none of them.
   
   ## AI use
   
   Select exactly one:
   
   - [ ] No generative tool made a substantive contribution
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: Codex reproduced the legacy key collision, implemented the state-scoped interception, added the regression, and performed first-principles, adversarial, and simplification reviews.
   
   ## Checklist
   
   - [x] Tests cover the change and fail without it
   - [x] Lint, format, typecheck and the affected suites pass locally
   
   Does this PR entail a change in behavior?
   
   - [x] Yes — described under Summary above
   - [ ] No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] fix(tui): preserve legacy editor undo [maka]

Posted by "M4n5ter (via GitHub)" <gi...@apache.org>.
M4n5ter merged PR #3929:
URL: https://github.com/apache/maka/pull/3929


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org