You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Francesco Mari (JIRA)" <ji...@apache.org> on 2016/09/02 07:59:20 UTC

[jira] [Commented] (OAK-4744) Fix tests configuration

    [ https://issues.apache.org/jira/browse/OAK-4744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457855#comment-15457855 ] 

Francesco Mari commented on OAK-4744:
-------------------------------------

[~dulceanu], thanks for the patch. IIUC every time a {{FileStore}} is created, a new {{Executor}} is instantiated. Who takes care of shutting down this executor? Are we leaking threads when running tests?

> Fix tests configuration
> -----------------------
>
>                 Key: OAK-4744
>                 URL: https://issues.apache.org/jira/browse/OAK-4744
>             Project: Jackrabbit Oak
>          Issue Type: Technical task
>          Components: segment-tar
>            Reporter: Andrei Dulceanu
>            Assignee: Andrei Dulceanu
>             Fix For: Segment Tar 0.0.20
>
>         Attachments: OAK-4744-01.patch
>
>
> Although lots of tests use {{FileStore.getStats().getApproximateSize()}}, there is no configuration added to {{FileStore}} instance to accommodate this. All instances of {{FileStore}} should be configured to use a {{StatisticsProvider}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)