You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "snleee (via GitHub)" <gi...@apache.org> on 2023/07/04 08:33:13 UTC

[GitHub] [pinot] snleee opened a new issue, #11028: Improve `DateTimeGranularitySpec` to follow the convention of new dateTimeField

snleee opened a new issue, #11028:
URL: https://github.com/apache/pinot/issues/11028

   https://docs.pinot.apache.org/configuration-reference/schema#new-datetime-formats
   
   We have introduced the new datetime formats `e.g. EPOCH|MILLISECONDS|1`
   
   On the other hand, our granularity spec is still following the old format `e.g. 1:MILLISECONDS`. 
   
   We should provide the support of new format for `DateTimeGranularitySpec` as well.
   
   Proposed change:
   
   ```
   old format: 
   size:timeUnit -> 1:MILLISECONDS
   
   new format:
   timeUnit|size -> MILLISECONDS|1
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] Jackie-Jiang closed issue #11028: Improve `DateTimeGranularitySpec` to follow the convention of new dateTimeField

Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang closed issue #11028: Improve `DateTimeGranularitySpec` to follow the convention of new dateTimeField
URL: https://github.com/apache/pinot/issues/11028


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] s0nskar commented on issue #11028: Improve `DateTimeGranularitySpec` to follow the convention of new dateTimeField

Posted by "s0nskar (via GitHub)" <gi...@apache.org>.
s0nskar commented on issue #11028:
URL: https://github.com/apache/pinot/issues/11028#issuecomment-1621926984

   @snleee Raised PR for the same PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] s0nskar commented on issue #11028: Improve `DateTimeGranularitySpec` to follow the convention of new dateTimeField

Posted by "s0nskar (via GitHub)" <gi...@apache.org>.
s0nskar commented on issue #11028:
URL: https://github.com/apache/pinot/issues/11028#issuecomment-1620320403

   Hi @snleee, I would like to work on this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] snleee commented on issue #11028: Improve `DateTimeGranularitySpec` to follow the convention of new dateTimeField

Posted by "snleee (via GitHub)" <gi...@apache.org>.
snleee commented on issue #11028:
URL: https://github.com/apache/pinot/issues/11028#issuecomment-1619793555

   @rajagopr 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org