You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/12/17 14:06:38 UTC
[GitHub] [nifi-minifi-cpp] hunyadi-dev opened a new pull request #965: MINIFICPP-1288 - Refactor FlowController::start and FlowController reload
hunyadi-dev opened a new pull request #965:
URL: https://github.com/apache/nifi-minifi-cpp/pull/965
Update from PR #890.
The FlowController methods: start, stop, load, unload (and maybe even waitUnload), were strongly coupled and were controlled through FlowController states that made it difficult to argue about what goes on in each of them.
load had two versions with only minor differences, one reload (with a few extra steps) and one non-reload. The version that did the reload was only called during applyConfiguration, so I moved the extra behaviour required there (and renamed the related functions accordingly to prove there were no other instances of calling reload).
load was also changing the state of initialized_ read by only itself and start, but it is easy to argue that load is never called twice and start is never called without a preceeding load, proving this variable clutter.
Contains the following commits squashed from [hunyadi-dev:MINIFICPP-1288_FlowController_refactor_start_method](https://github.com/hunyadi-dev/nifi-minifi-cpp/commits/MINIFICPP-1288_FlowController_refactor_start_method):
- MINIFICPP-1288 - Decouple loads from reloads in FlowController (mid-refactor)
- MINIFICPP-1288 - Extract reinitializeSchedulersWithNewThreadPool from FlowController and use it to redefine reload (to be removed)
- MINIFICPP-1288 - Replace references for FlowController::load_with_reload (to be removed) to reload requirements and load_without_reload
- MINIFICPP-1288 - Remove load_with_reload method from the FlowController
- MINIFICPP-1288 - Rename FlowControl::load_without_reload to load
- MINIFICPP-1288 - Call a separate start method on FlowController start invocations that assumes that the FlowController is initialized
- MINIFICPP-1288 - Restore FlowController::start with the version asserting that the start is initialized
- MINIFICPP-1288 - Assert FlowController::load is never called twice and run tests accordingly
- MINIFICPP-1288 - Remove FlowController::initialized_ member variable
- MINIFICPP-1288 - Remove no longer used check on the return value of FlowController::start
- MINIFICPP-1288 - Rename reinitializeSchedulersWithNewThreadPool -> reinitializeSchedulersWithClearedThreadPool
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] hunyadi-dev closed pull request #965: MINIFICPP-1288 - Refactor FlowController::start and FlowController reload
Posted by GitBox <gi...@apache.org>.
hunyadi-dev closed pull request #965:
URL: https://github.com/apache/nifi-minifi-cpp/pull/965
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org