[jira] [Commented] (GEODE-237) Remove EntryEvent deprecated methods

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998706#comment-15998706 ] 

ASF GitHub Bot commented on GEODE-237:
--------------------------------------

Github user dschneider-pivotal commented on the issue:

    https://github.com/apache/geode/pull/464
  
    This change looks good. I noticed travis CI failed with the following. But it looks like isExpiration was removed in some other commit so it is not clear to me why this one got the following failure.
    
    :geode-core:compileTestJava/home/travis/build/apache/geode/geode-core/src/test/java/org/apache/geode/TXJUnitTest.java:3009: error: cannot find symbol
          assertTrue(!event.isExpiration());
                           ^
      symbol:   method isExpiration()
      location: variable event of type EntryEvent


> Remove EntryEvent deprecated methods
> ------------------------------------
>
>                 Key: GEODE-237
>                 URL: https://issues.apache.org/jira/browse/GEODE-237
>             Project: Geode
>          Issue Type: Sub-task
>            Reporter: Darrel Schneider
>            Assignee: Avinash Dongre
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The following EntryEvent methods need to be removed:
> - isLocalLoad: change to getOperation().isLocalLoad
> - isNetLoad: change to getOperation().isNetLoad
> - isLoad: change to getOperation().isLoad
> - isNetSearch: change to getOperation().isNetSearch
> - isBridgeEvent: change to hasClientOrigin
> these should be pretty easy to change



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)