[jira] [Updated] (HDFS-10872) Add MutableRate metrics for FSNamesystemLock operations

["Erik Krogen (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erik Krogen updated HDFS-10872:
-------------------------------
    Attachment: HDFS-10872.005.patch

Now that HADOOP-13782 has provided us with a metrics class which provides fast concurrent access to {{MutableRate}} metrics ({{MutableRatesWithAggregation}}), the patch has been refactored to make use of this. This required a minor modification to {{MetricsRegistry}} to export a {{newMutableRatesWithAggregation}} method to create a new metrics object in {{FSNamesystem}} to be able to pass into {{FSNamesystemLock}}. This is necessary since we want the lock hold metrics to be emitted within the {{FSNamesystem}} metrics registry but they are generated within {{FSNamesystemLock}}, so we pass the metric object down into the lock for modification. 

Attaching v005 patch. 

> Add MutableRate metrics for FSNamesystemLock operations
> -------------------------------------------------------
>
>                 Key: HDFS-10872
>                 URL: https://issues.apache.org/jira/browse/HDFS-10872
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Erik Krogen
>            Assignee: Erik Krogen
>         Attachments: FSLockPerf.java, HDFS-10872.000.patch, HDFS-10872.001.patch, HDFS-10872.002.patch, HDFS-10872.003.patch, HDFS-10872.004.patch, HDFS-10872.005.patch
>
>
> Add metrics for FSNamesystemLock operations to see, overall, how long each operation is holding the lock for. Use MutableRate metrics for now. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org