You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/30 07:28:48 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request #1483: Fix a few issues found by clang-check
yamt opened a new pull request #1483:
URL: https://github.com/apache/incubator-nuttx/pull/1483
## Summary
Fix a few issues found by clang-check
## Impact
They look like real bugs
## Testing
CI only
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1483: Fix a few issues found by clang-check
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1483:
URL: https://github.com/apache/incubator-nuttx/pull/1483#issuecomment-666091138
These changes look correct to me. I wonder if we could hook more of these checks up into the CI system. I had looked at trying to setup something with Clang Static Analyzer in the past, but there was still a fairly high false positive rate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #1483: Fix a few issues found by clang-check
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #1483:
URL: https://github.com/apache/incubator-nuttx/pull/1483#issuecomment-666389813
@yamt<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_yamt&d=DwMCaQ&c=fP4tf--1dS0biCFlB0saz0I0kjO5v7-GLPtvShAo4cc&r=9PLdMPCoy-UxqQeL_7fkXjdHjEO-awBtN4-Wr8MqKGE&m=2l5lFgQQSW0TkuSAqwJFsCh5v4C7nO5GbLRK7EIm8aM&s=QimsWhTvSvY365cH-KUTNM16WrnMAIkVAADyDllUDZ8&e=> and @btashton<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_btashton&d=DwMCaQ&c=fP4tf--1dS0biCFlB0saz0I0kjO5v7-GLPtvShAo4cc&r=9PLdMPCoy-UxqQeL_7fkXjdHjEO-awBtN4-Wr8MqKGE&m=2l5lFgQQSW0TkuSAqwJFsCh5v4C7nO5GbLRK7EIm8aM&s=7Dkc6xEnRKHgl3e7qKpg7OIvlU6ri8j6No6emRm0lp8&e=>, Thanks for poinitng it out
It would be great to have it integrated in CI even if we have to iron out the flase positives by hand
________________________________
Från: Xiang Xiao <no...@github.com>
Skickat: den 30 juli 2020 09:26
Till: apache/incubator-nuttx <in...@noreply.github.com>
Kopia: Subscribed <su...@noreply.github.com>
Ämne: Re: [apache/incubator-nuttx] Fix a few issues found by clang-check (#1483)
@yamt<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_yamt&d=DwMCaQ&c=fP4tf--1dS0biCFlB0saz0I0kjO5v7-GLPtvShAo4cc&r=9PLdMPCoy-UxqQeL_7fkXjdHjEO-awBtN4-Wr8MqKGE&m=2l5lFgQQSW0TkuSAqwJFsCh5v4C7nO5GbLRK7EIm8aM&s=QimsWhTvSvY365cH-KUTNM16WrnMAIkVAADyDllUDZ8&e=> and @btashton<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_btashton&d=DwMCaQ&c=fP4tf--1dS0biCFlB0saz0I0kjO5v7-GLPtvShAo4cc&r=9PLdMPCoy-UxqQeL_7fkXjdHjEO-awBtN4-Wr8MqKGE&m=2l5lFgQQSW0TkuSAqwJFsCh5v4C7nO5GbLRK7EIm8aM&s=7Dkc6xEnRKHgl3e7qKpg7OIvlU6ri8j6No6emRm0lp8&e=>, it's great if we can integrate the static analyzer into CI system, even it has some false positive. Before the falso alarm is reduece to an acceptable level, we can make this check optional.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_incubator-2Dnuttx_pull_1483-23issuecomment-2D666186757&d=DwMCaQ&c=fP4tf--1dS0biCFlB0saz0I0kjO5v7-GLPtvShAo4cc&r=9PLdMPCoy-UxqQeL_7fkXjdHjEO-awBtN4-Wr8MqKGE&m=2l5lFgQQSW0TkuSAqwJFsCh5v4C7nO5GbLRK7EIm8aM&s=WyUTcwEM_cMdazwM_4rvcVRjxGv0I0v9-bycTlczvwo&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AB32XCV3PFW4W4GX3JTEAHTR6EODFANCNFSM4PMTFPJQ&d=DwMCaQ&c=fP4tf--1dS0biCFlB0saz0I0kjO5v7-GLPtvShAo4cc&r=9PLdMPCoy-UxqQeL_7fkXjdHjEO-awBtN4-Wr8MqKGE&m=2l5lFgQQSW0TkuSAqwJFsCh5v4C7nO5GbLRK7EIm8aM&s=8bEd1GgvE7-ajU9wh5Bhdn5BC5qW2aPtI54zZLfmGoQ&e=>.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton merged pull request #1483: Fix a few issues found by clang-check
Posted by GitBox <gi...@apache.org>.
btashton merged pull request #1483:
URL: https://github.com/apache/incubator-nuttx/pull/1483
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org