[GitHub] [arrow-datafusion] korowa opened a new issue, #2619: Move `JOIN ON` predicates push down logic from planner to optimizer

[GitBox <gi...@apache.org>]

korowa opened a new issue, #2619:
URL: https://github.com/apache/arrow-datafusion/issues/2619

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   At this moment pushdown logic for `JOIN ON` predicates is provided by logical planner. The idea is to move it to filter_push_down optimizer rule and unify join planning logic. 
   
   **Describe the solution you'd like**
   Logical planner should not parse predicates in ON clause (except for join keys) - it should simply put them into `Join.filter` field. filter_push_down should be able to move `JOIN ON` predicates (or its parts) as filters over join inputs. After that we could enable ignored tests in filter_push_down.rs related to join filters push down logic.
   
   **Describe alternatives you've considered**
   A clear and concise description of any alternative solutions or features you've considered.
   
   **Additional context**
   [PR discussion comment on changing planner logic](https://github.com/apache/arrow-datafusion/pull/2591#discussion_r880864504)
   
   [PR discussion comment on filter pushdown optimizer](https://github.com/apache/arrow-datafusion/pull/2591#discussion_r880841593)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on issue #2619: Move `JOIN ON` predicates push down logic from planner to optimizer

[GitBox <gi...@apache.org>]

alamb commented on issue #2619:
URL: https://github.com/apache/arrow-datafusion/issues/2619#issuecomment-1137801439

   Another benefit of pushing on predicates in the optimizer is that then the optimization will be done for `DataFrame` plans as well as SQL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb closed issue #2619: Move `JOIN ON` predicates push down logic from planner to optimizer

[GitBox <gi...@apache.org>]

alamb closed issue #2619: Move `JOIN ON` predicates push down logic from planner to optimizer
URL: https://github.com/apache/arrow-datafusion/issues/2619


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org