You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/28 08:36:29 UTC
[GitHub] [superset] sadpandajoe opened a new pull request, #18606: chore: upgrading cypress to version 9
sadpandajoe opened a new pull request, #18606:
URL: https://github.com/apache/superset/pull/18606
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Upgrading cypress to the latest version following their (migration guide)[https://docs.cypress.io/guides/references/migration-guide#Migrating-from-cypress-file-upload-to-selectFile].
- Bumping version to 9
- Removing flag `--headless` as it's default with Cypress 8
- No other test updates are required as part of the migration
Here is the [change log](https://cypress.io/whats-new/) of all the changes made.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
- Run all tests to ensure they are passing
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sadpandajoe commented on pull request #18606: chore: upgrading cypress to version 9
Posted by GitBox <gi...@apache.org>.
sadpandajoe commented on PR #18606:
URL: https://github.com/apache/superset/pull/18606#issuecomment-1225912966
closing for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sadpandajoe commented on pull request #18606: chore: upgrading cypress to version 9
Posted by GitBox <gi...@apache.org>.
sadpandajoe commented on PR #18606:
URL: https://github.com/apache/superset/pull/18606#issuecomment-1115067882
@zhaoyongjie this was added by @stephenLYZ in this PR: https://github.com/apache/superset/pull/19828/files. I want to confirm that it's ok with them before editing that file as I don't want to break other things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sadpandajoe commented on pull request #18606: chore: upgrading cypress to version 9
Posted by GitBox <gi...@apache.org>.
sadpandajoe commented on PR #18606:
URL: https://github.com/apache/superset/pull/18606#issuecomment-1113849651
@zhaoyongjie done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #18606: chore: upgrading cypress to version 9
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on PR #18606:
URL: https://github.com/apache/superset/pull/18606#issuecomment-1113890135
@sadpandajoe, thanks!
The CI is brocked by an npm compatible error. I think we just need to remove the `engines` declaration to fix it.
```
diff --git a/superset-frontend/tools/eslint-plugin-translation-vars/package.json b/superset-frontend/tools/eslint-plugin-translation-vars/package.json
index d4353a88d..83e8c184d 100644
--- a/superset-frontend/tools/eslint-plugin-translation-vars/package.json
+++ b/superset-frontend/tools/eslint-plugin-translation-vars/package.json
@@ -12,9 +12,5 @@
"dependencies": {},
"peerDependencies": {
"eslint": ">=0.8.0"
- },
- "engines": {
- "node": "^16.9.1",
- "npm": "^7.5.4"
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #18606: chore: upgrading cypress to version 9
Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #18606:
URL: https://github.com/apache/superset/pull/18606#issuecomment-1382681282
@sadpandajoe looks like you intended to close this. I'll do ya the favor, but please feel free to reopen if warranted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas closed pull request #18606: chore: upgrading cypress to version 9
Posted by GitBox <gi...@apache.org>.
rusackas closed pull request #18606: chore: upgrading cypress to version 9
URL: https://github.com/apache/superset/pull/18606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #18606: chore: upgrading cypress to version 9
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on PR #18606:
URL: https://github.com/apache/superset/pull/18606#issuecomment-1115519994
@stephenLYZ Could you confirm that this modification is safe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie closed pull request #18606: chore: upgrading cypress to version 9
Posted by GitBox <gi...@apache.org>.
zhaoyongjie closed pull request #18606: chore: upgrading cypress to version 9
URL: https://github.com/apache/superset/pull/18606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #18606: chore: upgrading cypress to version 9
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on PR #18606:
URL: https://github.com/apache/superset/pull/18606#issuecomment-1111925353
@sadpandajoe Could you rebase the latest master to your branch? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org