You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@spamassassin.apache.org on 2022/12/06 08:26:28 UTC
[Bug 8084] New: t/perlcritic.t test fails with InputOutput::ProhibitBarewordDirHandles
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8084
Bug ID: 8084
Summary: t/perlcritic.t test fails with
InputOutput::ProhibitBarewordDirHandles
Product: Spamassassin
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P2
Component: Regression Tests
Assignee: dev@spamassassin.apache.org
Reporter: sidney@sidney.com
Target Milestone: Undefined
Perl::Critic version 1.142, released last month, introduced a new policy
InputOutput::ProhibitBarewordDirHandles that causes test t/perlcritic.pl to
fail due to several places in the code that use a bare word file handle for a
directory, for example in ArchiveIterator.pm 'opendir(DIR, $folder)'
Similar to what we did for bug 8002 we can add
InputOutput::ProhibitBarewordDirHandles to the exclude list in t/perlcritic.pl
to suppress the error. If we decide to fix the code to not use bare words for
dir handles, we can then remove the exclusion.
As this is a change to a test with no code change, it can be committed for the
4.0.0 release without an R-T-C vote.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8084] t/perlcritic.t test fails with InputOutput::ProhibitBarewordDirHandles
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8084
Sidney Markowitz <si...@sidney.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sidney@sidney.com
Target Milestone|Undefined |4.0.0
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #1 from Sidney Markowitz <si...@sidney.com> ---
trunk % svn ci -m "Bug 8084 - exclude new perlcritic policy for bareword dir
handles" t/perlcritic.pl
Sending t/perlcritic.pl
Transmitting file data .done
Committing transaction...
Committed revision 1905787.
--
You are receiving this mail because:
You are the assignee for the bug.