You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Xiao Feng Yu (JIRA)" <ji...@apache.org> on 2012/05/10 11:15:14 UTC
[jira] [Created] (SHINDIG-1773) Add SSO support for Shindig proxy
request
Xiao Feng Yu created SHINDIG-1773:
-------------------------------------
Summary: Add SSO support for Shindig proxy request
Key: SHINDIG-1773
URL: https://issues.apache.org/jira/browse/SHINDIG-1773
Project: Shindig
Issue Type: New Feature
Components: Java
Affects Versions: 2.5.0, 3.0.0
Reporter: Xiao Feng Yu
Fix For: 2.5.0, 3.0.0
In enterprise environment, cookie based SSO is commonly used to access the protected resource, while Shindig only support OAuth and OAuth2 to access the web resources. It is desired to add a new auth type as "SSO", so that in makeRequest call, if the SSO auth type is specified, the SSO cookie will be forwarded to the resource server.
And in getProxyUrl API, auth type can also be specified to create a proxy url with either SSO or OAuth support enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1773) Content proxy needs to support
proxy for OAuth protected resources
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274693#comment-13274693 ]
jiraposter@reviews.apache.org commented on SHINDIG-1773:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5112/
-----------------------------------------------------------
Review request for Ryan Baxter, Dan Dumont, Stanton Sievers, and Brian Lillie.
Summary
-------
Couple of changes are included in this patch.
1) On the client side, the getProxyUrl is updated to add auth parameter to specify the auth scheme used, also check for the AUTHORIZATION and OAUTH_SERVICE setting and add them in proxy url.
2) On the server side, proxy servlet will pass additional HttpServletRequest to ProxyHandler to build the HttpRequest object, in the ProxyHandler additional information as security token, auth type, oauth service and gadget will be used to construct a HttpRequest to pass to the DefaultRequestPipeline for handling.
This addresses bug Shindig-1773.
https://issues.apache.org/jira/browse/Shindig-1773
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1338171
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1338232
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java 1338123
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java 1335359
http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/WEB-INF/web.xml 1335359
Diff: https://reviews.apache.org/r/5112/diff
Testing
-------
Thanks,
Xiao Feng
> Content proxy needs to support proxy for OAuth protected resources
> ------------------------------------------------------------------
>
> Key: SHINDIG-1773
> URL: https://issues.apache.org/jira/browse/SHINDIG-1773
> Project: Shindig
> Issue Type: New Feature
> Components: Java
> Affects Versions: 2.5.0, 3.0.0
> Reporter: Xiao Feng Yu
> Fix For: 2.5.0, 3.0.0
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There are many cases that some resource are protected by OAuth and they are desired to be accessed via content proxy instead of makeRequest calls, for example, images in user's album. User should be able to specify OAuth parameter in getProxyUrl call and get a proxy url to access the protected resources.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1773) Content proxy needs to support
proxy for OAuth protected resources
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277498#comment-13277498 ]
jiraposter@reviews.apache.org commented on SHINDIG-1773:
--------------------------------------------------------
bq. On 2012-05-15 21:46:05, Ryan Baxter wrote:
bq. > Since this functionality is not in the spec, would it be possible to create a sample gadget as an example of how to use this functionality?
bq.
bq. Dan Dumont wrote:
bq. I would also like to see a test gadget accompany this change.
Hi reviewers, it may take some time to build the sample gadget, I've tried Picasa API, but the access to the photos with the link in ATOM feed doesn't need an access token, if you have any idea on the sample gadget, please let me know.
The unit tests and format are all clean in the latest submission, maybe we can start review on the code and defer the sample gadget as the use of the new function is also in JS unit test case.
- Xiao Feng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5112/#review7913
-----------------------------------------------------------
On 2012-05-15 12:04:39, Xiao Feng Yu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5112/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-15 12:04:39)
bq.
bq.
bq. Review request for Ryan Baxter, Dan Dumont, Stanton Sievers, and Brian Lillie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Couple of changes are included in this patch.
bq. 1) On the client side, the getProxyUrl is updated to add auth parameter to specify the auth scheme used, also check for the AUTHORIZATION and OAUTH_SERVICE setting and add them in proxy url.
bq. 2) On the server side, proxy servlet will pass additional HttpServletRequest to ProxyHandler to build the HttpRequest object, in the ProxyHandler additional information as security token, auth type, oauth service and gadget will be used to construct a HttpRequest to pass to the DefaultRequestPipeline for handling.
bq.
bq.
bq. This addresses bug Shindig-1773.
bq. https://issues.apache.org/jira/browse/Shindig-1773
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1338565
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1338565
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1338595
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java 1338565
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java 1338565
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyServletTest.java 1338565
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/WEB-INF/web.xml 1338565
bq.
bq. Diff: https://reviews.apache.org/r/5112/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Xiao Feng
bq.
bq.
> Content proxy needs to support proxy for OAuth protected resources
> ------------------------------------------------------------------
>
> Key: SHINDIG-1773
> URL: https://issues.apache.org/jira/browse/SHINDIG-1773
> Project: Shindig
> Issue Type: New Feature
> Components: Java
> Affects Versions: 2.5.0, 3.0.0
> Reporter: Xiao Feng Yu
> Fix For: 2.5.0, 3.0.0
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There are many cases that some resource are protected by OAuth and they are desired to be accessed via content proxy instead of makeRequest calls, for example, images in user's album. User should be able to specify OAuth parameter in getProxyUrl call and get a proxy url to access the protected resources.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1773) Content proxy needs to support
proxy for OAuth protected resources
Posted by "Rich Thompson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276299#comment-13276299 ]
Rich Thompson commented on SHINDIG-1773:
----------------------------------------
I agree that a sample gadget using this functionality would be helpful, but I think the lead in statement for why is too strong. My read of section 12 of the gadget spec (e.g. http://opensocial-resources.googlecode.com/svn/spec/2.0.1/Core-Gadget.xml#OAuth) requires more OAuth support than the rest of the specs explicitly call out. Specifically:
"As mentioned previously in this specification and other OpenSocial 2.0 specifications, OpenSocial containers MUST be able to proxy OAuth requests for gadgets. The main mechanism used to accomplish proxy requests is the gadgets.io.makeRequest (Section 13.2.1.3) method."
While makeRequest is expected to be the main mechanism (and certainly is the focus throughout the specs), but the MUST statement relative to support is much broader and certainly applies to the use case driving this JIRA; namely, supporting accessing protected resources through the content proxy.
> Content proxy needs to support proxy for OAuth protected resources
> ------------------------------------------------------------------
>
> Key: SHINDIG-1773
> URL: https://issues.apache.org/jira/browse/SHINDIG-1773
> Project: Shindig
> Issue Type: New Feature
> Components: Java
> Affects Versions: 2.5.0, 3.0.0
> Reporter: Xiao Feng Yu
> Fix For: 2.5.0, 3.0.0
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There are many cases that some resource are protected by OAuth and they are desired to be accessed via content proxy instead of makeRequest calls, for example, images in user's album. User should be able to specify OAuth parameter in getProxyUrl call and get a proxy url to access the protected resources.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1773) Content proxy needs to support
proxy for OAuth protected resources
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13275782#comment-13275782 ]
jiraposter@reviews.apache.org commented on SHINDIG-1773:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5112/
-----------------------------------------------------------
(Updated 2012-05-15 12:04:39.044381)
Review request for Ryan Baxter, Dan Dumont, Stanton Sievers, and Brian Lillie.
Changes
-------
remove heading whitespaces
Summary
-------
Couple of changes are included in this patch.
1) On the client side, the getProxyUrl is updated to add auth parameter to specify the auth scheme used, also check for the AUTHORIZATION and OAUTH_SERVICE setting and add them in proxy url.
2) On the server side, proxy servlet will pass additional HttpServletRequest to ProxyHandler to build the HttpRequest object, in the ProxyHandler additional information as security token, auth type, oauth service and gadget will be used to construct a HttpRequest to pass to the DefaultRequestPipeline for handling.
This addresses bug Shindig-1773.
https://issues.apache.org/jira/browse/Shindig-1773
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1338565
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1338565
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1338595
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java 1338565
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java 1338565
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyServletTest.java 1338565
http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/WEB-INF/web.xml 1338565
Diff: https://reviews.apache.org/r/5112/diff
Testing
-------
Thanks,
Xiao Feng
> Content proxy needs to support proxy for OAuth protected resources
> ------------------------------------------------------------------
>
> Key: SHINDIG-1773
> URL: https://issues.apache.org/jira/browse/SHINDIG-1773
> Project: Shindig
> Issue Type: New Feature
> Components: Java
> Affects Versions: 2.5.0, 3.0.0
> Reporter: Xiao Feng Yu
> Fix For: 2.5.0, 3.0.0
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There are many cases that some resource are protected by OAuth and they are desired to be accessed via content proxy instead of makeRequest calls, for example, images in user's album. User should be able to specify OAuth parameter in getProxyUrl call and get a proxy url to access the protected resources.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1773) Content proxy needs to support
proxy for OAuth protected resources
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277772#comment-13277772 ]
jiraposter@reviews.apache.org commented on SHINDIG-1773:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5112/#review7956
-----------------------------------------------------------
Instead of passing the request along into ProxyHandler, I think the normal flow is to ensure the information you need is in the ProxyUri that gets passed along. For instance, org.apache.shindig.gadgets.uri.ProxyUriBase.setFromUri(Uri) sets things like rewrite MIME, the gadget, and the container for the proxy uri today. The intent would be that ProxyServlet.processRequest() creates the ProxyUri via the ProxyUriManager and then that Uri would be used in ProxyHandler to do the type of checking you want, instead of having to pass the request along.
Also see org.apache.shindig.gadgets.uri.UriCommon.Param for the other params that are defined for Uris.
- Stanton
On 2012-05-15 12:04:39, Xiao Feng Yu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5112/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-15 12:04:39)
bq.
bq.
bq. Review request for Ryan Baxter, Dan Dumont, Stanton Sievers, and Brian Lillie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Couple of changes are included in this patch.
bq. 1) On the client side, the getProxyUrl is updated to add auth parameter to specify the auth scheme used, also check for the AUTHORIZATION and OAUTH_SERVICE setting and add them in proxy url.
bq. 2) On the server side, proxy servlet will pass additional HttpServletRequest to ProxyHandler to build the HttpRequest object, in the ProxyHandler additional information as security token, auth type, oauth service and gadget will be used to construct a HttpRequest to pass to the DefaultRequestPipeline for handling.
bq.
bq.
bq. This addresses bug Shindig-1773.
bq. https://issues.apache.org/jira/browse/Shindig-1773
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1338565
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1338565
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1338595
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java 1338565
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java 1338565
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyServletTest.java 1338565
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/WEB-INF/web.xml 1338565
bq.
bq. Diff: https://reviews.apache.org/r/5112/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Xiao Feng
bq.
bq.
> Content proxy needs to support proxy for OAuth protected resources
> ------------------------------------------------------------------
>
> Key: SHINDIG-1773
> URL: https://issues.apache.org/jira/browse/SHINDIG-1773
> Project: Shindig
> Issue Type: New Feature
> Components: Java
> Affects Versions: 2.5.0, 3.0.0
> Reporter: Xiao Feng Yu
> Fix For: 2.5.0, 3.0.0
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There are many cases that some resource are protected by OAuth and they are desired to be accessed via content proxy instead of makeRequest calls, for example, images in user's album. User should be able to specify OAuth parameter in getProxyUrl call and get a proxy url to access the protected resources.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1773) Content proxy needs to support
proxy for OAuth protected resources
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276718#comment-13276718 ]
jiraposter@reviews.apache.org commented on SHINDIG-1773:
--------------------------------------------------------
bq. On 2012-05-15 21:46:05, Ryan Baxter wrote:
bq. > Since this functionality is not in the spec, would it be possible to create a sample gadget as an example of how to use this functionality?
I would also like to see a test gadget accompany this change.
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5112/#review7913
-----------------------------------------------------------
On 2012-05-15 12:04:39, Xiao Feng Yu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5112/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-15 12:04:39)
bq.
bq.
bq. Review request for Ryan Baxter, Dan Dumont, Stanton Sievers, and Brian Lillie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Couple of changes are included in this patch.
bq. 1) On the client side, the getProxyUrl is updated to add auth parameter to specify the auth scheme used, also check for the AUTHORIZATION and OAUTH_SERVICE setting and add them in proxy url.
bq. 2) On the server side, proxy servlet will pass additional HttpServletRequest to ProxyHandler to build the HttpRequest object, in the ProxyHandler additional information as security token, auth type, oauth service and gadget will be used to construct a HttpRequest to pass to the DefaultRequestPipeline for handling.
bq.
bq.
bq. This addresses bug Shindig-1773.
bq. https://issues.apache.org/jira/browse/Shindig-1773
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1338565
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1338565
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1338595
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java 1338565
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java 1338565
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyServletTest.java 1338565
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/WEB-INF/web.xml 1338565
bq.
bq. Diff: https://reviews.apache.org/r/5112/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Xiao Feng
bq.
bq.
> Content proxy needs to support proxy for OAuth protected resources
> ------------------------------------------------------------------
>
> Key: SHINDIG-1773
> URL: https://issues.apache.org/jira/browse/SHINDIG-1773
> Project: Shindig
> Issue Type: New Feature
> Components: Java
> Affects Versions: 2.5.0, 3.0.0
> Reporter: Xiao Feng Yu
> Fix For: 2.5.0, 3.0.0
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There are many cases that some resource are protected by OAuth and they are desired to be accessed via content proxy instead of makeRequest calls, for example, images in user's album. User should be able to specify OAuth parameter in getProxyUrl call and get a proxy url to access the protected resources.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1773) Content proxy needs to support
proxy for OAuth protected resources
Posted by "Ryan Baxter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Baxter updated SHINDIG-1773:
---------------------------------
Fix Version/s: (was: 2.5.0)
(was: 3.0.0)
2.5.0-beta2
> Content proxy needs to support proxy for OAuth protected resources
> ------------------------------------------------------------------
>
> Key: SHINDIG-1773
> URL: https://issues.apache.org/jira/browse/SHINDIG-1773
> Project: Shindig
> Issue Type: New Feature
> Components: Java
> Affects Versions: 2.5.0, 3.0.0
> Reporter: Xiao Feng Yu
> Fix For: 2.5.0-beta2
>
> Attachments: Jira1773_sample.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There are many cases that some resource are protected by OAuth and they are desired to be accessed via content proxy instead of makeRequest calls, for example, images in user's album. User should be able to specify OAuth parameter in getProxyUrl call and get a proxy url to access the protected resources.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1773) Content proxy needs to support
proxy for OAuth protected resources
Posted by "Xiao Feng Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xiao Feng Yu updated SHINDIG-1773:
----------------------------------
Attachment: Jira1773.patch
> Content proxy needs to support proxy for OAuth protected resources
> ------------------------------------------------------------------
>
> Key: SHINDIG-1773
> URL: https://issues.apache.org/jira/browse/SHINDIG-1773
> Project: Shindig
> Issue Type: New Feature
> Components: Java
> Affects Versions: 2.5.0, 3.0.0
> Reporter: Xiao Feng Yu
> Fix For: 2.5.0, 3.0.0
>
> Attachments: Jira1773.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There are many cases that some resource are protected by OAuth and they are desired to be accessed via content proxy instead of makeRequest calls, for example, images in user's album. User should be able to specify OAuth parameter in getProxyUrl call and get a proxy url to access the protected resources.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1773) Content proxy needs to support
proxy for OAuth protected resources
Posted by "Xiao Feng Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xiao Feng Yu updated SHINDIG-1773:
----------------------------------
Description: There are many cases that some resource are protected by OAuth and they are desired to be accessed via content proxy instead of makeRequest calls, for example, images in user's album. User should be able to specify OAuth parameter in getProxyUrl call and get a proxy url to access the protected resources. (was: In enterprise environment, cookie based SSO is commonly used to access the protected resource, while Shindig only support OAuth and OAuth2 to access the web resources. It is desired to add a new auth type as "SSO", so that in makeRequest call, if the SSO auth type is specified, the SSO cookie will be forwarded to the resource server.
And in getProxyUrl API, auth type can also be specified to create a proxy url with either SSO or OAuth support enabled. )
Summary: Content proxy needs to support proxy for OAuth protected resources (was: Add SSO support for Shindig proxy request)
> Content proxy needs to support proxy for OAuth protected resources
> ------------------------------------------------------------------
>
> Key: SHINDIG-1773
> URL: https://issues.apache.org/jira/browse/SHINDIG-1773
> Project: Shindig
> Issue Type: New Feature
> Components: Java
> Affects Versions: 2.5.0, 3.0.0
> Reporter: Xiao Feng Yu
> Fix For: 2.5.0, 3.0.0
>
>
> There are many cases that some resource are protected by OAuth and they are desired to be accessed via content proxy instead of makeRequest calls, for example, images in user's album. User should be able to specify OAuth parameter in getProxyUrl call and get a proxy url to access the protected resources.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1773) Content proxy needs to support
proxy for OAuth protected resources
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274726#comment-13274726 ]
jiraposter@reviews.apache.org commented on SHINDIG-1773:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5112/#review7844
-----------------------------------------------------------
Initial pass looks OK for the most part. A sample gadget that makes use of these new APIs would be very helpful in demonstrating the concept.
http://svn.apache.org/repos/asf/shindig/trunk/config/container.js
<https://reviews.apache.org/r/5112/#comment17177>
It looks like there is an extra "%" here between url and authz.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js
<https://reviews.apache.org/r/5112/#comment17178>
Use the "st" var here since you defined it above.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js
<https://reviews.apache.org/r/5112/#comment17179>
Use the "st" var here since you defined it above.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
<https://reviews.apache.org/r/5112/#comment17173>
It appears that request could be null here.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
<https://reviews.apache.org/r/5112/#comment17174>
small nit on trailing whitespace
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
<https://reviews.apache.org/r/5112/#comment17175>
small nit on whitespace
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
<https://reviews.apache.org/r/5112/#comment17176>
The formatting seems weird here. Can you make sure you are using 2 spaces instead of tabs and 4 spaces for line continuations per the Shindig style guidelines?
- Stanton
On 2012-05-14 15:53:08, Xiao Feng Yu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5112/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-14 15:53:08)
bq.
bq.
bq. Review request for Ryan Baxter, Dan Dumont, Stanton Sievers, and Brian Lillie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Couple of changes are included in this patch.
bq. 1) On the client side, the getProxyUrl is updated to add auth parameter to specify the auth scheme used, also check for the AUTHORIZATION and OAUTH_SERVICE setting and add them in proxy url.
bq. 2) On the server side, proxy servlet will pass additional HttpServletRequest to ProxyHandler to build the HttpRequest object, in the ProxyHandler additional information as security token, auth type, oauth service and gadget will be used to construct a HttpRequest to pass to the DefaultRequestPipeline for handling.
bq.
bq.
bq. This addresses bug Shindig-1773.
bq. https://issues.apache.org/jira/browse/Shindig-1773
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1338171
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1338232
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java 1338123
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java 1335359
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/WEB-INF/web.xml 1335359
bq.
bq. Diff: https://reviews.apache.org/r/5112/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Xiao Feng
bq.
bq.
> Content proxy needs to support proxy for OAuth protected resources
> ------------------------------------------------------------------
>
> Key: SHINDIG-1773
> URL: https://issues.apache.org/jira/browse/SHINDIG-1773
> Project: Shindig
> Issue Type: New Feature
> Components: Java
> Affects Versions: 2.5.0, 3.0.0
> Reporter: Xiao Feng Yu
> Fix For: 2.5.0, 3.0.0
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There are many cases that some resource are protected by OAuth and they are desired to be accessed via content proxy instead of makeRequest calls, for example, images in user's album. User should be able to specify OAuth parameter in getProxyUrl call and get a proxy url to access the protected resources.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1773) Content proxy needs to support
proxy for OAuth protected resources
Posted by "Xiao Feng Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xiao Feng Yu updated SHINDIG-1773:
----------------------------------
Remaining Estimate: 48h
Original Estimate: 48h
> Content proxy needs to support proxy for OAuth protected resources
> ------------------------------------------------------------------
>
> Key: SHINDIG-1773
> URL: https://issues.apache.org/jira/browse/SHINDIG-1773
> Project: Shindig
> Issue Type: New Feature
> Components: Java
> Affects Versions: 2.5.0, 3.0.0
> Reporter: Xiao Feng Yu
> Fix For: 2.5.0, 3.0.0
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There are many cases that some resource are protected by OAuth and they are desired to be accessed via content proxy instead of makeRequest calls, for example, images in user's album. User should be able to specify OAuth parameter in getProxyUrl call and get a proxy url to access the protected resources.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1773) Content proxy needs to support
proxy for OAuth protected resources
Posted by "Xiao Feng Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xiao Feng Yu updated SHINDIG-1773:
----------------------------------
Attachment: (was: Jira1773.patch)
> Content proxy needs to support proxy for OAuth protected resources
> ------------------------------------------------------------------
>
> Key: SHINDIG-1773
> URL: https://issues.apache.org/jira/browse/SHINDIG-1773
> Project: Shindig
> Issue Type: New Feature
> Components: Java
> Affects Versions: 2.5.0, 3.0.0
> Reporter: Xiao Feng Yu
> Fix For: 2.5.0, 3.0.0
>
> Attachments: Jira1773_sample.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There are many cases that some resource are protected by OAuth and they are desired to be accessed via content proxy instead of makeRequest calls, for example, images in user's album. User should be able to specify OAuth parameter in getProxyUrl call and get a proxy url to access the protected resources.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1773) Content proxy needs to support
proxy for OAuth protected resources
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276256#comment-13276256 ]
jiraposter@reviews.apache.org commented on SHINDIG-1773:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5112/#review7913
-----------------------------------------------------------
Since this functionality is not in the spec, would it be possible to create a sample gadget as an example of how to use this functionality?
- Ryan
On 2012-05-15 12:04:39, Xiao Feng Yu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5112/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-15 12:04:39)
bq.
bq.
bq. Review request for Ryan Baxter, Dan Dumont, Stanton Sievers, and Brian Lillie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Couple of changes are included in this patch.
bq. 1) On the client side, the getProxyUrl is updated to add auth parameter to specify the auth scheme used, also check for the AUTHORIZATION and OAUTH_SERVICE setting and add them in proxy url.
bq. 2) On the server side, proxy servlet will pass additional HttpServletRequest to ProxyHandler to build the HttpRequest object, in the ProxyHandler additional information as security token, auth type, oauth service and gadget will be used to construct a HttpRequest to pass to the DefaultRequestPipeline for handling.
bq.
bq.
bq. This addresses bug Shindig-1773.
bq. https://issues.apache.org/jira/browse/Shindig-1773
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1338565
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1338565
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1338595
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java 1338565
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java 1338565
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyServletTest.java 1338565
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/WEB-INF/web.xml 1338565
bq.
bq. Diff: https://reviews.apache.org/r/5112/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Xiao Feng
bq.
bq.
> Content proxy needs to support proxy for OAuth protected resources
> ------------------------------------------------------------------
>
> Key: SHINDIG-1773
> URL: https://issues.apache.org/jira/browse/SHINDIG-1773
> Project: Shindig
> Issue Type: New Feature
> Components: Java
> Affects Versions: 2.5.0, 3.0.0
> Reporter: Xiao Feng Yu
> Fix For: 2.5.0, 3.0.0
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There are many cases that some resource are protected by OAuth and they are desired to be accessed via content proxy instead of makeRequest calls, for example, images in user's album. User should be able to specify OAuth parameter in getProxyUrl call and get a proxy url to access the protected resources.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1773) Content proxy needs to support
proxy for OAuth protected resources
Posted by "Xiao Feng Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xiao Feng Yu updated SHINDIG-1773:
----------------------------------
Attachment: Jira1773_sample.patch
> Content proxy needs to support proxy for OAuth protected resources
> ------------------------------------------------------------------
>
> Key: SHINDIG-1773
> URL: https://issues.apache.org/jira/browse/SHINDIG-1773
> Project: Shindig
> Issue Type: New Feature
> Components: Java
> Affects Versions: 2.5.0, 3.0.0
> Reporter: Xiao Feng Yu
> Fix For: 2.5.0, 3.0.0
>
> Attachments: Jira1773_sample.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There are many cases that some resource are protected by OAuth and they are desired to be accessed via content proxy instead of makeRequest calls, for example, images in user's album. User should be able to specify OAuth parameter in getProxyUrl call and get a proxy url to access the protected resources.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1773) Content proxy needs to support
proxy for OAuth protected resources
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277798#comment-13277798 ]
jiraposter@reviews.apache.org commented on SHINDIG-1773:
--------------------------------------------------------
bq. On 2012-05-15 21:46:05, Ryan Baxter wrote:
bq. > Since this functionality is not in the spec, would it be possible to create a sample gadget as an example of how to use this functionality?
bq.
bq. Dan Dumont wrote:
bq. I would also like to see a test gadget accompany this change.
bq.
bq. Xiao Feng Yu wrote:
bq. Hi reviewers, it may take some time to build the sample gadget, I've tried Picasa API, but the access to the photos with the link in ATOM feed doesn't need an access token, if you have any idea on the sample gadget, please let me know.
bq. The unit tests and format are all clean in the latest submission, maybe we can start review on the code and defer the sample gadget as the use of the new function is also in JS unit test case.
I think an example is critical and usually required for these kind of changes. I took a brief look as well and could not find a service that had protected images (not that it has to be just images). One idea I had was to use the the OAuth provider in Shindig. Host a set of resources in a directory on the server configure Shindig / the provider in Shindig so that they are protected and have a sample gadget that fetches them.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5112/#review7913
-----------------------------------------------------------
On 2012-05-15 12:04:39, Xiao Feng Yu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5112/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-15 12:04:39)
bq.
bq.
bq. Review request for Ryan Baxter, Dan Dumont, Stanton Sievers, and Brian Lillie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Couple of changes are included in this patch.
bq. 1) On the client side, the getProxyUrl is updated to add auth parameter to specify the auth scheme used, also check for the AUTHORIZATION and OAUTH_SERVICE setting and add them in proxy url.
bq. 2) On the server side, proxy servlet will pass additional HttpServletRequest to ProxyHandler to build the HttpRequest object, in the ProxyHandler additional information as security token, auth type, oauth service and gadget will be used to construct a HttpRequest to pass to the DefaultRequestPipeline for handling.
bq.
bq.
bq. This addresses bug Shindig-1773.
bq. https://issues.apache.org/jira/browse/Shindig-1773
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1338565
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1338565
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1338595
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java 1338565
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java 1338565
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyServletTest.java 1338565
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/WEB-INF/web.xml 1338565
bq.
bq. Diff: https://reviews.apache.org/r/5112/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Xiao Feng
bq.
bq.
> Content proxy needs to support proxy for OAuth protected resources
> ------------------------------------------------------------------
>
> Key: SHINDIG-1773
> URL: https://issues.apache.org/jira/browse/SHINDIG-1773
> Project: Shindig
> Issue Type: New Feature
> Components: Java
> Affects Versions: 2.5.0, 3.0.0
> Reporter: Xiao Feng Yu
> Fix For: 2.5.0, 3.0.0
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There are many cases that some resource are protected by OAuth and they are desired to be accessed via content proxy instead of makeRequest calls, for example, images in user's album. User should be able to specify OAuth parameter in getProxyUrl call and get a proxy url to access the protected resources.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira