[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2772: HDDS-5872. Do not failover on some RpcExceptions

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #2772:
URL: https://github.com/apache/ozone/pull/2772#discussion_r740330227



##########
File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/ha/OMFailoverProxyProvider.java
##########
@@ -464,6 +469,19 @@ public synchronized boolean shouldFailover(Exception ex) {
           return false;
         }
       }
+    } else if (unwrappedException instanceof RpcException) {
+      // Do not failover for following exceptions
+      if (unwrappedException instanceof RpcNoSuchMethodException ||
+          unwrappedException instanceof RpcNoSuchProtocolException ||
+          unwrappedException instanceof RPC.VersionMismatch) {
+        return false;
+      }
+      if (unwrappedException.getMessage().contains(
+          "RPC response exceeds maximum data length") ||

Review comment:
       Similar change we might need in SCM also, for OM-SCM protocol. Can we create this as a common utility method, so that it can be used in SCM also.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org