svn commit: r1032216 - /tomcat/tc6.0.x/trunk/STATUS.txt

[kk...@apache.org]

Author: kkolinko
Date: Sun Nov  7 06:29:58 2010
New Revision: 1032216

URL: http://svn.apache.org/viewvc?rev=1032216&view=rev
Log:
vote

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1032216&r1=1032215&r2=1032216&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Nov  7 06:29:58 2010
@@ -140,7 +140,21 @@ PATCHES PROPOSED TO BACKPORT:
   http://localhost:8080/examples/jsp/snp;x=y/snoop.jsp
   http://people.apache.org/~markt/patches/2010-10-06-path-param-tc6.patch
   +1: markt
-  -0: kkolinko: see Re:r1005192 thread on dev@
+  +1: kkolinko:
+    with the following trivial changes:
+     - with r1022389
+     - with access logging as done by r1030188
+     - Mark CoyoteAdapter.parseSessionId(..) as @deprecated, because it is no more used
+     - in initial assignment of 'int pathParamEnd' can s/uriBC.getStart()/start/ and s/uriBC.getEnd()/end/
+     - boolean warnedEncoding = false;  I think is useless, because it is set
+       to 'false' in every loop. It'd be OK to move it outside the loop.
+     - Add 'coyoteAdapter.parsePathParam' message to org/apache/catalina/connector/LocalStrings.properties
+
+   kkolinko: The old parseSessionId() method calls "clearRequestedSessionURL(request);"
+     when there is no sessionid in the path. The new code does not do that. Was that
+     call needed? It looks that it was not needed, but I might miss something.
+
+   kkolinko: Discussed in Re:r1005192 thread on dev@
 
 * Improve recycling of processors in Http11NioProtocol
   http://svn.apache.org/viewvc?rev=1022415&view=rev



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org