[GitHub] [tvm] masahi edited a comment on pull request #9851: [Torch] Better support in-place variant of ops (aten::relu_ etc)

[GitBox <gi...@apache.org>]

masahi edited a comment on pull request #9851:
URL: https://github.com/apache/tvm/pull/9851#issuecomment-1006417926


   > This change makes sense to me. On the other hand, would that be a potential correctness issue as we discussed before? Such as copy_.
   
   Yeah, this is a gray area. Disallowing all `_` ops would be too restrictive, since most likely they are benign. I haven't heard or encountered correctness issues arising from those  `_` ops that are already in our converter. It is hard to decide where to draw the line, but as we discussed we don't support `copy_` for now. 
   
   Note that we don't have `aten::copy` op (without `_` underscore), such op doesn't seem to exist in Torch. So there will be no danger of  accidentally converting `aten::copy_`.
   
   I'll add a warning when we encounter `_` ops.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org