You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/30 04:11:02 UTC
[GitHub] [airflow] dstandish opened a new pull request #20576: Rename PodLauncher to PodManager
dstandish opened a new pull request #20576:
URL: https://github.com/apache/airflow/pull/20576
The name PodLauncher may have been appropriate at one time. But currently the PodLauncher class is used for much more than "launching" pods. It's a more comprehensive helper class for creating, monitoring, and otherwise interacting with pods. For this reason PodManager is a more representative name and since we're doing a major release we can take the opportunity to update the name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20576: Rename ``PodLauncher`` to ``PodManager``
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20576:
URL: https://github.com/apache/airflow/pull/20576#issuecomment-1003062854
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] BasPH commented on a change in pull request #20576: Rename PodLauncher to PodManager
Posted by GitBox <gi...@apache.org>.
BasPH commented on a change in pull request #20576:
URL: https://github.com/apache/airflow/pull/20576#discussion_r776644102
##########
File path: airflow/providers/cncf/kubernetes/CHANGELOG.rst
##########
@@ -26,10 +26,11 @@ Breaking changes
~~~~~~~~~~~~~~~~
* ``Simplify KubernetesPodOperator (#19572)``
+* Class ``pod_launcher.PodLauncher`` renamed to ``pod_manager.PodManager``
-.. warning:: Many methods in :class:`~.KubernetesPodOperator` and class:`~.PodLauncher` have been renamed.
- If you have subclassed :class:`~.KubernetesPodOperator` will need to update your subclass to reflect
- the new structure. Additionally ``PodStatus`` enum has been renamed to ``PodPhase``.
+.. warning:: Many methods in :class:`~.KubernetesPodOperator` and class:`~.PodManager` (formerly named ``PodLauncher``)
+ have been renamed. If you have subclassed :class:`~.KubernetesPodOperator` you will need to update your subclass to
+ reflect the new structure. Additionally, class ``PodStatus`` enum has been renamed to ``PodPhase``.
Review comment:
```suggestion
reflect the new structure. Additionally, class ``PodStatus`` has been renamed to ``PodPhase``.
```
##########
File path: airflow/providers/cncf/kubernetes/utils/pod_manager.py
##########
@@ -79,8 +79,11 @@ def container_is_running(pod: V1Pod, container_name: str) -> bool:
return container_status.state.running is not None
-class PodLauncher(LoggingMixin):
- """Launches PODS"""
+class PodManager(LoggingMixin):
+ """
+ Helper class for creating, monitoring and otherwise interacting with kubernetes pods
Review comment:
```suggestion
Helper class for creating, monitoring, and otherwise interacting with Kubernetes pods
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish merged pull request #20576: Rename ``PodLauncher`` to ``PodManager``
Posted by GitBox <gi...@apache.org>.
dstandish merged pull request #20576:
URL: https://github.com/apache/airflow/pull/20576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org