[jira] [Resolved] (HBASE-24743) Reject to add a peer which replicate to itself earlier

["Guanghao Zhang (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-24743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guanghao Zhang resolved HBASE-24743.
------------------------------------
    Fix Version/s: 2.4.0
                   3.0.0-alpha-1
       Resolution: Fixed

Pushed to branch-2+. Thanks all for reviewing.

> Reject to add a peer which replicate to itself earlier
> ------------------------------------------------------
>
>                 Key: HBASE-24743
>                 URL: https://issues.apache.org/jira/browse/HBASE-24743
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Guanghao Zhang
>            Assignee: Guanghao Zhang
>            Priority: Major
>             Fix For: 3.0.0-alpha-1, 2.4.0
>
>
> Now there are one check in ReplicationSource#initialize method
> {code:java}
> // In rare case, zookeeper setting may be messed up. That leads to the incorrect
> // peerClusterId value, which is the same as the source clusterId
> if (clusterId.equals(peerClusterId) && !replicationEndpoint.canReplicateToSameCluster()) {
>   this.terminate("ClusterId " + clusterId + " is replicating to itself: peerClusterId "
>       + peerClusterId + " which is not allowed by ReplicationEndpoint:"
>       + replicationEndpoint.getClass().getName(), null, false);
>   this.manager.removeSource(this);
>   return;
> }
> {code}
> This check should move to AddPeerProcedure's precheck.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)