You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/05/07 22:07:24 UTC

[GitHub] [incubator-nuttx-apps] diegoherranz opened a new pull request #706: examples/hdc1008_demo: fix wrong printf parameter

diegoherranz opened a new pull request #706:
URL: https://github.com/apache/incubator-nuttx-apps/pull/706


   ## Summary
   An extra "%d" that shouldn't be there.
   
   ## Impact
   Only the hdc1008_demo app. Warning removed.
   
   ## Testing
   Tested on custom board and it works the same way, but the warning is gone.
   
   Thanks!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] gustavonihei commented on pull request #706: examples/hdc1008_demo: fix wrong printf parameter

Posted by GitBox <gi...@apache.org>.
gustavonihei commented on pull request #706:
URL: https://github.com/apache/incubator-nuttx-apps/pull/706#issuecomment-834897757


   > Check / check (pull_request) complains:
   > 
   > > Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/examples/hdc1008_demo/hdc1008_main.c:2:1: error:
   > > Path relative to repository other than "nuttx" must begin with the root directory
   > 
   > Looking at other example apps, I'm not sure which is the proper way of doing that?
   > 
   > Thanks.
   
   Just prefix the path with "apps/"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] gustavonihei edited a comment on pull request #706: examples/hdc1008_demo: fix wrong printf parameter

Posted by GitBox <gi...@apache.org>.
gustavonihei edited a comment on pull request #706:
URL: https://github.com/apache/incubator-nuttx-apps/pull/706#issuecomment-834897757


   > Check / check (pull_request) complains:
   > 
   > > Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/examples/hdc1008_demo/hdc1008_main.c:2:1: error:
   > > Path relative to repository other than "nuttx" must begin with the root directory
   > 
   > Looking at other example apps, I'm not sure which is the proper way of doing that?
   > 
   > Thanks.
   
   The relative path in the header file must begin with the "apps/" folder.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] gustavonihei edited a comment on pull request #706: examples/hdc1008_demo: fix wrong printf parameter

Posted by GitBox <gi...@apache.org>.
gustavonihei edited a comment on pull request #706:
URL: https://github.com/apache/incubator-nuttx-apps/pull/706#issuecomment-834897757


   > Check / check (pull_request) complains:
   > 
   > > Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/examples/hdc1008_demo/hdc1008_main.c:2:1: error:
   > > Path relative to repository other than "nuttx" must begin with the root directory
   > 
   > Looking at other example apps, I'm not sure which is the proper way of doing that?
   > 
   > Thanks.
   
   The relative path in the file header must begin with the "apps/" folder.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #706: examples/hdc1008_demo: fix wrong printf parameter

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #706:
URL: https://github.com/apache/incubator-nuttx-apps/pull/706


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] diegoherranz commented on pull request #706: examples/hdc1008_demo: fix wrong printf parameter

Posted by GitBox <gi...@apache.org>.
diegoherranz commented on pull request #706:
URL: https://github.com/apache/incubator-nuttx-apps/pull/706#issuecomment-834817919


   Check / check (pull_request) complains:
   > Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/examples/hdc1008_demo/hdc1008_main.c:2:1: error: 
   Path relative to repository other than "nuttx" must begin with the root directory
   
   Looking at other example apps, I'm not sure which is the proper way of doing that?
   
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] diegoherranz commented on pull request #706: examples/hdc1008_demo: fix wrong printf parameter

Posted by GitBox <gi...@apache.org>.
diegoherranz commented on pull request #706:
URL: https://github.com/apache/incubator-nuttx-apps/pull/706#issuecomment-835180939


   Ah, I see. Done.
   
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org