You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "Zakelly (via GitHub)" <gi...@apache.org> on 2024/03/10 10:40:29 UTC
[I] kvrocks2redis test scripts fail [kvrocks]
Zakelly opened a new issue, #2149:
URL: https://github.com/apache/kvrocks/issues/2149
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/kvrocks/issues) and found no similar issues.
### Version
MacOSX 13.5
unstable commit id: 19d7bad87c0b147c96d94b79c1b1ed1e0d894e38
### Minimal reproduce step
1. Build
2. Start kvrocks via `./build/kvrocks -c kvrocks.conf`
3. Start redis-server
4. Start kvrocks2redis via `./build/kvrocks2redis -c utils/kvrocks2redis/kvrocks2redis.conf`
5. Install dependency:
`pip install git+https://github.com/andymccurdy/redis-py.git@2.10.3`
6. Run test via `cd utils/kvrocks2redis/tests && python3 ./populate-kvrocks.py --password="" --flushdb=true`
### What did you expect to see?
All case passed I guess?
### What did you see instead?
```
FAIL ('set', 'foo', 1):'OK' != True
FAIL ('setex', 'foo_ex', 3600, 1):'OK' != True
******* Some case test fail *******
string
FAIL ('set', 'foo', 2):'OK' != True
FAIL ('set', 'foo2', 2):'OK' != True
FAIL ('setex', 'foo_ex', 7200, 2):'OK' != True
FAIL ('lset', 'lfoo', 0, 'a'):'OK' != 1
EXCP unsupported operand type(s) for |: 'str' and 'bool'
******* Some case test fail *******
string
list
```
### Anything Else?
_No response_
### Are you willing to submit a PR?
- [X] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] kvrocks2redis test scripts fail [kvrocks]
Posted by "Zakelly (via GitHub)" <gi...@apache.org>.
Zakelly commented on issue #2149:
URL: https://github.com/apache/kvrocks/issues/2149#issuecomment-1987180151
I guess the return value `OK` should also be treat as passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] kvrocks2redis test scripts fail [kvrocks]
Posted by "jihuayu (via GitHub)" <gi...@apache.org>.
jihuayu commented on issue #2149:
URL: https://github.com/apache/kvrocks/issues/2149#issuecomment-1987721719
Thank you! @Zakelly
It seems like some commands return value has some wrong.
https://github.com/apache/kvrocks/blob/574d438b9acde7b45b0666564af4450c057aceea/utils/kvrocks2redis/tests/populate-kvrocks.py#L61
It may "OK" not True.
These codes were introduced in #1963.
Is it possible that the issue is due to different versions of Python Redis cleint?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] kvrocks2redis test scripts fail [kvrocks]
Posted by "Zakelly (via GitHub)" <gi...@apache.org>.
Zakelly commented on issue #2149:
URL: https://github.com/apache/kvrocks/issues/2149#issuecomment-1991691826
It seems the README is providing the wrong `redis-py` version. When I changed to 5.0.3, the problem solved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] kvrocks2redis test scripts fail [kvrocks]
Posted by "Zakelly (via GitHub)" <gi...@apache.org>.
Zakelly commented on issue #2149:
URL: https://github.com/apache/kvrocks/issues/2149#issuecomment-1987791577
@jihuayu
My redis-cli and redis-server version are both `7.2.4`, when I run `setex` command in redis-cli, it returns:
```
127.0.0.1:6379> setex foo_ex 7200 2
OK
```
Redis python module version:
```
pip3 show redis
Name: redis
Version: 2.10.3
Summary: Python client for Redis key-value store
Home-page: http://github.com/andymccurdy/redis-py
Author: Andy McCurdy
Author-email: sedrik@gmail.com
License: MIT
Location: /Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages
Requires:
Required-by:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] kvrocks2redis test scripts fail [kvrocks]
Posted by "Zakelly (via GitHub)" <gi...@apache.org>.
Zakelly commented on issue #2149:
URL: https://github.com/apache/kvrocks/issues/2149#issuecomment-1988226660
@jihuayu Yes I'd like to. Please assign to me, Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] kvrocks2redis test scripts fail [kvrocks]
Posted by "jihuayu (via GitHub)" <gi...@apache.org>.
jihuayu commented on issue #2149:
URL: https://github.com/apache/kvrocks/issues/2149#issuecomment-1988199137
@Zakelly
Thank you for discovering this issue. The test for kvrocks2redis has not been run in CI, which may be a hidden bug.
After the fix it, do you want to add this test in our CI? refer: https://github.com/apache/kvrocks/issues/1976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] kvrocks2redis test scripts fail [kvrocks]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun closed issue #2149: kvrocks2redis test scripts fail
URL: https://github.com/apache/kvrocks/issues/2149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org