You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2021/05/29 08:40:47 UTC
[GitHub] [incubator-inlong] gosonzhang opened a new pull request #479: [INLONG-626] Fix broker and topic confiugre implement bugs
gosonzhang opened a new pull request #479:
URL: https://github.com/apache/incubator-inlong/pull/479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] yuanboliu commented on pull request #479: [INLONG-626] Fix broker and topic confiugre implement bugs
Posted by GitBox <gi...@apache.org>.
yuanboliu commented on pull request #479:
URL: https://github.com/apache/incubator-inlong/pull/479#issuecomment-856472095
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] codecov-commenter commented on pull request #479: [INLONG-626] Fix broker and topic confiugre implement bugs
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #479:
URL: https://github.com/apache/incubator-inlong/pull/479#issuecomment-850797257
# [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/479?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#479](https://codecov.io/gh/apache/incubator-inlong/pull/479?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (916ed27) into [TUBEMQ-570](https://codecov.io/gh/apache/incubator-inlong/commit/1c89454111c021ab58dae7629ec346da6be87449?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1c89454) will **decrease** coverage by `0.01%`.
> The diff coverage is `22.22%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-inlong/pull/479/graphs/tree.svg?width=650&height=150&src=pr&token=1EUK92O9K2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-inlong/pull/479?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## TUBEMQ-570 #479 +/- ##
================================================
- Coverage 12.27% 12.25% -0.02%
+ Complexity 948 947 -1
================================================
Files 303 303
Lines 30918 30937 +19
Branches 4966 4976 +10
================================================
- Hits 3794 3792 -2
- Misses 26400 26418 +18
- Partials 724 727 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-inlong/pull/479?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...bemq/server/common/heartbeat/HeartbeatManager.java](https://codecov.io/gh/apache/incubator-inlong/pull/479/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vaGVhcnRiZWF0L0hlYXJ0YmVhdE1hbmFnZXIuamF2YQ==) | `38.38% <0.00%> (ø)` | |
| [...bemq/server/master/metamanage/MetaDataManager.java](https://codecov.io/gh/apache/incubator-inlong/pull/479/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9NZXRhRGF0YU1hbmFnZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ter/nodemanage/nodebroker/BrokerRunStatusInfo.java](https://codecov.io/gh/apache/incubator-inlong/pull/479/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbm9kZW1hbmFnZS9ub2RlYnJva2VyL0Jyb2tlclJ1blN0YXR1c0luZm8uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/master/nodemanage/nodebroker/BrokerSyncData.java](https://codecov.io/gh/apache/incubator-inlong/pull/479/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbm9kZW1hbmFnZS9ub2RlYnJva2VyL0Jyb2tlclN5bmNEYXRhLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ter/nodemanage/nodebroker/DefBrokerRunManager.java](https://codecov.io/gh/apache/incubator-inlong/pull/479/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbm9kZW1hbmFnZS9ub2RlYnJva2VyL0RlZkJyb2tlclJ1bk1hbmFnZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...rver/master/web/handler/WebTopicDeployHandler.java](https://codecov.io/gh/apache/incubator-inlong/pull/479/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvd2ViL2hhbmRsZXIvV2ViVG9waWNEZXBsb3lIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...amanage/metastore/dao/entity/BrokerConfEntity.java](https://codecov.io/gh/apache/incubator-inlong/pull/479/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvZGFvL2VudGl0eS9Ccm9rZXJDb25mRW50aXR5LmphdmE=) | `49.14% <50.00%> (-0.43%)` | :arrow_down: |
| [...age/metastore/dao/entity/ClusterSettingEntity.java](https://codecov.io/gh/apache/incubator-inlong/pull/479/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvZGFvL2VudGl0eS9DbHVzdGVyU2V0dGluZ0VudGl0eS5qYXZh) | `60.86% <50.00%> (-0.55%)` | :arrow_down: |
| [...manage/metastore/dao/entity/TopicDeployEntity.java](https://codecov.io/gh/apache/incubator-inlong/pull/479/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvZGFvL2VudGl0eS9Ub3BpY0RlcGxveUVudGl0eS5qYXZh) | `50.60% <50.00%> (-0.61%)` | :arrow_down: |
| [...er/metamanage/metastore/dao/entity/BaseEntity.java](https://codecov.io/gh/apache/incubator-inlong/pull/479/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvZGFvL2VudGl0eS9CYXNlRW50aXR5LmphdmE=) | `63.44% <87.50%> (+0.77%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/incubator-inlong/pull/479/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/479?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/479?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1c89454...916ed27](https://codecov.io/gh/apache/incubator-inlong/pull/479?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] yuanboliu merged pull request #479: [INLONG-626] Fix broker and topic confiugre implement bugs
Posted by GitBox <gi...@apache.org>.
yuanboliu merged pull request #479:
URL: https://github.com/apache/incubator-inlong/pull/479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] codecov-commenter edited a comment on pull request #479: [INLONG-626] Fix broker and topic confiugre implement bugs
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #479:
URL: https://github.com/apache/incubator-inlong/pull/479#issuecomment-850797257
# [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/479?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#479](https://codecov.io/gh/apache/incubator-inlong/pull/479?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8833afa) into [TUBEMQ-570](https://codecov.io/gh/apache/incubator-inlong/commit/1c89454111c021ab58dae7629ec346da6be87449?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1c89454) will **decrease** coverage by `0.02%`.
> The diff coverage is `8.69%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-inlong/pull/479/graphs/tree.svg?width=650&height=150&src=pr&token=1EUK92O9K2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-inlong/pull/479?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## TUBEMQ-570 #479 +/- ##
================================================
- Coverage 12.27% 12.24% -0.03%
Complexity 948 948
================================================
Files 303 303
Lines 30918 30971 +53
Branches 4966 4991 +25
================================================
- Hits 3794 3793 -1
- Misses 26400 26452 +52
- Partials 724 726 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-inlong/pull/479?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../org/apache/tubemq/corebase/cluster/TopicInfo.java](https://codecov.io/gh/apache/incubator-inlong/pull/479/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1YmVtcS9jb3JlYmFzZS9jbHVzdGVyL1RvcGljSW5mby5qYXZh) | `28.00% <0.00%> (-3.35%)` | :arrow_down: |
| [...bemq/server/common/heartbeat/HeartbeatManager.java](https://codecov.io/gh/apache/incubator-inlong/pull/479/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vaGVhcnRiZWF0L0hlYXJ0YmVhdE1hbmFnZXIuamF2YQ==) | `38.38% <0.00%> (ø)` | |
| [...che/tubemq/server/common/statusdef/StepStatus.java](https://codecov.io/gh/apache/incubator-inlong/pull/479/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vc3RhdHVzZGVmL1N0ZXBTdGF0dXMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...bemq/server/master/metamanage/MetaDataManager.java](https://codecov.io/gh/apache/incubator-inlong/pull/479/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9NZXRhRGF0YU1hbmFnZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...etamanage/metastore/dao/entity/TopicPropGroup.java](https://codecov.io/gh/apache/incubator-inlong/pull/479/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvZGFvL2VudGl0eS9Ub3BpY1Byb3BHcm91cC5qYXZh) | `61.81% <ø> (+1.72%)` | :arrow_up: |
| [...ster/nodemanage/nodebroker/BrokerPSInfoHolder.java](https://codecov.io/gh/apache/incubator-inlong/pull/479/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbm9kZW1hbmFnZS9ub2RlYnJva2VyL0Jyb2tlclBTSW5mb0hvbGRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ter/nodemanage/nodebroker/BrokerRunStatusInfo.java](https://codecov.io/gh/apache/incubator-inlong/pull/479/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbm9kZW1hbmFnZS9ub2RlYnJva2VyL0Jyb2tlclJ1blN0YXR1c0luZm8uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/master/nodemanage/nodebroker/BrokerSyncData.java](https://codecov.io/gh/apache/incubator-inlong/pull/479/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbm9kZW1hbmFnZS9ub2RlYnJva2VyL0Jyb2tlclN5bmNEYXRhLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ter/nodemanage/nodebroker/BrokerTopicInfoView.java](https://codecov.io/gh/apache/incubator-inlong/pull/479/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbm9kZW1hbmFnZS9ub2RlYnJva2VyL0Jyb2tlclRvcGljSW5mb1ZpZXcuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ter/nodemanage/nodebroker/DefBrokerRunManager.java](https://codecov.io/gh/apache/incubator-inlong/pull/479/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbm9kZW1hbmFnZS9ub2RlYnJva2VyL0RlZkJyb2tlclJ1bk1hbmFnZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [8 more](https://codecov.io/gh/apache/incubator-inlong/pull/479/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/479?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/479?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1c89454...8833afa](https://codecov.io/gh/apache/incubator-inlong/pull/479?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org