You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@grails.apache.org by "jamesfredley (via GitHub)" <gi...@apache.org> on 2026/02/28 02:26:12 UTC
[PR] Fix renamed state key and regenerate stale snapshots [grails-forge-ui]
jamesfredley opened a new pull request, #85:
URL: https://github.com/apache/grails-forge-ui/pull/85
## Summary
- Fix incomplete `test` → `reloading` rename in `initializeState.js` from PR #84, which caused `form.reloading` to be `undefined` in the application state
- Regenerate all stale snapshot files to match the corrected state
## Details
PR #84 renamed the `test` concept to `reloading` across the codebase, but missed the state key assignment in `initializeState.js` line 16 (`test:` should have been `reloading:`). This caused:
- `form.reloading` to always be `undefined` (the value was stored under the `test` key instead)
- 8 snapshot failures in `useApplicationForm.test.jsx` (rendered `"undefined"` instead of `""` or the actual value)
- 1 snapshot failure in `useAvailableFeatures.test.jsx` (stale `className="test"` reference)
## Changes
| File | Change |
|------|--------|
| `app/launch/src/state/factories/initializeState.js` | `test:` → `reloading:` on line 16 |
| `useApplicationForm.test.jsx.snap` | Regenerated (8 snapshots updated with correct reloading values) |
| `useAvailableFeatures.test.jsx.snap` | Regenerated (`className="test"` → `className="reloading"`) |
## Testing
All 30 tests pass, 11 snapshots regenerated:
```
Test Suites: 5 passed, 5 total
Tests: 30 passed, 30 total
Snapshots: 11 written, 1 passed, 12 total
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix renamed state key and regenerate stale snapshots [grails-forge-ui]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #85:
URL: https://github.com/apache/grails-forge-ui/pull/85#issuecomment-3976181072
<!-- Bito Reply -->
The PR updates the test snapshot with new default values, swapping 'reloading' and 'servlet' fields. Without the test code or specific diff context, I can't confirm if hard coding defaults here is required—snapshots are typically auto-generated from tests, not manually set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix renamed state key and regenerate stale snapshots [grails-forge-ui]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #85:
URL: https://github.com/apache/grails-forge-ui/pull/85#issuecomment-3979316955
@jamesfredley I pulled your change into https://github.com/apache/grails-forge-ui/pull/86 instead. I'm going to close this and let's merge that one instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix renamed state key and regenerate stale snapshots [grails-forge-ui]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on code in PR #85:
URL: https://github.com/apache/grails-forge-ui/pull/85#discussion_r2866952487
##########
app/launch/src/components/Application/__tests__/__snapshots__/useApplicationForm.test.jsx.snap:
##########
@@ -250,12 +250,12 @@ Array [
<div
className="reloading"
>
-
+ DEVTOOLS
Review Comment:
This has to be hard coded here, this is how we default it.
##########
app/launch/src/components/Application/__tests__/__snapshots__/useApplicationForm.test.jsx.snap:
##########
@@ -250,12 +250,12 @@ Array [
<div
className="reloading"
>
-
+ DEVTOOLS
Review Comment:
This has to be hard coded here, this is how we default it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix renamed state key and regenerate stale snapshots [grails-forge-ui]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty closed pull request #85: Fix renamed state key and regenerate stale snapshots
URL: https://github.com/apache/grails-forge-ui/pull/85
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org