You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/01/07 09:49:25 UTC
[GitHub] [shardingsphere] jingshanglu opened a new pull request #8937: format the result of 'show resources'
jingshanglu opened a new pull request #8937:
URL: https://github.com/apache/shardingsphere/pull/8937
Fixes #8932 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io edited a comment on pull request #8937: format the result of 'show resources'
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #8937:
URL: https://github.com/apache/shardingsphere/pull/8937#issuecomment-756541708
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8937?src=pr&el=h1) Report
> Merging [#8937](https://codecov.io/gh/apache/shardingsphere/pull/8937?src=pr&el=desc) (4e957ca) into [master](https://codecov.io/gh/apache/shardingsphere/commit/48d89044d4289eb3c75ab20fde9a550337142c6a?el=desc) (48d8904) will **decrease** coverage by `0.21%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/8937?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8937 +/- ##
============================================
- Coverage 70.51% 70.29% -0.22%
Complexity 658 658
============================================
Files 1640 1642 +2
Lines 26216 26319 +103
Branches 4553 4571 +18
============================================
+ Hits 18486 18501 +15
- Misses 6491 6578 +87
- Partials 1239 1240 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8937?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...stsql/rql/impl/DataSourcesQueryBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcnFsL2ltcGwvRGF0YVNvdXJjZXNRdWVyeUJhY2tlbmRIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ere/governance/core/config/ConfigCacheManager.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9jb25maWcvQ29uZmlnQ2FjaGVNYW5hZ2VyLmphdmE=) | `33.33% <0.00%> (-48.49%)` | `1.00% <0.00%> (ø%)` | |
| [...te/context/ShardingSQLRewriteContextDecorator.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcmV3cml0ZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcmV3cml0ZS9jb250ZXh0L1NoYXJkaW5nU1FMUmV3cml0ZUNvbnRleHREZWNvcmF0b3IuamF2YQ==) | `83.33% <0.00%> (-16.67%)` | `2.00% <0.00%> (ø%)` | |
| [...ingsphere/governance/core/config/ConfigCenter.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9jb25maWcvQ29uZmlnQ2VudGVyLmphdmE=) | `77.77% <0.00%> (-10.52%)` | `0.00% <0.00%> (ø%)` | |
| [...ce/core/config/listener/SchemaChangedListener.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9jb25maWcvbGlzdGVuZXIvU2NoZW1hQ2hhbmdlZExpc3RlbmVyLmphdmE=) | `84.61% <0.00%> (-8.87%)` | `0.00% <0.00%> (ø%)` | |
| [...che/shardingsphere/sharding/rule/ShardingRule.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9ydWxlL1NoYXJkaW5nUnVsZS5qYXZh) | `71.90% <0.00%> (-3.54%)` | `0.00% <0.00%> (ø%)` | |
| [...l/rdl/impl/DropReplicaQueryRuleBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL2ltcGwvRHJvcFJlcGxpY2FRdWVyeVJ1bGVCYWNrZW5kSGFuZGxlci5qYXZh) | `27.58% <0.00%> (-2.05%)` | `1.00% <0.00%> (ø%)` | |
| [.../schema/generator/CalciteLogicSchemaGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL3NjaGVtYS9nZW5lcmF0b3IvQ2FsY2l0ZUxvZ2ljU2NoZW1hR2VuZXJhdG9yLmphdmE=) | `48.57% <0.00%> (-1.43%)` | `0.00% <0.00%> (ø%)` | |
| [...ql/parser/sql/common/extractor/TableExtractor.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL2V4dHJhY3Rvci9UYWJsZUV4dHJhY3Rvci5qYXZh) | `5.83% <0.00%> (-0.14%)` | `0.00% <0.00%> (ø%)` | |
| [.../infra/optimize/schema/row/CalciteRowExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL3NjaGVtYS9yb3cvQ2FsY2l0ZVJvd0V4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [12 more](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8937?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8937?src=pr&el=footer). Last update [48d8904...4e957ca](https://codecov.io/gh/apache/shardingsphere/pull/8937?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jingshanglu commented on a change in pull request #8937: format the result of 'show resources'
Posted by GitBox <gi...@apache.org>.
jingshanglu commented on a change in pull request #8937:
URL: https://github.com/apache/shardingsphere/pull/8937#discussion_r553942979
##########
File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/distsql/rql/impl/DataSourcesQueryBackendHandler.java
##########
@@ -42,6 +46,8 @@
private Map<String, DataSourceParameter> dataSourceParameterMap;
+ private String schemaName;
Review comment:
ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io edited a comment on pull request #8937: format the result of 'show resources'
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #8937:
URL: https://github.com/apache/shardingsphere/pull/8937#issuecomment-756541708
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8937?src=pr&el=h1) Report
> Merging [#8937](https://codecov.io/gh/apache/shardingsphere/pull/8937?src=pr&el=desc) (f018535) into [master](https://codecov.io/gh/apache/shardingsphere/commit/135e61f24a728bc79a560999a293316b02e9dd42?el=desc) (135e61f) will **increase** coverage by `0.00%`.
> The diff coverage is `7.40%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/8937?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8937 +/- ##
=========================================
Coverage 70.23% 70.24%
Complexity 652 652
=========================================
Files 1634 1633 -1
Lines 26198 26209 +11
Branches 4564 4565 +1
=========================================
+ Hits 18401 18410 +9
- Misses 6553 6556 +3
+ Partials 1244 1243 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8937?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...stsql/rql/impl/DataSourcesQueryBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcnFsL2ltcGwvRGF0YVNvdXJjZXNRdWVyeUJhY2tlbmRIYW5kbGVyLmphdmE=) | `17.64% <7.40%> (+17.64%)` | `0.00 <0.00> (ø)` | |
| [...phere/agent/core/config/path/AgentPathBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcvcGF0aC9BZ2VudFBhdGhCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...ingsphere/agent/bootstrap/ShardingSphereAgent.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9ib290c3RyYXAvU2hhcmRpbmdTcGhlcmVBZ2VudC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...pi/definition/AbstractPluginDefinitionService.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9zcGkvZGVmaW5pdGlvbi9BYnN0cmFjdFBsdWdpbkRlZmluaXRpb25TZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...re/plugin/interceptor/MethodAroundInterceptor.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4vaW50ZXJjZXB0b3IvTWV0aG9kQXJvdW5kSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...ugin/interceptor/ConstructorMethodInterceptor.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4vaW50ZXJjZXB0b3IvQ29uc3RydWN0b3JNZXRob2RJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...gin/interceptor/StaticMethodAroundInterceptor.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4vaW50ZXJjZXB0b3IvU3RhdGljTWV0aG9kQXJvdW5kSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...ing/base/service/BaseLoggingPluginBootService.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtcGx1Z2lucy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1wbHVnaW4tbG9nZ2luZy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1sb2dnaW5nLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L3BsdWdpbi9sb2dnaW5nL2Jhc2Uvc2VydmljZS9CYXNlTG9nZ2luZ1BsdWdpbkJvb3RTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...rometheus/service/PrometheusPluginBootService.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtcGx1Z2lucy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1wbHVnaW4tbWV0cmljcy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L21ldHJpY3MvcHJvbWV0aGV1cy9zZXJ2aWNlL1Byb21ldGhldXNQbHVnaW5Cb290U2VydmljZS5qYXZh) | `83.33% <0.00%> (ø)` | `1.00% <0.00%> (ø%)` | |
| [...jaeger/service/JaegerTracingPluginBootService.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtcGx1Z2lucy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1wbHVnaW4tdHJhY2luZy9zaGFyZGluZ3NwaGVyZS1hZ2VudC10cmFjaW5nLWphZWdlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvcGx1Z2luL3RyYWNpbmcvamFlZ2VyL3NlcnZpY2UvSmFlZ2VyVHJhY2luZ1BsdWdpbkJvb3RTZXJ2aWNlLmphdmE=) | `21.42% <0.00%> (ø)` | `1.00% <0.00%> (ø%)` | |
| ... and [10 more](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8937?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8937?src=pr&el=footer). Last update [135e61f...f018535](https://codecov.io/gh/apache/shardingsphere/pull/8937?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io edited a comment on pull request #8937: format the result of 'show resources'
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #8937:
URL: https://github.com/apache/shardingsphere/pull/8937#issuecomment-756541708
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8937?src=pr&el=h1) Report
> Merging [#8937](https://codecov.io/gh/apache/shardingsphere/pull/8937?src=pr&el=desc) (4e957ca) into [master](https://codecov.io/gh/apache/shardingsphere/commit/48d89044d4289eb3c75ab20fde9a550337142c6a?el=desc) (48d8904) will **decrease** coverage by `0.21%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/8937?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8937 +/- ##
============================================
- Coverage 70.51% 70.29% -0.22%
Complexity 658 658
============================================
Files 1640 1642 +2
Lines 26216 26319 +103
Branches 4553 4571 +18
============================================
+ Hits 18486 18501 +15
- Misses 6491 6578 +87
- Partials 1239 1240 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8937?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...stsql/rql/impl/DataSourcesQueryBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcnFsL2ltcGwvRGF0YVNvdXJjZXNRdWVyeUJhY2tlbmRIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ere/governance/core/config/ConfigCacheManager.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9jb25maWcvQ29uZmlnQ2FjaGVNYW5hZ2VyLmphdmE=) | `33.33% <0.00%> (-48.49%)` | `1.00% <0.00%> (ø%)` | |
| [...te/context/ShardingSQLRewriteContextDecorator.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcmV3cml0ZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcmV3cml0ZS9jb250ZXh0L1NoYXJkaW5nU1FMUmV3cml0ZUNvbnRleHREZWNvcmF0b3IuamF2YQ==) | `83.33% <0.00%> (-16.67%)` | `2.00% <0.00%> (ø%)` | |
| [...ingsphere/governance/core/config/ConfigCenter.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9jb25maWcvQ29uZmlnQ2VudGVyLmphdmE=) | `77.77% <0.00%> (-10.52%)` | `0.00% <0.00%> (ø%)` | |
| [...ce/core/config/listener/SchemaChangedListener.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9jb25maWcvbGlzdGVuZXIvU2NoZW1hQ2hhbmdlZExpc3RlbmVyLmphdmE=) | `84.61% <0.00%> (-8.87%)` | `0.00% <0.00%> (ø%)` | |
| [...che/shardingsphere/sharding/rule/ShardingRule.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9ydWxlL1NoYXJkaW5nUnVsZS5qYXZh) | `71.90% <0.00%> (-3.54%)` | `0.00% <0.00%> (ø%)` | |
| [...l/rdl/impl/DropReplicaQueryRuleBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL2ltcGwvRHJvcFJlcGxpY2FRdWVyeVJ1bGVCYWNrZW5kSGFuZGxlci5qYXZh) | `27.58% <0.00%> (-2.05%)` | `1.00% <0.00%> (ø%)` | |
| [.../schema/generator/CalciteLogicSchemaGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL3NjaGVtYS9nZW5lcmF0b3IvQ2FsY2l0ZUxvZ2ljU2NoZW1hR2VuZXJhdG9yLmphdmE=) | `48.57% <0.00%> (-1.43%)` | `0.00% <0.00%> (ø%)` | |
| [...ql/parser/sql/common/extractor/TableExtractor.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL2V4dHJhY3Rvci9UYWJsZUV4dHJhY3Rvci5qYXZh) | `5.83% <0.00%> (-0.14%)` | `0.00% <0.00%> (ø%)` | |
| [.../infra/optimize/schema/row/CalciteRowExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL3NjaGVtYS9yb3cvQ2FsY2l0ZVJvd0V4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [12 more](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8937?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8937?src=pr&el=footer). Last update [48d8904...4e957ca](https://codecov.io/gh/apache/shardingsphere/pull/8937?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #8937: format the result of 'show resources'
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #8937:
URL: https://github.com/apache/shardingsphere/pull/8937#discussion_r553879165
##########
File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/distsql/rql/impl/DataSourcesQueryBackendHandler.java
##########
@@ -42,6 +46,8 @@
private Map<String, DataSourceParameter> dataSourceParameterMap;
+ private String schemaName;
Review comment:
It is not good a design for use global field which assigned out of the constructor.
Can you consider about improve it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #8937: format the result of 'show resources'
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #8937:
URL: https://github.com/apache/shardingsphere/pull/8937#discussion_r553879165
##########
File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/distsql/rql/impl/DataSourcesQueryBackendHandler.java
##########
@@ -42,6 +46,8 @@
private Map<String, DataSourceParameter> dataSourceParameterMap;
+ private String schemaName;
Review comment:
It is not good a design for use global field which assigned out of the constructor.
Can you consider about improve it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #8937: format the result of 'show resources'
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #8937:
URL: https://github.com/apache/shardingsphere/pull/8937#issuecomment-756541708
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8937?src=pr&el=h1) Report
> Merging [#8937](https://codecov.io/gh/apache/shardingsphere/pull/8937?src=pr&el=desc) (d9b463e) into [master](https://codecov.io/gh/apache/shardingsphere/commit/48d89044d4289eb3c75ab20fde9a550337142c6a?el=desc) (48d8904) will **decrease** coverage by `0.05%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/8937?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8937 +/- ##
============================================
- Coverage 70.51% 70.45% -0.06%
Complexity 658 658
============================================
Files 1640 1640
Lines 26216 26238 +22
Branches 4553 4554 +1
============================================
Hits 18486 18486
- Misses 6491 6513 +22
Partials 1239 1239
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8937?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...stsql/rql/impl/DataSourcesQueryBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8937/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcnFsL2ltcGwvRGF0YVNvdXJjZXNRdWVyeUJhY2tlbmRIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8937?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8937?src=pr&el=footer). Last update [48d8904...d9b463e](https://codecov.io/gh/apache/shardingsphere/pull/8937?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jingshanglu commented on pull request #8937: format the result of 'show resources'
Posted by GitBox <gi...@apache.org>.
jingshanglu commented on pull request #8937:
URL: https://github.com/apache/shardingsphere/pull/8937#issuecomment-757627265
> Is there any unit test?
@tristaZero Maybe Integration testing is required here，Unit testing cannot be effective，i have tested it manually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #8937: format the result of 'show resources'
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #8937:
URL: https://github.com/apache/shardingsphere/pull/8937
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jingshanglu commented on a change in pull request #8937: format the result of 'show resources'
Posted by GitBox <gi...@apache.org>.
jingshanglu commented on a change in pull request #8937:
URL: https://github.com/apache/shardingsphere/pull/8937#discussion_r553942979
##########
File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/distsql/rql/impl/DataSourcesQueryBackendHandler.java
##########
@@ -42,6 +46,8 @@
private Map<String, DataSourceParameter> dataSourceParameterMap;
+ private String schemaName;
Review comment:
ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org