You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/11/19 19:43:11 UTC
[jira] [Commented] (SOLR-3526) Remove classfile dependency on
ZooKeeper from CoreContainer
[ https://issues.apache.org/jira/browse/SOLR-3526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15014121#comment-15014121 ]
ASF GitHub Bot commented on SOLR-3526:
--------------------------------------
GitHub user msfroh opened a pull request:
https://github.com/apache/lucene-solr/pull/211
SOLR-3526: Remove classfile dependency on ZK for core Solr classes
Replace references to o.a.z.KeeperException with a Solr-owned
exception and push uses of o.a.z.data.Stat into ZkController, so that
users of vanilla Solr (not SolrCloud) don't need to have ZooKeeper in
their classpath.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/msfroh/lucene-solr trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/211.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #211
----
commit 1d7c8c4cf8fb86c38a55ad544877a824efddec9f
Author: Michael Froh <fr...@amazon.com>
Date: 2015-11-19T18:05:28Z
SOLR-3526: Remove classfile dependency on ZK for core Solr classes
Replace references to o.a.z.KeeperException with a Solr-owned
exception and push uses of o.a.z.data.Stat into ZkController, so that
users of vanilla Solr (not SolrCloud) don't need to have ZooKeeper in
their classpath.
----
> Remove classfile dependency on ZooKeeper from CoreContainer
> -----------------------------------------------------------
>
> Key: SOLR-3526
> URL: https://issues.apache.org/jira/browse/SOLR-3526
> Project: Solr
> Issue Type: Wish
> Components: SolrCloud
> Affects Versions: 4.0-ALPHA
> Reporter: Michael Froh
>
> We are using Solr as a library embedded within an existing application, and are currently developing toward using 4.0 when it is released.
> We are currently instantiating SolrCores with null CoreDescriptors (and hence no CoreContainer), since we don't need SolrCloud functionality (and do not want to depend on ZooKeeper).
> A couple of months ago, SearchHandler was modified to try to retrieve a ShardHandlerFactory from the CoreContainer. I was able to work around this by specifying a dummy ShardHandlerFactory in the config.
> Now UpdateRequestProcessorChain is inserting a DistributedUpdateProcessor into my chains, again triggering a NPE when trying to dereference the CoreDescriptor.
> I would happily place the SolrCores in CoreContainers, except that CoreContainer imports and references org.apache.zookeeper.KeeperException, which we do not have (and do not want) in our classpath. Therefore, I get a ClassNotFoundException when loading the CoreContainer class.
> Ideally (IMHO), ZkController should isolate the ZooKeeper dependency, and simply rethrow KeeperExceptions as org.apache.solr.common.cloud.ZooKeeperException (or some Solr-hosted checked exception). Then CoreContainer could remove the offending import/references.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org