You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Julian Hyde (Jira)" <ji...@apache.org> on 2019/10/15 22:31:00 UTC

[jira] [Commented] (CALCITE-3403) WindowReduceExpressionsRule does not reuse RelMetadataQuery

    [ https://issues.apache.org/jira/browse/CALCITE-3403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952341#comment-16952341 ] 

Julian Hyde commented on CALCITE-3403:
--------------------------------------

Sorry, I have to grumble about this change.

Most of the changes in this PR are in deprecated methods, and you changed it to call a method that is semi-deprecated ("This method might be changed or moved in future.").

> WindowReduceExpressionsRule does not reuse RelMetadataQuery
> -----------------------------------------------------------
>
>                 Key: CALCITE-3403
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3403
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Haisheng Yuan
>            Assignee: jin xing
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.22.0
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> It creates a new RelMetadataQuery instance, which is a fresh RelMetadataQuery without any data cache. We should get RelMetadataQuery from RelOptRuleCall to reuse cache as much as possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)