You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/03/30 10:31:00 UTC

[jira] [Commented] (PARQUET-1969) Test by GithubAction

    [ https://issues.apache.org/jira/browse/PARQUET-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311378#comment-17311378 ] 

ASF GitHub Bot commented on PARQUET-1969:
-----------------------------------------

pitrou commented on a change in pull request #166:
URL: https://github.com/apache/parquet-format/pull/166#discussion_r603972065



##########
File path: README.md
##########
@@ -17,7 +17,7 @@
   - under the License.
   -->
 
-# Parquet [![Build Status](https://travis-ci.org/apache/parquet-format.png?branch=master)](http://travis-ci.org/apache/parquet-format)
+# Parquet [![Build Status](https://github.com/apache/parquet-format/workflows/Test/badge.svg)](https://github.com/apache/parquet-format/actions)

Review comment:
       I believe the URL should be https://github.com/apache/parquet-format/actions/workflows/test.yml/badge.svg
   
   (see https://github.com/apache/arrow/actions/workflows/cpp.yml/badge.svg for an example on another repo)

##########
File path: .github/workflows/test.yml
##########
@@ -0,0 +1,36 @@
+name: Test
+
+on: [push, pull_request]
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        java: [ '1.8', '11' ]
+    name: Build Parquet with JDK ${{ matrix.java }} and ${{ matrix.codes }}

Review comment:
       `matrix.codes` doesn't seem to point to anything. Just drop it?
   (see formatted labels in https://github.com/gszadovszky/parquet-format/runs/1816450871 )




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Test by GithubAction
> --------------------
>
>                 Key: PARQUET-1969
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1969
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-format, parquet-mr
>    Affects Versions: 1.12.0
>            Reporter: Yuming Wang
>            Assignee: Yuming Wang
>            Priority: Major
>             Fix For: 1.12.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)