You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "Pankaj260100 (via GitHub)" <gi...@apache.org> on 2024/09/24 06:41:45 UTC

[I] Add new metrics for http client (druid)

Pankaj260100 opened a new issue, #17138:
URL: https://github.com/apache/druid/issues/17138

   ### Description
   We can add metrics on the client side to gain the visibility like we have for the Jetty HTTP server.
   
   ### Motivation
   Recently, we experienced high latency issues and struggled to pinpoint the exact bottleneck. After a thorough analysis of the query lifecycle within Druid, we identified that one potential contributor to latency is the time taken by the HTTP client at the broker/router. During this process, threads can be blocked while waiting for a connection to become available.
   
   Currently, we lack visibility into how long requests are waiting for a connection on the client side. By exposing a metric for the time requests spend waiting for a connection on the client side, we can identify whether the connection acquisition time is a significant bottleneck and allow us to take targeted actions to mitigate it.
   
   Additionally, we have observed at the router that log lines indicate it hits the limit of 1024 at the Jetty HTTP client queue. This suggests that the queue size can become a limiting factor, potentially leading to increased latency or dropped requests. We suspect a similar situation could occur at the broker, where the NettyHTTP client might also experience high queue sizes. By adding a metric for the queue size or time spent by request at the broker, we can monitor this aspect and ensure that it does not become a hidden bottleneck.
   
   In summary, adding these metrics on the client side will provide us with critical insights into the connection acquisition process and queue sizes, enabling us to more effectively identify and address latency bottlenecks within Druid. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [I] Add new metrics for http client (druid)

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #17138: Add new metrics for http client
URL: https://github.com/apache/druid/issues/17138


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [I] Add new metrics for http client (druid)

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #17138:
URL: https://github.com/apache/druid/issues/17138#issuecomment-3134487506

   This issue has been closed due to lack of activity. If you think that
   is incorrect, or the issue requires additional review, you can revive the issue at
   any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [I] Add new metrics for http client (druid)

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #17138:
URL: https://github.com/apache/druid/issues/17138#issuecomment-3025912672

   This issue has been marked as stale due to 280 days of inactivity.
   It will be closed in 4 weeks if no further activity occurs. If this issue is still
   relevant, please simply write any comment. Even if closed, you can still revive the
   issue at any time or discuss it on the dev@druid.apache.org list.
   Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org