[GitHub] [hop] pscigala opened a new pull request #1304: HOP-3711 CheckSumMetaTest.testSerialization fails randomly

[GitBox <gi...@apache.org>]

pscigala opened a new pull request #1304:
URL: https://github.com/apache/hop/pull/1304


   Cause:
   During the test the EnumLoadSaveValidator#getTestObject generates random enum value to set checkSumType field in CheckSumMeta object.
   Most of the time seems to draws well matched value to pass the test.
   However the problem occurs when the validator draws CheckSumMeta.CheckSumType#NONE enum, which has 'code' property value defined as an empty string "".
   
   Next the LoadSaveTester#testXmlRoundTrip creates meta with provided checkSumType to save to and then applies transform xml to meta. 
   
   So when checkSumType==NONE has 'code' defined as "" , the generated transform xml looks just like empty <checksumtype/>. Which means no transform at all.
   
   After that in LoadSaveBase#validateLoadedMeta performs validation of loaded data with applied transformations. Because transform was empty the old checksumtype is loaded e.g CRC32. 
   So the transform has no effect at all in this case and the test fails .
   
   Setting code to "NONE" in the enum seems to fix the problem with empty transform and passes validation but im not sure if this is the best solution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hop] hansva merged pull request #1304: HOP-3711 CheckSumMetaTest.testSerialization fails randomly

[GitBox <gi...@apache.org>]

hansva merged pull request #1304:
URL: https://github.com/apache/hop/pull/1304


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org