[GitHub] [spark] c21 edited a comment on pull request #34034: [SPARK-36794][SQL] Ignore duplicated join keys when building relation for SEMI/ANTI hash join

[GitBox <gi...@apache.org>]

c21 edited a comment on pull request #34034:
URL: https://github.com/apache/spark/pull/34034#issuecomment-923146032


   > The idea LGTM. Does it apply to other join types?
   
   @cloud-fan - I think we can apply similar thing to INNER and LEFT/RIGHT OUTER join, as long as the join does not have extra join condition. But for INNER and OUTER join, we need to output every matching rows from build side, so we need some extra data structure to indicate number of rows per unique join key (similar to `BitSet` as we introduced in `ShuffledHashJoinExec.fullOuterJoinWithUniqueKey`). Shall I make the change later in another PR, for INNER and LEFT/RIGHT OUTER join?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org