[GitHub] [skywalking-nginx-lua] kezhenxu94 commented on a diff in pull request #102: introduce infra e2e

[GitBox <gi...@apache.org>]

kezhenxu94 commented on code in PR #102:
URL: https://github.com/apache/skywalking-nginx-lua/pull/102#discussion_r851603447


##########
.github/workflows/e2e.yaml:
##########
@@ -30,15 +30,33 @@ jobs:
     timeout-minutes: 180
     steps:
       - uses: actions/checkout@v2
-      - name: checkout submodules
-        shell: bash
-        run: |
-          git submodule sync --recursive
-          git -c protocol.version=2 submodule update --init --force --recursive --depth=1
+        with:
+          submodules: true
       - uses: actions/setup-java@v1

Review Comment:
   Let's upgrade to v3 and use the maven cache 



##########
.github/workflows/e2e.yaml:
##########
@@ -30,15 +30,33 @@ jobs:
     timeout-minutes: 180
     steps:
       - uses: actions/checkout@v2

Review Comment:
   Let's upgrade to v3 too



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org