You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/06/28 13:36:20 UTC
[GitHub] [ozone] siddhantsangwan commented on a diff in pull request #3562: HDDS-6959. Fix move timeout in latest iteration metric
siddhantsangwan commented on code in PR #3562:
URL: https://github.com/apache/ozone/pull/3562#discussion_r908489943
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerMetrics.java:
##########
@@ -121,6 +122,42 @@ public void incrementNumContainerMovesCompletedInLatestIteration(
this.numContainerMovesCompletedInLatestIteration.incr(valueToAdd);
}
+ public void incrementCurrentIterationContainerMoveMetric(
+ MoveResult result,
+ long valueToAdd) {
+ if (result == null) {
+ return;
+ }
+ switch (result) {
+ case COMPLETED:
+ this.numContainerMovesCompletedInLatestIteration.incr(valueToAdd);
+ break;
+ case REPLICATION_FAIL_TIME_OUT:
+ this.numContainerMovesTimeoutInLatestIteration.incr(valueToAdd);
+ break;
+ // TODO: Add metrics for other errors that need to be tracked.
+ case FAIL_NOT_RUNNING:
+ case REPLICATION_FAIL_INFLIGHT_REPLICATION:
+ case FAIL_NOT_LEADER:
+ case REPLICATION_FAIL_NOT_EXIST_IN_SOURCE:
+ case REPLICATION_FAIL_EXIST_IN_TARGET:
+ case REPLICATION_FAIL_CONTAINER_NOT_CLOSED:
+ case REPLICATION_FAIL_INFLIGHT_DELETION:
+ case REPLICATION_FAIL_NODE_NOT_IN_SERVICE:
+ case DELETION_FAIL_NODE_NOT_IN_SERVICE:
+ case REPLICATION_FAIL_NODE_UNHEALTHY:
+ case DELETION_FAIL_TIME_OUT:
Review Comment:
Timeouts when trying to delete container from source DN should also be added to the `numContainerMovesTimeoutInLatestIteration` metric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org