You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Adam Tamas (Code Review)" <ge...@cloudera.org> on 2020/08/13 13:35:52 UTC
[Impala-ASF-CR] IMPALA-9982: Fix flakyness in test dateless timestamp text
Adam Tamas has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16334
Change subject: IMPALA-9982: Fix flakyness in test_dateless_timestamp_text
......................................................................
IMPALA-9982: Fix flakyness in test_dateless_timestamp_text
In this test there is no need to check for "Error parsing row"
since the "Error converting column" is enought to be sure we are
no longer able to read dateless timestamps.
Change-Id: Ia97490288dae81561969d260739a07ec42571f48
---
M testdata/workloads/functional-query/queries/QueryTest/dateless_timestamp_text.test
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/16334/1
--
To view, visit http://gerrit.cloudera.org:8080/16334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia97490288dae81561969d260739a07ec42571f48
Gerrit-Change-Number: 16334
Gerrit-PatchSet: 1
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9982: Fix flakyness in test dateless timestamp text
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16334 )
Change subject: IMPALA-9982: Fix flakyness in test_dateless_timestamp_text
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6909/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia97490288dae81561969d260739a07ec42571f48
Gerrit-Change-Number: 16334
Gerrit-PatchSet: 1
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Aug 2020 13:55:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9982: Fix flakyness in test dateless timestamp text
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16334 )
Change subject: IMPALA-9982: Fix flakyness in test_dateless_timestamp_text
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6287/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia97490288dae81561969d260739a07ec42571f48
Gerrit-Change-Number: 16334
Gerrit-PatchSet: 1
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Aug 2020 13:43:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9982: Fix flakyness in test dateless timestamp text
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16334 )
Change subject: IMPALA-9982: Fix flakyness in test_dateless_timestamp_text
......................................................................
IMPALA-9982: Fix flakyness in test_dateless_timestamp_text
In this test there is no need to check for "Error parsing row"
since the "Error converting column" is enought to be sure we are
no longer able to read dateless timestamps.
Change-Id: Ia97490288dae81561969d260739a07ec42571f48
Reviewed-on: http://gerrit.cloudera.org:8080/16334
Reviewed-by: Zoltan Borok-Nagy <bo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/workloads/functional-query/queries/QueryTest/dateless_timestamp_text.test
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Zoltan Borok-Nagy: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/16334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia97490288dae81561969d260739a07ec42571f48
Gerrit-Change-Number: 16334
Gerrit-PatchSet: 2
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9982: Fix flakyness in test dateless timestamp text
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16334 )
Change subject: IMPALA-9982: Fix flakyness in test_dateless_timestamp_text
......................................................................
Patch Set 1: Code-Review+2
Thanks for fixing this!
--
To view, visit http://gerrit.cloudera.org:8080/16334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia97490288dae81561969d260739a07ec42571f48
Gerrit-Change-Number: 16334
Gerrit-PatchSet: 1
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Aug 2020 13:43:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9982: Fix flakyness in test dateless timestamp text
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16334 )
Change subject: IMPALA-9982: Fix flakyness in test_dateless_timestamp_text
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia97490288dae81561969d260739a07ec42571f48
Gerrit-Change-Number: 16334
Gerrit-PatchSet: 1
Gerrit-Owner: Adam Tamas <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Aug 2020 18:58:22 +0000
Gerrit-HasComments: No