You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2018/08/16 23:20:58 UTC
Re: Review Request 63280: Made the containerizer launch be explicit
about O_CLOEXEC.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63280/#review207447
-----------------------------------------------------------
Could we rebase?
- Gilbert Song
On May 24, 2018, 2:16 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63280/
> -----------------------------------------------------------
>
> (Updated May 24, 2018, 2:16 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Benjamin Mahler, Greg Mann, and Jie Yu.
>
>
> Bugs: MESOS-8128
> https://issues.apache.org/jira/browse/MESOS-8128
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the containerizer launch depends on the inherited pipe to signal
> the forked child, be explicit about setting O_CLOEXEC on the pipe file
> descriptors. Make sure to close the pipe on the error paths.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 100e3bbda543d87808da9ff6bea42da5099ea8c5
>
>
> Diff: https://reviews.apache.org/r/63280/diff/2/
>
>
> Testing
> -------
>
> make check (Fedora 25)
>
>
> Thanks,
>
> James Peach
>
>