5.0 GA / release planning

[Oleg Kalnichevski <ol...@apache.org>]

Folks

How do feel about releasing HttpCore 5.0 GA next week and HttpClient
5.0 shortly after?

In the next development phase I imagine we could backport some of the
5.0 code to 4.x. HttpCore 4.x and HttpClient 4.x could benefit from
better connection pool implementations from 5.0.

Oleg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

Re: 5.0 GA / release planning

[Michael Osipov <mi...@apache.org>]

Am 2019-11-26 um 20:09 schrieb Oleg Kalnichevski:
> On Tue, 2019-11-26 at 19:06 +0100, Michael Osipov wrote:
>> Am 2019-11-26 um 14:55 schrieb Oleg Kalnichevski:
>>> Folks
>>>
>>> How do feel about releasing HttpCore 5.0 GA next week and
>>> HttpClient
>>> 5.0 shortly after?
>>
>> Can you hold off for one more week? I'd like to go through all
>> HttpCore
>> topics we have discussed in the last couple of weeks and report
>> those
>> which break the API or need fixing before GA, e.g., combined
>> redirect
>> strategy.
>>
>> Michael
>>
> 
> Hi Michael
> 
> I can hold off for a week but not indefinitely. I _really_ would like
> to see 5.0 GA go out this year.

This year is absolutely feasible and I share this opinion.

Michael

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

Re: 5.0 GA / release planning

[Oleg Kalnichevski <ol...@apache.org>]

On Tue, 2019-11-26 at 19:06 +0100, Michael Osipov wrote:
> Am 2019-11-26 um 14:55 schrieb Oleg Kalnichevski:
> > Folks
> > 
> > How do feel about releasing HttpCore 5.0 GA next week and
> > HttpClient
> > 5.0 shortly after?
> 
> Can you hold off for one more week? I'd like to go through all
> HttpCore 
> topics we have discussed in the last couple of weeks and report
> those 
> which break the API or need fixing before GA, e.g., combined
> redirect 
> strategy.
> 
> Michael
> 

Hi Michael

I can hold off for a week but not indefinitely. I _really_ would like
to see 5.0 GA go out this year.

Oleg



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

Re: 5.0 GA / release planning

[Michael Osipov <mi...@apache.org>]

Am 2019-11-26 um 14:55 schrieb Oleg Kalnichevski:
> Folks
> 
> How do feel about releasing HttpCore 5.0 GA next week and HttpClient
> 5.0 shortly after?

Can you hold off for one more week? I'd like to go through all HttpCore 
topics we have discussed in the last couple of weeks and report those 
which break the API or need fixing before GA, e.g., combined redirect 
strategy.

Michael

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

Re: 5.0 GA / release planning

[Michael Osipov <mi...@apache.org>]

Am 2019-11-26 um 22:10 schrieb Gary Gregory:
> One item that remains for me is to fix the consistency in naming of types.
> This is new code that will live for loooong time, so let's make it the best
> we can please. For example, we mix call CAPS and CamelCase for acronyms:
> 
> For example, these two sit right next to each other in the same package:
> 
> org.apache.hc.core5.reactor.ssl.SSLSessionVerifier
> org.apache.hc.core5.reactor.ssl.TlsDetails
> 
> Can we pick ONE convention please, either:
> 
> org.apache.hc.core5.reactor.ssl.SSLSessionVerifier
> org.apache.hc.core5.reactor.ssl.TLSDetails
> 
> or
> 
> org.apache.hc.core5.reactor.ssl.SslSessionVerifier
> org.apache.hc.core5.reactor.ssl.TlsDetails
> 
> I don't care which one at this point. We do Use "*Http*" a lot so that
> might be a hint to pick that style. I'm happy to provide a PR once we agree

I think there is a rule of thumb in Java: if the abbreviation is at most 
3 chars, you can keep it uppercase, otherwhise make it PascalCase, not 
camelCase for class names. But anyway, make it consistent.

As a side note, why keep SSL in the name at all, we only use TLS these 
days...?


> --
> 
> We also have a mix of "Http", "Http1", H2" which I find confusing. In the
> httpcore5-h2 module we have:
> 
> org.apache.hc.core5.http2.impl.nio.ServerH2StreamMultiplexerFactory
> org.apache.hc.core5.http2.impl.nio.ServerHttpProtocolNegotiator
> org.apache.hc.core5.http2.impl.nio.ServerHttpProtocolNegotiatorFactory
> 
> Why is it not:
> 
> org.apache.hc.core5.http2.impl.nio.ServerH2ProtocolNegotiator
> org.apache.hc.core5.http2.impl.nio.ServerH2ProtocolNegotiatorFactory

I agree here. The package name could have been h2 also.

> I find it weird to have "Http1" vs. "H2", it feels like another
> inconsistency.

I would avoid using terms like HTTP1 or Http1 because they have never 
been used throughout the net. Either Http10, Http11 or just Http. H2 is 
HTTP/2. Period.

Michael


> On Tue, Nov 26, 2019 at 8:55 AM Oleg Kalnichevski <ol...@apache.org> wrote:
> 
>> Folks
>>
>> How do feel about releasing HttpCore 5.0 GA next week and HttpClient
>> 5.0 shortly after?
>>
>> In the next development phase I imagine we could backport some of the
>> 5.0 code to 4.x. HttpCore 4.x and HttpClient 4.x could benefit from
>> better connection pool implementations from 5.0.
>>
>> Oleg
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
>> For additional commands, e-mail: dev-help@hc.apache.org
>>
>>
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

Re: 5.0 GA / release planning

[Gary Gregory <ga...@gmail.com>]

One item that remains for me is to fix the consistency in naming of types.
This is new code that will live for loooong time, so let's make it the best
we can please. For example, we mix call CAPS and CamelCase for acronyms:

For example, these two sit right next to each other in the same package:

org.apache.hc.core5.reactor.ssl.SSLSessionVerifier
org.apache.hc.core5.reactor.ssl.TlsDetails

Can we pick ONE convention please, either:

org.apache.hc.core5.reactor.ssl.SSLSessionVerifier
org.apache.hc.core5.reactor.ssl.TLSDetails

or

org.apache.hc.core5.reactor.ssl.SslSessionVerifier
org.apache.hc.core5.reactor.ssl.TlsDetails

I don't care which one at this point. We do Use "*Http*" a lot so that
might be a hint to pick that style. I'm happy to provide a PR once we agree.

--

We also have a mix of "Http", "Http1", H2" which I find confusing. In the
httpcore5-h2 module we have:

org.apache.hc.core5.http2.impl.nio.ServerH2StreamMultiplexerFactory
org.apache.hc.core5.http2.impl.nio.ServerHttpProtocolNegotiator
org.apache.hc.core5.http2.impl.nio.ServerHttpProtocolNegotiatorFactory

Why is it not:

org.apache.hc.core5.http2.impl.nio.ServerH2ProtocolNegotiator
org.apache.hc.core5.http2.impl.nio.ServerH2ProtocolNegotiatorFactory

?

I find it weird to have "Http1" vs. "H2", it feels like another
inconsistency.

Gary


On Tue, Nov 26, 2019 at 8:55 AM Oleg Kalnichevski <ol...@apache.org> wrote:

> Folks
>
> How do feel about releasing HttpCore 5.0 GA next week and HttpClient
> 5.0 shortly after?
>
> In the next development phase I imagine we could backport some of the
> 5.0 code to 4.x. HttpCore 4.x and HttpClient 4.x could benefit from
> better connection pool implementations from 5.0.
>
> Oleg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>

Re: 5.0 GA / release planning

[Ryan Schmitt <rs...@apache.org>]

I fully agree with your sense of urgency around getting the GA out. In
every project there comes a time to shoot the engineers and start
production.

On Sat, Nov 30, 2019 at 2:18 AM Oleg Kalnichevski <ol...@apache.org> wrote:

> On Fri, 2019-11-29 at 14:44 -0800, Ryan Schmitt wrote:
> > There is one thing I was hoping to do before the GA release, which is
> > to
> > build support for the Apache 5 client as an HTTP backend for the AWS
> > Java
> > SDK V2 (which supports pluggable HTTP clients) and run their full
> > suite of
> > integration tests. Unfortunately, the time leading up to re:Invent is
> > extremely busy around here, so I don't think the timing works out if
> > we
> > want to get 5.0 GA out this year. This is fine, I can always perform
> > this
> > testing later, there's just a higher risk of a compatibility issue
> > (particularly between core and client) preventing any newly
> > discovered bugs
> > from being fixed.
> >
>
> Hi Ryan,
>
> There will inevitably be bugs. The problem is that the longer HC
> remains in BETA the longer a substantial part of its potential user
> base will not be using it and finding those bugs. We are presently not
> gaining much by dragging out the API freeze in my opinion.
>
> I do not mind delaying 5.0 GA for a good reason but I am reluctant to
> do it for another round of pointless class renaming. The previous round
> cost us several months of wasted project time.
>
> Oleg
>
>
> > Since the SDK is open source [1], in principle any contributor could
> > perform this task and run whatever integration tests are open source.
> > (I
> > don't currently know whether we have additional test coverage that is
> > unpublished.)
> >
> > [1] https://github.com/aws/aws-sdk-java-v2
> >
> > On Tue, Nov 26, 2019 at 5:55 AM Oleg Kalnichevski <ol...@apache.org>
> > wrote:
> >
> > > Folks
> > >
> > > How do feel about releasing HttpCore 5.0 GA next week and
> > > HttpClient
> > > 5.0 shortly after?
> > >
> > > In the next development phase I imagine we could backport some of
> > > the
> > > 5.0 code to 4.x. HttpCore 4.x and HttpClient 4.x could benefit from
> > > better connection pool implementations from 5.0.
> > >
> > > Oleg
> > >
> > >
> > > -----------------------------------------------------------------
> > > ----
> > > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> > > For additional commands, e-mail: dev-help@hc.apache.org
> > >
> > >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>

Re: 5.0 GA / release planning

[Oleg Kalnichevski <ol...@apache.org>]

On Fri, 2019-11-29 at 14:44 -0800, Ryan Schmitt wrote:
> There is one thing I was hoping to do before the GA release, which is
> to
> build support for the Apache 5 client as an HTTP backend for the AWS
> Java
> SDK V2 (which supports pluggable HTTP clients) and run their full
> suite of
> integration tests. Unfortunately, the time leading up to re:Invent is
> extremely busy around here, so I don't think the timing works out if
> we
> want to get 5.0 GA out this year. This is fine, I can always perform
> this
> testing later, there's just a higher risk of a compatibility issue
> (particularly between core and client) preventing any newly
> discovered bugs
> from being fixed.
> 

Hi Ryan,

There will inevitably be bugs. The problem is that the longer HC
remains in BETA the longer a substantial part of its potential user
base will not be using it and finding those bugs. We are presently not
gaining much by dragging out the API freeze in my opinion. 

I do not mind delaying 5.0 GA for a good reason but I am reluctant to
do it for another round of pointless class renaming. The previous round
cost us several months of wasted project time.

Oleg  


> Since the SDK is open source [1], in principle any contributor could
> perform this task and run whatever integration tests are open source.
> (I
> don't currently know whether we have additional test coverage that is
> unpublished.)
> 
> [1] https://github.com/aws/aws-sdk-java-v2
> 
> On Tue, Nov 26, 2019 at 5:55 AM Oleg Kalnichevski <ol...@apache.org>
> wrote:
> 
> > Folks
> > 
> > How do feel about releasing HttpCore 5.0 GA next week and
> > HttpClient
> > 5.0 shortly after?
> > 
> > In the next development phase I imagine we could backport some of
> > the
> > 5.0 code to 4.x. HttpCore 4.x and HttpClient 4.x could benefit from
> > better connection pool implementations from 5.0.
> > 
> > Oleg
> > 
> > 
> > -----------------------------------------------------------------
> > ----
> > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> > For additional commands, e-mail: dev-help@hc.apache.org
> > 
> > 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

Re: 5.0 GA / release planning

[Ryan Schmitt <rs...@apache.org>]

There is one thing I was hoping to do before the GA release, which is to
build support for the Apache 5 client as an HTTP backend for the AWS Java
SDK V2 (which supports pluggable HTTP clients) and run their full suite of
integration tests. Unfortunately, the time leading up to re:Invent is
extremely busy around here, so I don't think the timing works out if we
want to get 5.0 GA out this year. This is fine, I can always perform this
testing later, there's just a higher risk of a compatibility issue
(particularly between core and client) preventing any newly discovered bugs
from being fixed.

Since the SDK is open source [1], in principle any contributor could
perform this task and run whatever integration tests are open source. (I
don't currently know whether we have additional test coverage that is
unpublished.)

[1] https://github.com/aws/aws-sdk-java-v2

On Tue, Nov 26, 2019 at 5:55 AM Oleg Kalnichevski <ol...@apache.org> wrote:

> Folks
>
> How do feel about releasing HttpCore 5.0 GA next week and HttpClient
> 5.0 shortly after?
>
> In the next development phase I imagine we could backport some of the
> 5.0 code to 4.x. HttpCore 4.x and HttpClient 4.x could benefit from
> better connection pool implementations from 5.0.
>
> Oleg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>