You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/24 18:02:52 UTC

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #1886: Allows network monitoring (apps repo) using polling and allows the board to provide the IP config at runtime.

acassis commented on a change in pull request #1886:
URL: https://github.com/apache/incubator-nuttx/pull/1886#discussion_r494509258



##########
File path: include/sys/boardctl.h
##########
@@ -201,20 +208,21 @@
 #define BOARDIOC_INIT              _BOARDIOC(0x0001)
 #define BOARDIOC_FINALINIT         _BOARDIOC(0x0002)
 #define BOARDIOC_POWEROFF          _BOARDIOC(0x0003)
-#define BOARDIOC_RESET             _BOARDIOC(0x0004)

Review comment:
       David, I think it is a good practice always to add your BOARDIOC to the end of this list, this way you void breaking people system for those that uses protected or kernel mode and just update the kernel. Modifying this list this way could render application to stop working or even generate dangerous faults.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org