You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by ykrips <gi...@git.apache.org> on 2014/12/19 10:31:51 UTC
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
GitHub user ykrips opened a pull request:
https://github.com/apache/tajo/pull/311
TAJO-527: Upgrade to Netty 4
This is a first try to upgrade netty. I did not optimize code yet. However, this is not easy to apply this change, and I want to hear any suggestions from anyone who has a interest on this patch.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ykrips/tajo TAJO-527
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/311.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #311
----
commit 29fe41fe5659aae3dff1bb9b43b33aa7dc2b4bc0
Author: Jihun Kang <yk...@gmail.com>
Date: 2014-12-14T09:39:39Z
TAJO-527: Upgrade to Netty 4
commit 0c705b7f62080bcbcf7821213a8ce7bf499c014c
Author: Jihun Kang <yk...@gmail.com>
Date: 2014-12-19T04:02:44Z
Merge remote-tracking branch 'upstream/master' into TAJO-527
commit cf049a3d12aab86703913b74bf6ef2e3ffb960de
Author: Jihun Kang <ji...@apache.org>
Date: 2014-12-19T08:10:29Z
TAJO-527: Upgrade to Netty 4
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-70051503
Thank you for your work. Please go ahead!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by ykrips <gi...@git.apache.org>.
Github user ykrips commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-76361169
Alright. It will be fixed up soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-67806428
Thank you for nice work. It looks awesome.
Since this work may affect an entire Tajo system, the review and test on real environments will take longer time. So, I think that it will be merged to next release instead 0.10.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by ykrips <gi...@git.apache.org>.
Github user ykrips commented on a diff in the pull request:
https://github.com/apache/tajo/pull/311#discussion_r25662261
--- Diff: tajo-pullserver/src/main/java/org/apache/tajo/pullserver/FadvisedFileRegion.java ---
@@ -158,9 +160,9 @@ public void releaseExternalResources() {
* we don't need the region to be cached anymore.
*/
public void transferSuccessful() {
- if (PullServerUtil.isNativeIOPossible() && manageOsCache && getCount() > 0) {
+ if (PullServerUtil.isNativeIOPossible() && manageOsCache && count() > 0) {
--- End diff --
@jinossy,
Thanks for posting test results on Netty4. I'll commit it soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by ykrips <gi...@git.apache.org>.
Github user ykrips commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-68243528
Hello All,
I was away from the computer for several days, and sorry for that. I have added a tricky parameter on ```testStubDisconnected``` function. MacOSX uses the completely different thread management policy than Linux, therefore other thread does not work at all. These test cases works with JDK "1.6.0_65" and "1.7.0_71" on MacOSX yosemite, and with this investigation I feel that it is needed to change some codes which uses eventloopgroup.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by ykrips <gi...@git.apache.org>.
Github user ykrips commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-69843915
Hello All,
Travis build failed for directory issues, but running test cases on my ubuntu box has passed. By the way, TestHistory testcase has sometimes failed for incorrect state and I will figure out why it has failed. After fixing up this error, optimization works will be started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by ykrips <gi...@git.apache.org>.
Github user ykrips commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-73232533
My recent work for IdleStateHandler cause this issue. I will find out another way to clear un-used resource on netty servers and clients.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by ykrips <gi...@git.apache.org>.
Github user ykrips commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-68322582
First build test passed, but second one did not. I will look through this error.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on a diff in the pull request:
https://github.com/apache/tajo/pull/311#discussion_r22766431
--- Diff: tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyClientBase.java ---
@@ -116,34 +124,24 @@ public void connect(InetSocketAddress addr) throws ConnectTimeoutException {
handleConnectionInternally(addr);
}
- public boolean isConnected() {
- return getChannel().isConnected();
+ public boolean isActive() {
+ return getChannel().isActive();
}
public InetSocketAddress getRemoteAddress() {
- if (channelFuture == null || channelFuture.getChannel() == null) {
+ if (channelFuture == null || channelFuture.channel() == null) {
return null;
}
- return (InetSocketAddress) channelFuture.getChannel().getRemoteAddress();
+ return (InetSocketAddress) channelFuture.channel().remoteAddress();
}
public Channel getChannel() {
- return channelFuture.getChannel();
+ return channelFuture.channel();
}
@Override
public void close() {
- if(this.channelFuture != null && getChannel().isOpen()) {
- try {
- getChannel().close().awaitUninterruptibly();
--- End diff --
I understood. please go ahead
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by ykrips <gi...@git.apache.org>.
Github user ykrips commented on a diff in the pull request:
https://github.com/apache/tajo/pull/311#discussion_r22715132
--- Diff: tajo-project/pom.xml ---
@@ -1028,6 +1028,26 @@
<version>4.0.24.Final</version>
</dependency>
<dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-transport</artifactId>
+ <version>4.0.24.Final</version>
--- End diff --
No problems. I will fix it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-67807199
@hyunsik
I agree with you. We need more review and test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by ykrips <gi...@git.apache.org>.
Github user ykrips commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-76564013
@hyunsik, it would be a great thing that we can run some stress tests on multiple-node clusters. We need to find out test environment for this test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-74457030
@ykrips, thanks for your great work!
I have one question, just from my curiosity. How did you evaluate the performance with Netty4?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by ykrips <gi...@git.apache.org>.
Github user ykrips commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-73452292
Hello All,
I have been working on the optimization work for network codes, and still working on. If I finished an optimization work for netty codes, I will leave a comment on this request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by ykrips <gi...@git.apache.org>.
Github user ykrips commented on a diff in the pull request:
https://github.com/apache/tajo/pull/311#discussion_r25664051
--- Diff: tajo-pullserver/src/main/java/org/apache/tajo/pullserver/FadvisedFileRegion.java ---
@@ -158,9 +160,9 @@ public void releaseExternalResources() {
* we don't need the region to be cached anymore.
*/
public void transferSuccessful() {
- if (PullServerUtil.isNativeIOPossible() && manageOsCache && getCount() > 0) {
+ if (PullServerUtil.isNativeIOPossible() && manageOsCache && count() > 0) {
--- End diff --
Interesting... Netty team added isOpen() api on DefaultFileRegion class in 4.0.25.final. It could be good to use netty api for checking if this fileregion is deallocated or not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-76879983
I’ve successfully tested by real data on my company cluster.
* ENV
* 2 TajoMaster + 4 TajoWorker
* JDK 1.7.0_67
* 1G Network
```
Json Table
2TB compressed by snappy
7.3TB Actual bytes
select count(*) from (select id from table1 group by id) t1;
Progress: 100%, response time: 3546.781 sec
?count
-------------------------------
2802809536
(1 rows, 3546.781 sec, 11 B selected)
Parquet table
8.1TB compressed by snappy
select count(*) from table2
Progress: 100%, response time: 374.358 sec
?count
-------------------------------
16090817643
(1 rows, 374.358 sec, 12 B selected)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by ykrips <gi...@git.apache.org>.
Github user ykrips commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-67738875
I did not catch up this failure when I ran test cases on my laptop. I will dig out this test failure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by ykrips <gi...@git.apache.org>.
Github user ykrips commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-73173481
@jinossy
Thank you for posting trace info. Finding a root cause of this issue will start right now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by ykrips <gi...@git.apache.org>.
Github user ykrips commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-67756999
Travis test has timed out and this issue led my test build failed. This issue may require more time to figure out what is wrong on my test build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by ykrips <gi...@git.apache.org>.
Github user ykrips commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-73200700
Well, I don't have any testing cluster for Tajo, and keep finding suitable servers for test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/311
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-67741556
No problem :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on a diff in the pull request:
https://github.com/apache/tajo/pull/311#discussion_r22711631
--- Diff: tajo-project/pom.xml ---
@@ -1028,6 +1028,26 @@
<version>4.0.24.Final</version>
</dependency>
<dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-transport</artifactId>
+ <version>4.0.24.Final</version>
--- End diff --
Could you move to properties ? and You should remove netty-3.6.6
'''
<netty.version>4.0.24.Final</netty.version>
'''
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by ykrips <gi...@git.apache.org>.
Github user ykrips commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-67814352
@jinossy ,
Thanks for posting your test results.
I have ran test cases with JDK 1.6 and JDK 1.7, and I did not find rpc hang issues on TestAsyncRpc. Can you provide the details on your test environment?
By the way, I have removed the HashedWheelTimer in TaskRunnerManager, because netty 4 does not accept the Timer object when creating ReadTimeoutHandler instance. Netty 4 uses internal scheduler when catching up the timeout event.
Anyway, thank you again, and I will look through these timeout handlers. In some cases, I found that netty 4 does not create the time-out event.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by ykrips <gi...@git.apache.org>.
Github user ykrips commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-74460025
Hello @jihoonson ,
I have done with several items. First, disabled nagle algorithm as possible. Enabling nagle algorithm will reduce the resource use on network infrastructure, but it will delay network transmission. Also, netty4 team recommend not to use flush() function frequently, but it also delays the network transmission. Second, I have set the send and receive buffer size of servers and clients as possible. Low buffer size also delays the network performance, and providers and consumers wait until the buffer is empty. Finally, I have merged and refactored the source code to use shared eventloopgroup. Creating a object which tightly coupled to the operating system resource is expensive operation, and when creating these objects frequently, it may lead starvation on native memory and network resources.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-73184226
My testing cluster is 1Master + 4Worker. Did you test on cluster ?
I also investigate the problems.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on a diff in the pull request:
https://github.com/apache/tajo/pull/311#discussion_r22711753
--- Diff: tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyClientBase.java ---
@@ -116,34 +124,24 @@ public void connect(InetSocketAddress addr) throws ConnectTimeoutException {
handleConnectionInternally(addr);
}
- public boolean isConnected() {
- return getChannel().isConnected();
+ public boolean isActive() {
+ return getChannel().isActive();
}
public InetSocketAddress getRemoteAddress() {
- if (channelFuture == null || channelFuture.getChannel() == null) {
+ if (channelFuture == null || channelFuture.channel() == null) {
return null;
}
- return (InetSocketAddress) channelFuture.getChannel().getRemoteAddress();
+ return (InetSocketAddress) channelFuture.channel().remoteAddress();
}
public Channel getChannel() {
- return channelFuture.getChannel();
+ return channelFuture.channel();
}
@Override
public void close() {
- if(this.channelFuture != null && getChannel().isOpen()) {
- try {
- getChannel().close().awaitUninterruptibly();
--- End diff --
Could you explain why does not need channel.close() ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by ykrips <gi...@git.apache.org>.
Github user ykrips commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-73183500
@jinossy,
I did not find any issues on my ubuntu box, but this issue may be related to my recent commit. This commit will be reverted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by ykrips <gi...@git.apache.org>.
Github user ykrips commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-74449106
Hello All,
It has been a long time to enable a netty4 library to tajo project. Finally, performance on netty4 was achieved to the acceptable level, and errors on Travis CI build was resolved. Now, I think, it is a time to discuss on any missing points or any potential issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-76895931
+1
I greatly appreciate your effort.
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by ykrips <gi...@git.apache.org>.
Github user ykrips commented on a diff in the pull request:
https://github.com/apache/tajo/pull/311#discussion_r22715302
--- Diff: tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyClientBase.java ---
@@ -116,34 +124,24 @@ public void connect(InetSocketAddress addr) throws ConnectTimeoutException {
handleConnectionInternally(addr);
}
- public boolean isConnected() {
- return getChannel().isConnected();
+ public boolean isActive() {
+ return getChannel().isActive();
}
public InetSocketAddress getRemoteAddress() {
- if (channelFuture == null || channelFuture.getChannel() == null) {
+ if (channelFuture == null || channelFuture.channel() == null) {
return null;
}
- return (InetSocketAddress) channelFuture.getChannel().getRemoteAddress();
+ return (InetSocketAddress) channelFuture.channel().remoteAddress();
}
public Channel getChannel() {
- return channelFuture.getChannel();
+ return channelFuture.channel();
}
@Override
public void close() {
- if(this.channelFuture != null && getChannel().isOpen()) {
- try {
- getChannel().close().awaitUninterruptibly();
--- End diff --
Sorry for that. I would like to implement reusable codes with netty channels, but I didn't have any idea on this and did not recover this code block yet. I will fix it soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-67812346
I ran test on my macbook. I got rpc hangs in TestAsyncRpc
@ykrips
Could you check the HashedWheelTimer in TaskRunnerManager ?
```
main" prio=5 tid=7fabff000800 nid=0x10ff62000 waiting on condition [10ff60000]
java.lang.Thread.State: WAITING (parking)
at sun.misc.Unsafe.park(Native Method)
- parking to wait for <7f3e47578> (a java.util.concurrent.Semaphore$NonfairSync)
at java.util.concurrent.locks.LockSupport.park(LockSupport.java:156)
at java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:811)
at java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedInterruptibly(AbstractQueuedSynchronizer.java:969)
at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireSharedInterruptibly(AbstractQueuedSynchronizer.java:1281)
at java.util.concurrent.Semaphore.acquire(Semaphore.java:286)
at org.apache.tajo.rpc.CallFuture.get(CallFuture.java:70)
at org.apache.tajo.rpc.TestAsyncRpc.testStubDisconnected(TestAsyncRpc.java:263)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124)
at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200)
at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-73170998
@ykrips
I can't run the query. If you ready to review, please let me know.
Query : select l_orderkey, l_partkey from lineitem order by l_suppkey;
QueryMaster log :
```
2015-02-06 10:58:15,158 INFO org.apache.tajo.querymaster.Stage: [eb_1423187823836_0001_000001] Task Completion Event (Total: 598, Success: 195, Killed: 0, Fail
ed: 0)
2015-02-06 10:58:15,227 ERROR org.apache.tajo.rpc.AsyncRpcClient: xxx001/xxx.xxx.xxx.xxx:26003,class org.apache.tajo.ipc.TajoResourceTrackerProtocol,java.
nio.channels.ClosedChannelException
com.google.protobuf.ServiceException: java.nio.channels.ClosedChannelException
at org.apache.tajo.rpc.AsyncRpcClient$ProxyRpcChannel$1.operationComplete(AsyncRpcClient.java:135)
at org.apache.tajo.rpc.AsyncRpcClient$ProxyRpcChannel$1.operationComplete(AsyncRpcClient.java:130)
at io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:680)
at io.netty.util.concurrent.DefaultPromise.notifyListeners0(DefaultPromise.java:603)
at io.netty.util.concurrent.DefaultPromise.notifyListeners(DefaultPromise.java:563)
at io.netty.util.concurrent.DefaultPromise.tryFailure(DefaultPromise.java:424)
at io.netty.channel.AbstractChannel$AbstractUnsafe.safeSetFailure(AbstractChannel.java:748)
at io.netty.channel.AbstractChannel$AbstractUnsafe.write(AbstractChannel.java:649)
at io.netty.channel.DefaultChannelPipeline$HeadContext.write(DefaultChannelPipeline.java:1054)
at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:658)
at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:716)
at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:651)
at io.netty.handler.codec.MessageToByteEncoder.write(MessageToByteEncoder.java:113)
at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:658)
at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:716)
at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:651)
at io.netty.handler.codec.MessageToMessageEncoder.write(MessageToMessageEncoder.java:112)
at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:658)
at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:716)
at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:651)
at io.netty.handler.timeout.IdleStateHandler.write(IdleStateHandler.java:266)
at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:658)
at io.netty.channel.AbstractChannelHandlerContext.access$2000(AbstractChannelHandlerContext.java:32)
at io.netty.channel.AbstractChannelHandlerContext$AbstractWriteTask.write(AbstractChannelHandlerContext.java:939)
at io.netty.channel.AbstractChannelHandlerContext$WriteAndFlushTask.write(AbstractChannelHandlerContext.java:991)
at io.netty.channel.AbstractChannelHandlerContext$AbstractWriteTask.run(AbstractChannelHandlerContext.java:924)
at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:380)
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:357)
at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:116)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.nio.channels.ClosedChannelException
2015-02-06 10:58:15,228 ERROR org.apache.tajo.rpc.AsyncRpcClient: RPC Exception:java.nio.channels.ClosedChannelException
2015-02-06 10:58:15,228 ERROR org.apache.tajo.worker.WorkerHeartbeatService: java.nio.channels.ClosedChannelException
com.google.protobuf.ServiceException: java.nio.channels.ClosedChannelException
at org.apache.tajo.worker.WorkerHeartbeatService$WorkerHeartbeatThread.run(WorkerHeartbeatService.java:202)
```
Worker log :
```
2015-02-06 11:00:25,439 INFO org.apache.tajo.worker.Fetcher: Get real fetch from remote host
2015-02-06 11:00:25,440 INFO org.apache.tajo.worker.Fetcher: Status: FETCH_FETCHING, URI:http://xxx004:53907/?qid=q_1423187823836_0001&sid=1&p=0&type=r&start=AAAAAAAAAbnU&end=AAAAAAAAAdEV&ta=102_0
2015-02-06 11:00:25,440 ERROR org.apache.tajo.worker.Fetcher: Fetch failed :
java.io.IOException: Connection reset by peer
at sun.nio.ch.FileDispatcherImpl.read0(Native Method)
at sun.nio.ch.SocketDispatcher.read(SocketDispatcher.java:39)
at sun.nio.ch.IOUtil.readIntoNativeBuffer(IOUtil.java:223)
at sun.nio.ch.IOUtil.read(IOUtil.java:192)
at sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:379)
at io.netty.buffer.UnpooledUnsafeDirectByteBuf.setBytes(UnpooledUnsafeDirectByteBuf.java:446)
at io.netty.buffer.AbstractByteBuf.writeBytes(AbstractByteBuf.java:881)
at io.netty.channel.socket.nio.NioSocketChannel.doReadBytes(NioSocketChannel.java:225)
at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:119)
at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:511)
at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:468)
at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:382)
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:354)
at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:116)
at java.lang.Thread.run(Thread.java:745)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-76561281
The patch looks nice to me. In order to ensure its stability, it would be great if we carry out some experiments with some heavy queries on TB-sized data sets. Anyone can help this kind of experiment?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-76193276
@ykrips
Sure, I will review soon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-67820959
@ykrips
Thanks for quick response
I think we need handle the event after rpc stub is disconnected
My env is following :
OSX : 10.9.5
JDK: 1.7.0_67-b01
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-67805867
@ykrips
Don't worry about it. I also investigate the problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-73452874
Thank you for your work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by ykrips <gi...@git.apache.org>.
Github user ykrips commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-67924728
@jinossy,
Thank you for posting your environment.
I have quickly made up the test environment on Mac OSX yosemite with JDK 1.6.0_65, and got a same problem. This test case works well on Ubuntu 14.04, so I think that this error might come from different thread management. I will look through this issue, and will post patches if I found the root cause.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on a diff in the pull request:
https://github.com/apache/tajo/pull/311#discussion_r25660324
--- Diff: tajo-pullserver/src/main/java/org/apache/tajo/pullserver/FadvisedFileRegion.java ---
@@ -158,9 +160,9 @@ public void releaseExternalResources() {
* we don't need the region to be cached anymore.
*/
public void transferSuccessful() {
- if (PullServerUtil.isNativeIOPossible() && manageOsCache && getCount() > 0) {
+ if (PullServerUtil.isNativeIOPossible() && manageOsCache && count() > 0) {
--- End diff --
Can you add file checking ?
if (PullServerUtil.isNativeIOPossible() && manageOsCache && count() > 0 && super.isOpen())
It will fix the "bad file descriptor"
```
2015-03-03 10:34:40,755 WARN org.apache.tajo.pullserver.PullServerUtil: Failed to manage OS cache for /data05/tajo/data/q_1425346386770_0001/output/1/hash-shuffle/3/263
java.lang.NullPointerException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.apache.tajo.pullserver.PullServerUtil.posixFadviseIfPossible(PullServerUtil.java:56)
at org.apache.tajo.pullserver.FadvisedFileRegion.transferSuccessful(FadvisedFileRegion.java:163)
at org.apache.tajo.pullserver.FileCloseListener.operationComplete(FileCloseListener.java:46)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by ykrips <gi...@git.apache.org>.
Github user ykrips commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-76135360
@jinossy,
I would liked to append additional patches for rpc codes using netty4. Would you please check these patches?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-527: Upgrade to Netty 4
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/311#issuecomment-76659550
@ykrips
Could you fix following error ? I ran TPCH-Q3
* Error 1
```
2015-03-02 11:41:19,399 WARN org.apache.tajo.rpc.RpcConnectionPool: Try to reconnect : server1/xxx.xxx.xxx.xxx:28091
2015-03-02 11:41:19,405 ERROR org.apache.tajo.rpc.AsyncRpcClient: server2/xxx.xxx.xxx.xxx:28091,class org.apache.tajo.ipc.TajoWorkerProtocol,java.nio.channels.ClosedCh
annelException
com.google.protobuf.ServiceException: java.nio.channels.ClosedChannelException
at org.apache.tajo.rpc.AsyncRpcClient$ProxyRpcChannel$1.operationComplete(AsyncRpcClient.java:147)
at org.apache.tajo.rpc.AsyncRpcClient$ProxyRpcChannel$1.operationComplete(AsyncRpcClient.java:142)
at io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:680)
at io.netty.util.concurrent.DefaultPromise.notifyListeners(DefaultPromise.java:567)
at io.netty.util.concurrent.DefaultPromise.tryFailure(DefaultPromise.java:424)
at io.netty.channel.AbstractChannel$AbstractUnsafe.safeSetFailure(AbstractChannel.java:754)
at io.netty.channel.AbstractChannel$AbstractUnsafe.write(AbstractChannel.java:655)
at io.netty.channel.DefaultChannelPipeline$HeadContext.write(DefaultChannelPipeline.java:1113)
at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:633)
at io.netty.channel.AbstractChannelHandlerContext.access$1900(AbstractChannelHandlerContext.java:32)
at io.netty.channel.AbstractChannelHandlerContext$AbstractWriteTask.write(AbstractChannelHandlerContext.java:908)
at io.netty.channel.AbstractChannelHandlerContext$WriteAndFlushTask.write(AbstractChannelHandlerContext.java:960)
at io.netty.channel.AbstractChannelHandlerContext$AbstractWriteTask.run(AbstractChannelHandlerContext.java:893)
at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:380)
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:357)
at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:116)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.nio.channels.ClosedChannelException
2015-03-02 11:41:19,407 ERROR org.apache.tajo.master.ContainerProxy: Connect error to server3/xxx.xxx.xxx.xxx:28091 caused by
io.netty.channel.ConnectTimeoutException: Connect error to server3/xxx.xxx.xxx.xxx:28091 caused by
at org.apache.tajo.rpc.NettyClientBase.handleConnectionInternally(NettyClientBase.java:93)
at org.apache.tajo.rpc.NettyClientBase.connect(NettyClientBase.java:103)
at org.apache.tajo.rpc.RpcConnectionPool.getConnection(RpcConnectionPool.java:96)
at org.apache.tajo.master.TajoContainerProxy.assignExecutionBlock(TajoContainerProxy.java:105)
at org.apache.tajo.master.TajoContainerProxy.launch(TajoContainerProxy.java:75)
at org.apache.tajo.worker.TajoResourceAllocator$LaunchRunner.run(TajoResourceAllocator.java:210)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
```
* Error 2
```
2015-03-02 11:41:19,406 ERROR org.apache.tajo.rpc.AsyncRpcClient: null,class org.apache.tajo.ipc.TajoWorkerProtocol,java.lang.UnsupportedOperationException: unsupported message type:
RpcProtos$RpcRequest (expected: ByteBuf, FileRegion)
com.google.protobuf.ServiceException: java.lang.UnsupportedOperationException: unsupported message type: RpcProtos$RpcRequest (expected: ByteBuf, FileRegion)
at org.apache.tajo.rpc.AsyncRpcClient$ProxyRpcChannel$1.operationComplete(AsyncRpcClient.java:147)
at org.apache.tajo.rpc.AsyncRpcClient$ProxyRpcChannel$1.operationComplete(AsyncRpcClient.java:142)
at io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:680)
at io.netty.util.concurrent.DefaultPromise.notifyListeners(DefaultPromise.java:567)
at io.netty.util.concurrent.DefaultPromise.tryFailure(DefaultPromise.java:424)
at io.netty.channel.AbstractChannel$AbstractUnsafe.safeSetFailure(AbstractChannel.java:754)
at io.netty.channel.AbstractChannel$AbstractUnsafe.write(AbstractChannel.java:669)
at io.netty.channel.DefaultChannelPipeline$HeadContext.write(DefaultChannelPipeline.java:1113)
at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:633)
at io.netty.channel.AbstractChannelHandlerContext.access$1900(AbstractChannelHandlerContext.java:32)
at io.netty.channel.AbstractChannelHandlerContext$AbstractWriteTask.write(AbstractChannelHandlerContext.java:908)
at io.netty.channel.AbstractChannelHandlerContext$WriteAndFlushTask.write(AbstractChannelHandlerContext.java:960)
at io.netty.channel.AbstractChannelHandlerContext$AbstractWriteTask.run(AbstractChannelHandlerContext.java:893)
at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:380)
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:357)
at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:116)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.UnsupportedOperationException: unsupported message type: RpcProtos$RpcRequest (expected: ByteBuf, FileRegion)
at io.netty.channel.nio.AbstractNioByteChannel.filterOutboundMessage(AbstractNioByteChannel.java:280)
at io.netty.channel.AbstractChannel$AbstractUnsafe.write(AbstractChannel.java:663)
... 10 more
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---