[jira] [Commented] (CASSANDRA-8707) Move SegmentedFile, IndexSummary and BloomFilter to utilising RefCounted

["Marcus Eriksson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-8707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303053#comment-14303053 ] 

Marcus Eriksson commented on CASSANDRA-8707:
--------------------------------------------

* SSTableDeletingTask - why not notify when deleting tmplink files?
* Memory - looks like a fix for some other issue included, break that out in a new ticket?
* BloomFilter - the protected copy constructor, why not use the hashCount and bitset from the copy that is passed in?

In general I think the new class hierarchy inside SSTableReader (TypeManager/GlobalManager/TidyManager/TypeTidy/InstanceTidier) needs to be simplified and documented (basically no comments at all right now). I find it very hard to follow, perhaps it is because of the naming of the classes (for example, the name "TypeManager" is quite generic and tells me very little) or that they are nested and access each others private fields.

> Move SegmentedFile, IndexSummary and BloomFilter to utilising RefCounted
> ------------------------------------------------------------------------
>
>                 Key: CASSANDRA-8707
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8707
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Benedict
>            Assignee: Benedict
>             Fix For: 2.1.3
>
>
> There are still a few bugs with resource management, especially around SSTableReader cleanup, esp. when intermixing with compaction. This migration should help. We can simultaneously "simplify" the logic in SSTableReader to not track the replacement chain, only to take a new reference to each of the underlying resources.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)