You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/01/08 03:09:19 UTC
[GitHub] [rocketmq] fortrueme opened a new pull request #1707: [issue
#1689]add interfaces to remove unused statsItem in BrokerStatsManager.
fortrueme opened a new pull request #1707: [issue #1689]add interfaces to remove unused statsItem in BrokerStatsManager.
URL: https://github.com/apache/rocketmq/pull/1707
## What is the purpose of the change
add interfaces to remove unused statsItem in BrokerStatsManager.
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] RongtongJin edited a comment on issue #1707: [ISSUE
#1689]add interfaces to remove unused statsItem in BrokerStatsManager.
Posted by GitBox <gi...@apache.org>.
RongtongJin edited a comment on issue #1707: [ISSUE #1689]add interfaces to remove unused statsItem in BrokerStatsManager.
URL: https://github.com/apache/rocketmq/pull/1707#issuecomment-585008746
I don't see where you use these interfaces. @zhanghaou
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] fortrueme commented on issue #1707: [issue #1689]add
interfaces to remove unused statsItem in BrokerStatsManager.
Posted by GitBox <gi...@apache.org>.
fortrueme commented on issue #1707: [issue #1689]add interfaces to remove unused statsItem in BrokerStatsManager.
URL: https://github.com/apache/rocketmq/pull/1707#issuecomment-571948466
#1707
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] fortrueme removed a comment on issue #1707: [issue
#1689]add interfaces to remove unused statsItem in BrokerStatsManager.
Posted by GitBox <gi...@apache.org>.
fortrueme removed a comment on issue #1707: [issue #1689]add interfaces to remove unused statsItem in BrokerStatsManager.
URL: https://github.com/apache/rocketmq/pull/1707#issuecomment-571948466
#1707
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] zongtanghu commented on issue #1707: [issue #1689]add
interfaces to remove unused statsItem in BrokerStatsManager.
Posted by GitBox <gi...@apache.org>.
zongtanghu commented on issue #1707: [issue #1689]add interfaces to remove unused statsItem in BrokerStatsManager.
URL: https://github.com/apache/rocketmq/pull/1707#issuecomment-571877409
@duhenglucky Hi duheng,please help to review this pr together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] zongtanghu commented on issue #1707: [issue #1689]add
interfaces to remove unused statsItem in BrokerStatsManager.
Posted by GitBox <gi...@apache.org>.
zongtanghu commented on issue #1707: [issue #1689]add interfaces to remove unused statsItem in BrokerStatsManager.
URL: https://github.com/apache/rocketmq/pull/1707#issuecomment-573525377
@duhenglucky @RongtongJin please help to review this pr together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] RongtongJin commented on issue #1707: [ISSUE #1689]add
interfaces to remove unused statsItem in BrokerStatsManager.
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on issue #1707: [ISSUE #1689]add interfaces to remove unused statsItem in BrokerStatsManager.
URL: https://github.com/apache/rocketmq/pull/1707#issuecomment-585008746
I don't see where you use these interfaces
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] zhanghaou closed pull request #1707: [ISSUE #1689]add
interfaces to remove unused statsItem in BrokerStatsManager.
Posted by GitBox <gi...@apache.org>.
zhanghaou closed pull request #1707: [ISSUE #1689]add interfaces to remove unused statsItem in BrokerStatsManager.
URL: https://github.com/apache/rocketmq/pull/1707
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] coveralls commented on issue #1707: [issue #1689]add
interfaces to remove unused statsItem in BrokerStatsManager.
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1707: [issue #1689]add interfaces to remove unused statsItem in BrokerStatsManager.
URL: https://github.com/apache/rocketmq/pull/1707#issuecomment-571875876
[](https://coveralls.io/builds/27971374)
Coverage increased (+0.08%) to 50.783% when pulling **f7a1a3c3d157f7c1fbe435cd9590d010d73cf714 on fortrueme:develop** into **1aa23556d098a90c4ab405cf92731292c539a975 on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] zhanghaou commented on issue #1707: [ISSUE #1689]add
interfaces to remove unused statsItem in BrokerStatsManager.
Posted by GitBox <gi...@apache.org>.
zhanghaou commented on issue #1707: [ISSUE #1689]add interfaces to remove unused statsItem in BrokerStatsManager.
URL: https://github.com/apache/rocketmq/pull/1707#issuecomment-585013448
According to the issue [1689](https://github.com/apache/rocketmq/issues/1689) , I just add some interfaces. If the usage of this interfaces is necessary in this pr, I will would like to fix it. @RongtongJin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services