You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by do...@apache.org on 2020/05/19 00:00:18 UTC
[spark] branch branch-2.4 updated: [SPARK-25694][SQL][FOLLOW-UP]
Move 'spark.sql.defaultUrlStreamHandlerFactory.enabled' into
StaticSQLConf.scala
This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch branch-2.4
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-2.4 by this push:
new d52ff4a [SPARK-25694][SQL][FOLLOW-UP] Move 'spark.sql.defaultUrlStreamHandlerFactory.enabled' into StaticSQLConf.scala
d52ff4a is described below
commit d52ff4a790ef6b2da5d5a7c565b498ef0376f0d2
Author: HyukjinKwon <gu...@apache.org>
AuthorDate: Tue Nov 19 09:08:20 2019 +0900
[SPARK-25694][SQL][FOLLOW-UP] Move 'spark.sql.defaultUrlStreamHandlerFactory.enabled' into StaticSQLConf.scala
This PR is a followup of https://github.com/apache/spark/pull/26530 and proposes to move the configuration `spark.sql.defaultUrlStreamHandlerFactory.enabled` to `StaticSQLConf.scala` for consistency.
To put the similar configurations together and for readability.
No.
Manually tested as described in https://github.com/apache/spark/pull/26530.
Closes #26570 from HyukjinKwon/SPARK-25694.
Authored-by: HyukjinKwon <gu...@apache.org>
Signed-off-by: HyukjinKwon <gu...@apache.org>
(cherry picked from commit 8469614c0513fbed87977d4e741649db3fdd8add)
Signed-off-by: Dongjoon Hyun <do...@apache.org>
---
.../apache/spark/sql/internal/StaticSQLConf.scala | 7 ++++++
.../apache/spark/sql/internal/SharedState.scala | 2 --
.../apache/spark/sql/internal/config/package.scala | 29 ----------------------
3 files changed, 7 insertions(+), 31 deletions(-)
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/StaticSQLConf.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/StaticSQLConf.scala
index 4b5bb85..2838423 100644
--- a/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/StaticSQLConf.scala
+++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/StaticSQLConf.scala
@@ -133,4 +133,11 @@ object StaticSQLConf {
.intConf
.checkValue(thres => thres > 0 && thres <= 128, "The threshold must be in (0,128].")
.createWithDefault(16)
+
+ val DEFAULT_URL_STREAM_HANDLER_FACTORY_ENABLED =
+ buildStaticConf("spark.sql.defaultUrlStreamHandlerFactory.enabled")
+ .doc("When true, set FsUrlStreamHandlerFactory to support ADD JAR against HDFS locations")
+ .internal()
+ .booleanConf
+ .createWithDefault(true)
}
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala b/sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala
index f94c9e4..5e8c702 100644
--- a/sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala
+++ b/sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala
@@ -33,8 +33,6 @@ import org.apache.spark.sql.catalyst.catalog._
import org.apache.spark.sql.execution.CacheManager
import org.apache.spark.sql.execution.ui.{SQLAppStatusListener, SQLAppStatusStore, SQLTab}
import org.apache.spark.sql.internal.StaticSQLConf._
-import org.apache.spark.sql.internal.config.DEFAULT_URL_STREAM_HANDLER_FACTORY_ENABLED
-import org.apache.spark.sql.streaming.StreamingQuery
import org.apache.spark.status.ElementTrackingStore
import org.apache.spark.util.{MutableURLClassLoader, Utils}
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/internal/config/package.scala b/sql/core/src/main/scala/org/apache/spark/sql/internal/config/package.scala
deleted file mode 100644
index e26c4aa..0000000
--- a/sql/core/src/main/scala/org/apache/spark/sql/internal/config/package.scala
+++ /dev/null
@@ -1,29 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.spark.sql.internal
-
-import org.apache.spark.internal.config.ConfigBuilder
-
-package object config {
-
- private[spark] val DEFAULT_URL_STREAM_HANDLER_FACTORY_ENABLED =
- ConfigBuilder("spark.sql.defaultUrlStreamHandlerFactory.enabled")
- .doc("When true, set FsUrlStreamHandlerFactory to support ADD JAR against HDFS locations")
- .booleanConf
- .createWithDefault(true)
-}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org