You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/05/21 22:13:10 UTC
Review Request 67238: Fixed a quota-related metrics bug.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67238/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod Kone.
Bugs: MESOS-8932
https://issues.apache.org/jira/browse/MESOS-8932
Repository: mesos
Description
-------
Fixed a quota-related metrics bug.
Diffs
-----
src/master/allocator/mesos/metrics.cpp 5194f5b3b3f507b36f02300775230157db3dd477
src/tests/master_quota_tests.cpp ddb2903c0b60f2929e39d6aa23dc924aec454c69
Diff: https://reviews.apache.org/r/67238/diff/1/
Testing
-------
`make check` passes
Also, the modified test in this patch, `MasterQuotaTest.RemoveSingleQuota`, fails without the metrics fix and passes with it.
Thanks,
Greg Mann
Re: Review Request 67238: Fixed a quota-related metrics bug.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67238/#review203575
-----------------------------------------------------------
Ship it!
Ship It!
- Gaston Kleiman
On May 21, 2018, 3:13 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67238/
> -----------------------------------------------------------
>
> (Updated May 21, 2018, 3:13 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod Kone.
>
>
> Bugs: MESOS-8932
> https://issues.apache.org/jira/browse/MESOS-8932
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a quota-related metrics bug.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/metrics.cpp 5194f5b3b3f507b36f02300775230157db3dd477
> src/tests/master_quota_tests.cpp ddb2903c0b60f2929e39d6aa23dc924aec454c69
>
>
> Diff: https://reviews.apache.org/r/67238/diff/1/
>
>
> Testing
> -------
>
> `make check` passes
>
> Also, the modified test in this patch, `MasterQuotaTest.RemoveSingleQuota`, fails without the metrics fix and passes with it.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67238: Fixed a quota-related metrics bug.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67238/#review203531
-----------------------------------------------------------
Ship it!
- Benjamin Mahler
On May 21, 2018, 10:13 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67238/
> -----------------------------------------------------------
>
> (Updated May 21, 2018, 10:13 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod Kone.
>
>
> Bugs: MESOS-8932
> https://issues.apache.org/jira/browse/MESOS-8932
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a quota-related metrics bug.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/metrics.cpp 5194f5b3b3f507b36f02300775230157db3dd477
> src/tests/master_quota_tests.cpp ddb2903c0b60f2929e39d6aa23dc924aec454c69
>
>
> Diff: https://reviews.apache.org/r/67238/diff/1/
>
>
> Testing
> -------
>
> `make check` passes
>
> Also, the modified test in this patch, `MasterQuotaTest.RemoveSingleQuota`, fails without the metrics fix and passes with it.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67238: Fixed a quota-related metrics bug.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67238/#review203542
-----------------------------------------------------------
PASS: Mesos patch 67238 was successfully built and tested.
Reviews applied: `['67238']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67238
- Mesos Reviewbot Windows
On May 21, 2018, 10:13 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67238/
> -----------------------------------------------------------
>
> (Updated May 21, 2018, 10:13 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod Kone.
>
>
> Bugs: MESOS-8932
> https://issues.apache.org/jira/browse/MESOS-8932
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a quota-related metrics bug.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/metrics.cpp 5194f5b3b3f507b36f02300775230157db3dd477
> src/tests/master_quota_tests.cpp ddb2903c0b60f2929e39d6aa23dc924aec454c69
>
>
> Diff: https://reviews.apache.org/r/67238/diff/1/
>
>
> Testing
> -------
>
> `make check` passes
>
> Also, the modified test in this patch, `MasterQuotaTest.RemoveSingleQuota`, fails without the metrics fix and passes with it.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67238: Fixed a quota-related metrics bug.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67238/#review203558
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67238]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 22, 2018, 12:13 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67238/
> -----------------------------------------------------------
>
> (Updated May 22, 2018, 12:13 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod Kone.
>
>
> Bugs: MESOS-8932
> https://issues.apache.org/jira/browse/MESOS-8932
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a quota-related metrics bug.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/metrics.cpp 5194f5b3b3f507b36f02300775230157db3dd477
> src/tests/master_quota_tests.cpp ddb2903c0b60f2929e39d6aa23dc924aec454c69
>
>
> Diff: https://reviews.apache.org/r/67238/diff/1/
>
>
> Testing
> -------
>
> `make check` passes
>
> Also, the modified test in this patch, `MasterQuotaTest.RemoveSingleQuota`, fails without the metrics fix and passes with it.
>
>
> Thanks,
>
> Greg Mann
>
>