Re: Bug in SVGFeOffsetElementBridge.java

[Thierry Kormann <Th...@sophia.inria.fr>]

>   It appears that FeOffset ignores primitiveUnits.  It always uses
> userSpaceOnUse.  I assume we want it do something similar to what
> convertFilterPrimitveRegion does.
> 
>   Does anyone want to pick this up or shall I?

Do you think this is a regression I made during error handling or
are you sure that it's something we forgot ?

Thierry.

-- 
Thierry Kormann
email: Thierry.Kormann@sophia.inria.fr  http://www.inria.fr/koala/tkormann/
Koala/Dyade/Bull @ INRIA - Sophia Antipolis

Re: Bug in SVGFeOffsetElementBridge.java

[Vincent Hardy <vi...@eng.sun.com>]

Looking at the code, I think the bug has been there all along. Looking
into this, we have the same problem on other filters (e.g., deviation
on GaussianBlur). I think we need to do a complete pass on all filter
bridges to fix this. I do not think I can get to this today (I need to
finish up the documentation), but I could later this week.

V.

Thierry Kormann wrote:
> 
> >   It appears that FeOffset ignores primitiveUnits.  It always uses
> > userSpaceOnUse.  I assume we want it do something similar to what
> > convertFilterPrimitveRegion does.
> >
> >   Does anyone want to pick this up or shall I?
> 
> Do you think this is a regression I made during error handling or
> are you sure that it's something we forgot ?
> 
> Thierry.
> 
> --
> Thierry Kormann
> email: Thierry.Kormann@sophia.inria.fr  http://www.inria.fr/koala/tkormann/
> Koala/Dyade/Bull @ INRIA - Sophia Antipolis
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: batik-dev-unsubscribe@xml.apache.org
> For additional commands, e-mail: batik-dev-help@xml.apache.org

Re: Bug in SVGFeOffsetElementBridge.java

[Thomas E Deweese <th...@kodak.com>]

>>>>> "TK" == Thierry Kormann <Th...@sophia.inria.fr> writes:

>> It appears that FeOffset ignores primitiveUnits.  It always uses
>> userSpaceOnUse.  I assume we want it do something similar to what
>> convertFilterPrimitveRegion does.
>> 
>> Does anyone want to pick this up or shall I?

TK> Do you think this is a regression I made during error handling or
TK> are you sure that it's something we forgot ?

    Looking at CVS it appears we just forgot it, probably means we
should check others for similar mistakes :(.