You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/06/12 01:34:30 UTC
[GitHub] [druid] paul-rogers opened a new issue, #12638: Flaky test: PrefetchableTextFilesFirehoseFactoryTest
paul-rogers opened a new issue, #12638:
URL: https://github.com/apache/druid/issues/12638
Test [failed on Travis](https://app.travis-ci.com/github/apache/druid/jobs/573231078), works on a Mac. Test passed on previous runs. No code in the PR changed anything in the code covered by this test.
```text
[ERROR] Tests run: 13, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 73.209 s <<< FAILURE! - in org.apache.druid.data.input.impl.prefetch.PrefetchableTextFilesFirehoseFactoryTest
[ERROR] org.apache.druid.data.input.impl.prefetch.PrefetchableTextFilesFirehoseFactoryTest.testWithSmallCacheAndLargeFetch Time elapsed: 60.066 s <<< ERROR!
java.lang.RuntimeException: java.util.concurrent.TimeoutException
at org.apache.druid.data.input.impl.prefetch.Fetcher.openObjectFromLocal(Fetcher.java:226)
at org.apache.druid.data.input.impl.prefetch.Fetcher.next(Fetcher.java:177)
at org.apache.druid.data.input.impl.prefetch.PrefetchableTextFilesFirehoseFactory$2.next(PrefetchableTextFilesFirehoseFactory.java:239)
at org.apache.druid.data.input.impl.prefetch.PrefetchableTextFilesFirehoseFactory$2.next(PrefetchableTextFilesFirehoseFactory.java:225)
at org.apache.druid.data.input.impl.FileIteratingFirehose.getNextLineIterator(FileIteratingFirehose.java:105)
at org.apache.druid.data.input.impl.FileIteratingFirehose.hasMore(FileIteratingFirehose.java:66)
at org.apache.druid.data.input.impl.prefetch.PrefetchableTextFilesFirehoseFactoryTest.testWithSmallCacheAndLargeFetch(PrefetchableTextFilesFirehoseFactoryTest.java:278)
```
I have observed other failures in "firehose" tests (can't recall if it is this same test), did some poking around, and noticed that the code, while using concurrency constructs, used them independently with no locking between the various objects. I suspect this leads to race conditions and occasional failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] paul-rogers commented on issue #12638: Flaky test: PrefetchableTextFilesFirehoseFactoryTest
Posted by GitBox <gi...@apache.org>.
paul-rogers commented on issue #12638:
URL: https://github.com/apache/druid/issues/12638#issuecomment-1185730998
Failed again in [this build](https://app.travis-ci.com/github/apache/druid/jobs/576754236).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] paul-rogers commented on issue #12638: Flaky test: PrefetchableTextFilesFirehoseFactoryTest
Posted by GitBox <gi...@apache.org>.
paul-rogers commented on issue #12638:
URL: https://github.com/apache/druid/issues/12638#issuecomment-1201923132
`PrefetchableTextFilesFirehoseFactoryTest.testWithCacheAndFetch` failed again in [this build](https://app.travis-ci.com/github/apache/druid/jobs/578428499).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] paul-rogers commented on issue #12638: Flaky test: PrefetchableTextFilesFirehoseFactoryTest
Posted by GitBox <gi...@apache.org>.
paul-rogers commented on issue #12638:
URL: https://github.com/apache/druid/issues/12638#issuecomment-1206642026
`PrefetchableTextFilesFirehoseFactoryTest.testReconnectWithCacheAndPrefetch` failed again in [this build](https://app.travis-ci.com/github/apache/druid/jobs/578851688). These failures are a real drag on productivity: I have to rerun the expensive Travis tests again and again so I can get to Phase 2 ITs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] paul-rogers commented on issue #12638: Flaky test: PrefetchableTextFilesFirehoseFactoryTest
Posted by GitBox <gi...@apache.org>.
paul-rogers commented on issue #12638:
URL: https://github.com/apache/druid/issues/12638#issuecomment-1154221954
Failed again [in this run](https://app.travis-ci.com/github/apache/druid/jobs/573231078). The test passes when run on the same code branch from an IDE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on issue #12638: Flaky test: PrefetchableTextFilesFirehoseFactoryTest
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 commented on issue #12638:
URL: https://github.com/apache/druid/issues/12638#issuecomment-1164331487
I have started a thread to get rid of most of the firehose related code. If we don't end up deleting that code, we could ignore these test cases in code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] paul-rogers commented on issue #12638: Flaky test: PrefetchableTextFilesFirehoseFactoryTest
Posted by GitBox <gi...@apache.org>.
paul-rogers commented on issue #12638:
URL: https://github.com/apache/druid/issues/12638#issuecomment-1154372275
Failed again [in this run](https://app.travis-ci.com/github/apache/druid/jobs/573248953). The test passes when run on the same code branch from an IDE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] paul-rogers commented on issue #12638: Flaky test: PrefetchableTextFilesFirehoseFactoryTest
Posted by GitBox <gi...@apache.org>.
paul-rogers commented on issue #12638:
URL: https://github.com/apache/druid/issues/12638#issuecomment-1159534533
Failed again in [this run](https://app.travis-ci.com/github/apache/druid/jobs/573975166):
```text
[INFO] Running org.apache.druid.data.input.impl.prefetch.PrefetchableTextFilesFirehoseFactoryTest
[ERROR] Tests run: 13, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 21.109 s <<< FAILURE! - in org.apache.druid.data.input.impl.prefetch.PrefetchableTextFilesFirehoseFactoryTest
[ERROR] org.apache.druid.data.input.impl.prefetch.PrefetchableTextFilesFirehoseFactoryTest.testReconnectWithCacheAndPrefetch Time elapsed: 8.165 s <<< ERROR!
java.lang.RuntimeException: java.util.concurrent.TimeoutException
at org.apache.druid.data.input.impl.prefetch.Fetcher.openObjectFromLocal(Fetcher.java:226)
at org.apache.druid.data.input.impl.prefetch.Fetcher.next(Fetcher.java:177)
at org.apache.druid.data.input.impl.prefetch.PrefetchableTextFilesFirehoseFactory$2.next(PrefetchableTextFilesFirehoseFactory.java:239)
at org.apache.druid.data.input.impl.prefetch.PrefetchableTextFilesFirehoseFactory$2.next(PrefetchableTextFilesFirehoseFactory.java:225)
at org.apache.druid.data.input.impl.FileIteratingFirehose.getNextLineIterator(FileIteratingFirehose.java:105)
at org.apache.druid.data.input.impl.FileIteratingFirehose.hasMore(FileIteratingFirehose.java:66)
at org.apache.druid.data.input.impl.prefetch.PrefetchableTextFilesFirehoseFactoryTest.testReconnectWithCacheAndPrefetch(PrefetchableTextFilesFirehoseFactoryTest.java:352)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
...
Caused by: java.util.concurrent.TimeoutException
... 39 more
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] paul-rogers commented on issue #12638: Flaky test: PrefetchableTextFilesFirehoseFactoryTest
Posted by GitBox <gi...@apache.org>.
paul-rogers commented on issue #12638:
URL: https://github.com/apache/druid/issues/12638#issuecomment-1220258817
`PrefetchableTextFilesFirehoseFactoryTest.testReconnectWithCacheAndPrefetch` again in [this build](https://app.travis-ci.com/github/apache/druid/jobs/580243194). Looking forward to seeing #12852 be merged!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on issue #12638: Flaky test: PrefetchableTextFilesFirehoseFactoryTest
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 commented on issue #12638:
URL: https://github.com/apache/druid/issues/12638#issuecomment-1206681880
These flaky test will be gone once https://github.com/apache/druid/pull/12852 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 closed issue #12638: Flaky UT: PrefetchableTextFilesFirehoseFactoryTest
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 closed issue #12638: Flaky UT: PrefetchableTextFilesFirehoseFactoryTest
URL: https://github.com/apache/druid/issues/12638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] paul-rogers commented on issue #12638: Flaky test: PrefetchableTextFilesFirehoseFactoryTest
Posted by GitBox <gi...@apache.org>.
paul-rogers commented on issue #12638:
URL: https://github.com/apache/druid/issues/12638#issuecomment-1159367657
Failed again in [this run](https://app.travis-ci.com/github/apache/druid/jobs/573968991).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org