You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/11/02 13:39:18 UTC
[GitHub] [ozone] adoroszlai opened a new pull request #2789: HDDS-5917. S3 acceptance test failure due to to wide assertion
adoroszlai opened a new pull request #2789:
URL: https://github.com/apache/ozone/pull/2789
## What changes were proposed in this pull request?
Remove an assertion from S3 delete-object test, where the response from S3G was expected not to contain `500`. Values of `Key`, `LastModified` or `ETag` headers may contain this substring, causing the test to fail unnecessarily, as observed in these runs:
* https://github.com/elek/ozone-build-results/tree/master/2021/07/14/8932/acceptance-unsecure/
* https://github.com/elek/ozone-build-results/tree/master/2021/10/29/11160/acceptance-unsecure/
* https://github.com/elek/ozone-build-results/tree/master/2021/11/02/11195/acceptance-unsecure/
I have not found any other test that checks for HTTP 500 code. The result code of `aws` command reflects whether it was successful or not, and `Execute` checks for that code, expecting `0`. Thus I think the assertion is not needed.
On the other hand, we can make the assertions about the specific key being present/absent a bit more strict by checking for the entire key name.
https://issues.apache.org/jira/browse/HDDS-5917
## How was this patch tested?
Regular CI:
https://github.com/adoroszlai/hadoop-ozone/runs/4079032078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on pull request #2789: HDDS-5917. S3 acceptance test failure due to too wide assertion
Posted by GitBox <gi...@apache.org>.
kerneltime commented on pull request #2789:
URL: https://github.com/apache/ozone/pull/2789#issuecomment-981911461
LGTM +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2789: HDDS-5917. S3 acceptance test failure due to too wide assertion
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2789:
URL: https://github.com/apache/ozone/pull/2789#issuecomment-982567075
Thanks @kerneltime for the review, @errose28 for reviewing and merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] errose28 merged pull request #2789: HDDS-5917. S3 acceptance test failure due to too wide assertion
Posted by GitBox <gi...@apache.org>.
errose28 merged pull request #2789:
URL: https://github.com/apache/ozone/pull/2789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org