You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/08 12:42:43 UTC
[GitHub] [tvm] PENGUINLIONG opened a new pull request #7609: Prevent host Vulkan SDK blocking cross-compilation
PENGUINLIONG opened a new pull request #7609:
URL: https://github.com/apache/tvm/pull/7609
The moved code is blocking cross-compilation with NDK. When the host system has Vulkan SDK installed while Vulkan support for cross-compilation is opted out, the current build script still attempts to include those directories that could never be found:
```
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
_glsl_std
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm/apps/cpp_rpc
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm/apps/cpp_rpc
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm/apps/cpp_rpc
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm/apps/cpp_rpc
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm/apps/cpp_rpc
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm/apps/cpp_rpc
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm/apps/cpp_rpc
_libspirv
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm/apps/cpp_rpc
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm/apps/cpp_rpc
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm/apps/cpp_rpc
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm/apps/cpp_rpc
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm/apps/cpp_rpc
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm/apps/cpp_rpc
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm/apps/cpp_rpc
_spirv
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm/apps/cpp_rpc
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm/apps/cpp_rpc
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm/apps/cpp_rpc
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm/apps/cpp_rpc
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm/apps/cpp_rpc
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm/apps/cpp_rpc
used as include directory in directory C:/Users/PENGUINLIONG/Repositories/tvm/apps/cpp_rpc
CMake Error in CMakeLists.txt:
Found relative path while evaluating include directories of "tvm_objs":
"_libspirv-NOTFOUND"
CMake Error in CMakeLists.txt:
Found relative path while evaluating include directories of
"tvm_runtime_objs":
"_libspirv-NOTFOUND"
CMake Error in apps/cpp_rpc/CMakeLists.txt:
Found relative path while evaluating include directories of "tvm_rpc":
"_libspirv-NOTFOUND"
-- Generating done
CMake Generate step failed. Build files cannot be regenerated correctly.
ninja: error: loading 'build.ninja': ϵͳҲ
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on a change in pull request #7609: Prevent host Vulkan SDK blocking cross-compilation
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #7609:
URL: https://github.com/apache/tvm/pull/7609#discussion_r589681818
##########
File path: cmake/modules/Vulkan.cmake
##########
@@ -26,13 +26,8 @@ IF USE_VULKAN)
tvm_option(USE_VULKAN_VALIDATION "Enable Vulkan API validation layers" OFF
IF USE_VULKAN)
-if(Vulkan_FOUND)
- # always set the includedir
- # avoid global retrigger of cmake
- include_directories(SYSTEM ${Vulkan_INCLUDE_DIRS})
-endif(Vulkan_FOUND)
-
if(USE_VULKAN)
+ include_directories(SYSTEM ${Vulkan_INCLUDE_DIRS})
Review comment:
move it to after the end of the if statement below
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen merged pull request #7609: Prevent host Vulkan SDK blocking cross-compilation
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #7609:
URL: https://github.com/apache/tvm/pull/7609
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org